You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by mo...@apache.org on 2011/02/16 13:39:28 UTC
svn commit: r1071227 -
/ofbiz/branches/release10.04/applications/order/src/org/ofbiz/order/order/OrderReadHelper.java
Author: mor
Date: Wed Feb 16 12:39:27 2011
New Revision: 1071227
URL: http://svn.apache.org/viewvc?rev=1071227&view=rev
Log:
Merged from trunk r1071226.
Log: Bug fix - Return total amount return by the method getOrderReturnedTotalByTypeBd() wasn't correct. Irrespective of the return type adjustment choosen by the user, all the adjustments of various types were added to the total amount.
Modified:
ofbiz/branches/release10.04/applications/order/src/org/ofbiz/order/order/OrderReadHelper.java
Modified: ofbiz/branches/release10.04/applications/order/src/org/ofbiz/order/order/OrderReadHelper.java
URL: http://svn.apache.org/viewvc/ofbiz/branches/release10.04/applications/order/src/org/ofbiz/order/order/OrderReadHelper.java?rev=1071227&r1=1071226&r2=1071227&view=diff
==============================================================================
--- ofbiz/branches/release10.04/applications/order/src/org/ofbiz/order/order/OrderReadHelper.java (original)
+++ ofbiz/branches/release10.04/applications/order/src/org/ofbiz/order/order/OrderReadHelper.java Wed Feb 16 12:39:27 2011
@@ -1818,7 +1818,7 @@ public class OrderReadHelper {
if ((returnedItem.get("returnPrice") != null) && (returnedItem.get("returnQuantity") != null)) {
returnedAmount = returnedAmount.add(returnedItem.getBigDecimal("returnPrice").multiply(returnedItem.getBigDecimal("returnQuantity")).setScale(scale, rounding));
}
- Map<String, Object> itemAdjustmentCondition = UtilMisc.toMap("returnId", returnedItem.get("returnId"), "returnItemSeqId", returnedItem.get("returnItemSeqId"));
+ Map<String, Object> itemAdjustmentCondition = UtilMisc.toMap("returnId", returnedItem.get("returnId"), "returnItemSeqId", returnedItem.get("returnItemSeqId"), "returnTypeId", returnTypeId);
returnedAmount = returnedAmount.add(getReturnAdjustmentTotal(orderHeader.getDelegator(), itemAdjustmentCondition));
if (orderId.equals(returnedItem.getString("orderId")) && (!returnHeaderList.contains(returnedItem.getString("returnId")))) {
returnHeaderList.add(returnedItem.getString("returnId"));
@@ -1828,7 +1828,7 @@ public class OrderReadHelper {
Iterator<String> returnHeaderIterator = returnHeaderList.iterator();
while (returnHeaderIterator.hasNext()) {
String returnId = returnHeaderIterator.next();
- Map<String, Object> returnHeaderAdjFilter = UtilMisc.<String, Object>toMap("returnId", returnId, "returnItemSeqId", "_NA_");
+ Map<String, Object> returnHeaderAdjFilter = UtilMisc.<String, Object>toMap("returnId", returnId, "returnItemSeqId", "_NA_", "returnTypeId", returnTypeId);
returnedAmount =returnedAmount.add(getReturnAdjustmentTotal(orderHeader.getDelegator(), returnHeaderAdjFilter)).setScale(scale, rounding);
}
return returnedAmount.setScale(scale, rounding);