You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2018/07/30 22:44:08 UTC
[kudu-CR] hms-tool: lookup master addresses config from master
Hello Alexey Serbin, Hao Hao,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/11083
to review the following change.
Change subject: hms-tool: lookup master addresses config from master
......................................................................
hms-tool: lookup master addresses config from master
The HMS check and fix tools currently use the master addresses
configuration provided on the command line to validate and fix HMS table
metadata. This only works correctly if the administrator inputs the
master addresses exactly as its configured on the masters. If the
hostports are reordered or use a slightly different format which
resolves to the same addresses, then metadata will be flagged as stale
and rewritten unnecessisarily.
This commit changes the handling so that the tools use the master
addresses returned from the ConnectToCluster mechanism already present
in the client, so that the master addresses config will match the
masters.
Change-Id: If170cebe6e5d7fa05fbd7faf18755aa57bdfeeec
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client.h
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_common.h
M src/kudu/tools/tool_action_hms.cc
6 files changed, 55 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/11083/1
--
To view, visit http://gerrit.cloudera.org:8080/11083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If170cebe6e5d7fa05fbd7faf18755aa57bdfeeec
Gerrit-Change-Number: 11083
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
[kudu-CR] hms-tool: lookup master addresses config from master
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11083 )
Change subject: hms-tool: lookup master addresses config from master
......................................................................
hms-tool: lookup master addresses config from master
The HMS check and fix tools currently use the master addresses
configuration provided on the command line to validate and fix metadata
in HMS table entries. This only works correctly if the administrator
inputs the master addresses exactly as its configured on the masters. If
the hostports are reordered or use a slightly different format which
resolves to the same addresses, then metadata will be flagged as stale
and rewritten unnecessarily. As an example, the administrator could pass
'localhost' as the master address if they ran it on the master node, but
this wouldn't be appropriate to write into the HMS.
This commit changes the handling so that the tools use the master
addresses returned from the ConnectToCluster mechanism already present
in the client, which should match the master addresses config of the
master exactly.
Change-Id: If170cebe6e5d7fa05fbd7faf18755aa57bdfeeec
Reviewed-on: http://gerrit.cloudera.org:8080/11083
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@apache.org>
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client.h
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_common.h
M src/kudu/tools/tool_action_hms.cc
6 files changed, 57 insertions(+), 24 deletions(-)
Approvals:
Kudu Jenkins: Verified
Dan Burkert: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/11083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If170cebe6e5d7fa05fbd7faf18755aa57bdfeeec
Gerrit-Change-Number: 11083
Gerrit-PatchSet: 9
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] hms-tool: lookup master addresses config from master
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11083 )
Change subject: hms-tool: lookup master addresses config from master
......................................................................
Patch Set 8: Code-Review+2
Carrying over Hao's +2.
--
To view, visit http://gerrit.cloudera.org:8080/11083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If170cebe6e5d7fa05fbd7faf18755aa57bdfeeec
Gerrit-Change-Number: 11083
Gerrit-PatchSet: 8
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 01 Aug 2018 19:47:29 +0000
Gerrit-HasComments: No
[kudu-CR] hms-tool: lookup master addresses config from master
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11083
to look at the new patch set (#5).
Change subject: hms-tool: lookup master addresses config from master
......................................................................
hms-tool: lookup master addresses config from master
The HMS check and fix tools currently use the master addresses
configuration provided on the command line to validate and fix metadata
in HMS table entries. This only works correctly if the administrator
inputs the master addresses exactly as its configured on the masters. If
the hostports are reordered or use a slightly different format which
resolves to the same addresses, then metadata will be flagged as stale
and rewritten unnecessarily.
This commit changes the handling so that the tools use the master
addresses returned from the ConnectToCluster mechanism already present
in the client, which should match the master addresses config of the
master exactly.
Change-Id: If170cebe6e5d7fa05fbd7faf18755aa57bdfeeec
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client.h
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_common.h
M src/kudu/tools/tool_action_hms.cc
6 files changed, 57 insertions(+), 24 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/11083/5
--
To view, visit http://gerrit.cloudera.org:8080/11083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If170cebe6e5d7fa05fbd7faf18755aa57bdfeeec
Gerrit-Change-Number: 11083
Gerrit-PatchSet: 5
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] hms-tool: lookup master addresses config from master
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11083 )
Change subject: hms-tool: lookup master addresses config from master
......................................................................
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/11083/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11083/3//COMMIT_MSG@14
PS3, Line 14: then metadata will be flagged as stale
: and rewritten unnecessarily.
> For my own edification, what metadata is being referred to here? Kudu metad
Yep, sorry this is referring to metadata stored in a Kudu table entry in the HMS. Will update message.
http://gerrit.cloudera.org:8080/#/c/11083/3/src/kudu/client/client-internal.h
File src/kudu/client/client-internal.h:
http://gerrit.cloudera.org:8080/#/c/11083/3/src/kudu/client/client-internal.h@194
PS3, Line 194: const std::vector<HostPort>& master_hostports() const;
:
> Nit: I'd actually prefer this comment on master_hostports_ because this is
Done
--
To view, visit http://gerrit.cloudera.org:8080/11083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If170cebe6e5d7fa05fbd7faf18755aa57bdfeeec
Gerrit-Change-Number: 11083
Gerrit-PatchSet: 4
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 31 Jul 2018 00:06:35 +0000
Gerrit-HasComments: Yes
[kudu-CR] hms-tool: lookup master addresses config from master
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11083
to look at the new patch set (#4).
Change subject: hms-tool: lookup master addresses config from master
......................................................................
hms-tool: lookup master addresses config from master
The HMS check and fix tools currently use the master addresses
configuration provided on the command line to validate and fix metadata
in HMS table entries. This only works correctly if the administrator
inputs the master addresses exactly as its configured on the masters. If
the hostports are reordered or use a slightly different format which
resolves to the same addresses, then metadata will be flagged as stale
and rewritten unnecessarily.
This commit changes the handling so that the tools use the master
addresses returned from the ConnectToCluster mechanism already present
in the client, which should match the master addresses config of the
master exactly.
Change-Id: If170cebe6e5d7fa05fbd7faf18755aa57bdfeeec
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client.h
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_common.h
M src/kudu/tools/tool_action_hms.cc
6 files changed, 55 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/11083/4
--
To view, visit http://gerrit.cloudera.org:8080/11083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If170cebe6e5d7fa05fbd7faf18755aa57bdfeeec
Gerrit-Change-Number: 11083
Gerrit-PatchSet: 4
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] hms-tool: lookup master addresses config from master
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11083
to look at the new patch set (#6).
Change subject: hms-tool: lookup master addresses config from master
......................................................................
hms-tool: lookup master addresses config from master
The HMS check and fix tools currently use the master addresses
configuration provided on the command line to validate and fix metadata
in HMS table entries. This only works correctly if the administrator
inputs the master addresses exactly as its configured on the masters. If
the hostports are reordered or use a slightly different format which
resolves to the same addresses, then metadata will be flagged as stale
and rewritten unnecessarily. As an example, the administrator could pass
'localhost' as the master address if they ran it on the master node, but
this wouldn't be appropriate to write into the HMS.
This commit changes the handling so that the tools use the master
addresses returned from the ConnectToCluster mechanism already present
in the client, which should match the master addresses config of the
master exactly.
Change-Id: If170cebe6e5d7fa05fbd7faf18755aa57bdfeeec
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client.h
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_common.h
M src/kudu/tools/tool_action_hms.cc
6 files changed, 57 insertions(+), 24 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/11083/6
--
To view, visit http://gerrit.cloudera.org:8080/11083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If170cebe6e5d7fa05fbd7faf18755aa57bdfeeec
Gerrit-Change-Number: 11083
Gerrit-PatchSet: 6
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] hms-tool: lookup master addresses config from master
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11083 )
Change subject: hms-tool: lookup master addresses config from master
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11083/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11083/3//COMMIT_MSG@14
PS3, Line 14: then metadata will be flagged as stale
: and rewritten unnecessarily.
> OK, what metadata specifically? Can you provide an example?
Sure, Kudu writes the master addresses config into the table entry in the HMS under the 'kudu.master_addresses' key. The 'hms check' tool validates that the master address passed on the command line matches that property on all Kudu tables in the HMS. If any do not, the 'hms fix' tool will overwrite the property with the (assumed correct) value provided on the command line. If that value is wrong (e.g. the admin used 'localhost' because they knew they were on the master machine), then the HMS metadata will no longer be correct. The 'check' tool would have also unnecessarily flagged that table as having stale metadata.
This commit changes the behavior so that the master addresses provided on the command line are not assumed correct, instead we assume that master's version of the master addresses config is correct.
--
To view, visit http://gerrit.cloudera.org:8080/11083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If170cebe6e5d7fa05fbd7faf18755aa57bdfeeec
Gerrit-Change-Number: 11083
Gerrit-PatchSet: 4
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 31 Jul 2018 00:17:48 +0000
Gerrit-HasComments: Yes
[kudu-CR] hms-tool: lookup master addresses config from master
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11083 )
Change subject: hms-tool: lookup master addresses config from master
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/11083/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11083/3//COMMIT_MSG@14
PS3, Line 14: then metadata will be flagged as stale
: and rewritten unnecessarily.
For my own edification, what metadata is being referred to here? Kudu metadata? Something in the HMS?
You needn't elaborate in the commit message itself; I'm sure this is just context that I lack since I haven't been reviewing all of the HMS work.
http://gerrit.cloudera.org:8080/#/c/11083/3/src/kudu/client/client-internal.h
File src/kudu/client/client-internal.h:
http://gerrit.cloudera.org:8080/#/c/11083/3/src/kudu/client/client-internal.h@194
PS3, Line 194: // Returns the master RPC host ports as configured on the most recently
: // connected to leader master.
Nit: I'd actually prefer this comment on master_hostports_ because this is clearly a simple accessor; commenting on how the state itself mutates is more useful.
--
To view, visit http://gerrit.cloudera.org:8080/11083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If170cebe6e5d7fa05fbd7faf18755aa57bdfeeec
Gerrit-Change-Number: 11083
Gerrit-PatchSet: 3
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 30 Jul 2018 23:50:29 +0000
Gerrit-HasComments: Yes
[kudu-CR] hms-tool: lookup master addresses config from master
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11083
to look at the new patch set (#2).
Change subject: hms-tool: lookup master addresses config from master
......................................................................
hms-tool: lookup master addresses config from master
The HMS check and fix tools currently use the master addresses
configuration provided on the command line to validate and fix HMS table
metadata. This only works correctly if the administrator inputs the
master addresses exactly as its configured on the masters. If the
hostports are reordered or use a slightly different format which
resolves to the same addresses, then metadata will be flagged as stale
and rewritten unnecessarily.
This commit changes the handling so that the tools use the master
addresses returned from the ConnectToCluster mechanism already present
in the client, which should match the master addresses config of the
master exactly.
Change-Id: If170cebe6e5d7fa05fbd7faf18755aa57bdfeeec
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client.h
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_common.h
M src/kudu/tools/tool_action_hms.cc
6 files changed, 55 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/11083/2
--
To view, visit http://gerrit.cloudera.org:8080/11083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If170cebe6e5d7fa05fbd7faf18755aa57bdfeeec
Gerrit-Change-Number: 11083
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] hms-tool: lookup master addresses config from master
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has removed Alexey Serbin from this change. ( http://gerrit.cloudera.org:8080/11083 )
Change subject: hms-tool: lookup master addresses config from master
......................................................................
Removed reviewer Alexey Serbin.
--
To view, visit http://gerrit.cloudera.org:8080/11083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: If170cebe6e5d7fa05fbd7faf18755aa57bdfeeec
Gerrit-Change-Number: 11083
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] hms-tool: lookup master addresses config from master
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11083 )
Change subject: hms-tool: lookup master addresses config from master
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If170cebe6e5d7fa05fbd7faf18755aa57bdfeeec
Gerrit-Change-Number: 11083
Gerrit-PatchSet: 5
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 31 Jul 2018 17:21:31 +0000
Gerrit-HasComments: No
[kudu-CR] hms-tool: lookup master addresses config from master
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11083 )
Change subject: hms-tool: lookup master addresses config from master
......................................................................
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11083/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11083/3//COMMIT_MSG@14
PS3, Line 14: then metadata will be flagged as stale
: and rewritten unnecessarily.
> Would you mind adding the example('localhost') you mentioned here to be mor
Done
--
To view, visit http://gerrit.cloudera.org:8080/11083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If170cebe6e5d7fa05fbd7faf18755aa57bdfeeec
Gerrit-Change-Number: 11083
Gerrit-PatchSet: 6
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 31 Jul 2018 23:24:38 +0000
Gerrit-HasComments: Yes
[kudu-CR] hms-tool: lookup master addresses config from master
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11083 )
Change subject: hms-tool: lookup master addresses config from master
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11083/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11083/3//COMMIT_MSG@14
PS3, Line 14: then metadata will be flagged as stale
: and rewritten unnecessarily.
> Sure, Kudu writes the master addresses config into the table entry in the H
Would you mind adding the example('localhost') you mentioned here to be more clear?
--
To view, visit http://gerrit.cloudera.org:8080/11083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If170cebe6e5d7fa05fbd7faf18755aa57bdfeeec
Gerrit-Change-Number: 11083
Gerrit-PatchSet: 5
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 31 Jul 2018 20:45:44 +0000
Gerrit-HasComments: Yes
[kudu-CR] hms-tool: lookup master addresses config from master
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11083 )
Change subject: hms-tool: lookup master addresses config from master
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11083/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11083/3//COMMIT_MSG@14
PS3, Line 14: then metadata will be flagged as stale
: and rewritten unnecessarily.
> Yep, sorry this is referring to metadata stored in a Kudu table entry in th
OK, what metadata specifically? Can you provide an example?
Also, can you elaborate on the downside of an unnecessary metadata rewrite? Why is it worth this new private API?
--
To view, visit http://gerrit.cloudera.org:8080/11083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If170cebe6e5d7fa05fbd7faf18755aa57bdfeeec
Gerrit-Change-Number: 11083
Gerrit-PatchSet: 4
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 31 Jul 2018 00:12:59 +0000
Gerrit-HasComments: Yes
[kudu-CR] hms-tool: lookup master addresses config from master
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11083 )
Change subject: hms-tool: lookup master addresses config from master
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If170cebe6e5d7fa05fbd7faf18755aa57bdfeeec
Gerrit-Change-Number: 11083
Gerrit-PatchSet: 6
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 01 Aug 2018 00:16:00 +0000
Gerrit-HasComments: No