You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/11/30 00:53:00 UTC
[jira] [Work logged] (HIVE-22557) Break up DDLSemanticAnalyzer -
extract Table constraints analyzers
[ https://issues.apache.org/jira/browse/HIVE-22557?focusedWorklogId=351471&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-351471 ]
ASF GitHub Bot logged work on HIVE-22557:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Nov/19 00:52
Start Date: 30/Nov/19 00:52
Worklog Time Spent: 10m
Work Description: miklosgergely commented on pull request #859: HIVE-22557 Break up DDLSemanticAnalyzer - extract Table constraints analyzers
URL: https://github.com/apache/hive/pull/859
DDLSemanticAnalyzer is a huge class, more than 4000 lines long. The goal is to refactor it in order to have everything cut into more handleable classes under the package org.apache.hadoop.hive.ql.exec.ddl:
- have a separate class for each analyzers
- have a package for each operation, containing an analyzer, a description, and an operation, so the amount of classes under a package is more manageable
Step #10: extract the table constraints related analyzers from DDLSemanticAnalyzer, and move them under the new package.
Also modified the framework to be able to handle `alter table ...` statements.
Also moved some of the Constraint related utilty functions from BaseSemanticAnalyzer to the ddl.table.constraint package, into a new ConstraintUtils class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 351471)
Remaining Estimate: 0h
Time Spent: 10m
> Break up DDLSemanticAnalyzer - extract Table constraints analyzers
> ------------------------------------------------------------------
>
> Key: HIVE-22557
> URL: https://issues.apache.org/jira/browse/HIVE-22557
> Project: Hive
> Issue Type: Sub-task
> Reporter: Miklos Gergely
> Assignee: Miklos Gergely
> Priority: Major
> Labels: pull-request-available, refactor-ddl
> Attachments: HIVE-22557.01.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> DDLSemanticAnalyzer is a huge class, more than 4000 lines long. The goal is to refactor it in order to have everything cut into more handleable classes under the package org.apache.hadoop.hive.ql.exec.ddl:
> * have a separate class for each analyzers
> * have a package for each operation, containing an analyzer, a description, and an operation, so the amount of classes under a package is more manageable
> Step #10: extract the table constraints related analyzers from DDLSemanticAnalyzer, and move them under the new package.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)