You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/04/10 01:17:50 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #6019: power/governor: Remove the duplicated function prototype

xiaoxiang781216 opened a new pull request, #6019:
URL: https://github.com/apache/incubator-nuttx/pull/6019

   ## Summary
   since they are declared include/nuttx/power/pm.h by:
   ```
   commit 5ce181e6b702cedbd79790fbe40aab7d29dae7c0
   Author: zhuyanlin <zh...@xiaomi.com>
   Date:   Mon Feb 14 15:32:40 2022 +0800
   
       power:govorner: add govorner to per domain.
   
       For mult domains scene,,
       activity and greety can be used at same time.
       Let user to select domain governor.
   
       Signed-off-by: zhuyanlin <zh...@xiaomi.com>
   ```
   and add static const to g_pmgovernor
   
   ## Impact
   Minor
   
   ## Testing
   Pass CI
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6019: power/governor: Remove the duplicated function prototype

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6019:
URL: https://github.com/apache/incubator-nuttx/pull/6019#discussion_r846781757


##########
drivers/power/pm_initialize.c:
##########
@@ -28,12 +28,6 @@
 
 #include "pm.h"
 
-#if defined(CONFIG_PM_GOVERNOR_ACTIVITY)

Review Comment:
   > Why this is removed?
   
   Since pm_greedy_governor_initialize and pm_activity_governor_initialize is moved to include/nuttx/power/pm.h in #5701, it is enough to only include nuttx/power/pm.h to reference these functions.
   
   > I see that `activity_governor.h` is only included from `drivers/power/pm_initialize.c` while `greedy_governor.h` is included from `drivers/power/greedy_governor.c` also, but after this change `greedy_governor.h` will become an "empty" include file, so both include files can be removed?
   
   Yes, please review the new update.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #6019: power/governor: Remove the duplicated function prototype

Posted by GitBox <gi...@apache.org>.
pkarashchenko merged PR #6019:
URL: https://github.com/apache/incubator-nuttx/pull/6019


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6019: power/governor: Remove the duplicated function prototype

Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #6019:
URL: https://github.com/apache/incubator-nuttx/pull/6019#discussion_r846777186


##########
drivers/power/pm_initialize.c:
##########
@@ -28,12 +28,6 @@
 
 #include "pm.h"
 
-#if defined(CONFIG_PM_GOVERNOR_ACTIVITY)

Review Comment:
   Why this is removed? I see that `activity_governor.h` is only included from `drivers/power/pm_initialize.c` while `greedy_governor.h` is included from `drivers/power/greedy_governor.c` also, but after this change `greedy_governor.h` will become an "empty" include file, so both include files can be removed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org