You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Sergei Ivanov (JIRA)" <ji...@codehaus.org> on 2008/06/23 19:00:26 UTC
[jira] Issue Comment Edited: (MASSEMBLY-237) lineEnding ignored in
a child project
[ http://jira.codehaus.org/browse/MASSEMBLY-237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=139331#action_139331 ]
sergei_ivanov edited comment on MASSEMBLY-237 at 6/23/08 11:59 AM:
-------------------------------------------------------------------
We have also stumbled upon this bug and I decided to find out the root cause. I checked out the plugin sources and added extra tracing info to the plugin code. After a few test runs, I realised that the bug can be fixed with a change in a single line of code.
class/method:
org.apache.maven.plugin.assembly.format.FileSetFormatter#formatFileSetForAssembly
patch against version 628941:
{noformat}
@@ -57,7 +57,7 @@
- fileSet.setDirectory( set.getDirectory() );
+ fileSet.setDirectory( archiveBaseDir.getPath() );
{noformat}
Is there a chance that it will be included in the next release?
was (Author: sergei_ivanov):
We have also stumbled upon this bug and I decided to find out the root cause. I checked out the plugin sources and added extra tracing info to the plugin code. After a few test runs, I realised that the bug can be fixed with a change in a single line of code.
class/method:
org.apache.maven.plugin.assembly.format.FileSetFormatter#formatFileSetForAssembly
patch against version 628941:
@@ -57,7 +57,7 @@
- fileSet.setDirectory( set.getDirectory() );
+ fileSet.setDirectory( archiveBaseDir.getPath() );
Is there a chance that it will be included in the next release?
> lineEnding ignored in a child project
> -------------------------------------
>
> Key: MASSEMBLY-237
> URL: http://jira.codehaus.org/browse/MASSEMBLY-237
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2-beta-1
> Environment: Windows Vista
> Reporter: Todor Todorov
> Priority: Minor
>
> I have a parent project and a child project. The child project builds an assembly composed of text files.
> <fileSet>
> <outputDirectory>bin</outputDirectory>
> <directory>src/main/bin</directory>
> <lineEnding>unix</lineEnding>
> <includes>
> <include>*.sh</include>
> </includes>
> </fileSet>
> When I build the assembly from the child project , maven adds unix endings, but when I build it from the parent project, lineEnding is being ignored.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira