You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/01/05 05:23:34 UTC
[GitHub] [pulsar] michaeljmarshall opened a new pull request #9125: [Docs]Add documentation for consumerless subscriptions and their modes
michaeljmarshall opened a new pull request #9125:
URL: https://github.com/apache/pulsar/pull/9125
### Motivation
This PR seeks to clarify subscriptions without consumers by adding new documentation. In https://github.com/apache/pulsar/issues/8906, @merlimat helped me understand these subscriptions, and this PR adds that knowledge to the documentation. [Here](https://github.com/apache/pulsar/issues/8906#issuecomment-742836792) is the specific comment that provides the basis for this PR.
### Modifications
Adds documentation in the subscription mode section to describe how subscription modes are defined and that they are undefined when there aren't consumers.
This is only a documentation change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #9125: [Docs]Add documentation for consumerless subscriptions and their modes
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on a change in pull request #9125:
URL: https://github.com/apache/pulsar/pull/9125#discussion_r552823511
##########
File path: site2/docs/concepts-messaging.md
##########
@@ -242,6 +242,12 @@ A subscription is a named configuration rule that determines how messages are de
> * If you want to achieve "message queuing" among consumers, share the same subscription name among multiple consumers(shared, failover, key_shared).
> * If you want to achieve both effects simultaneously, combine exclusive subscription mode with other subscription modes for consumers.
+### Consumerless Subscriptions and Their Corresponding Modes
+If, at any point in time, there are no consumers for a given subscription, a subscription has no specified mode. This
+includes new subscriptions and existing subscriptions that no longer have any consumers. As a consequence, there is no
+option to specify the subscription mode when creating a subscription. The mode is established when the consumer makes its
+connection, and the mode can be "changed" by restarting all consumers with a different configuration.
Review comment:
I'd like to include something that explicitly mentions the following
> if there are no consumers, a subscription has no specified mode.
Based on my reading of your change, it's implicit that a subscription's mode is undefined when there are no consumers, but I'd like it to be explicit. I found the subscription mode's mutability less than intuitive when first trying to understand them. What do you think about the following:
> When a subscription has no consumers, its subscription mode is undefined. A subscription's mode is defined when a consumer connects to the subscription, and the mode can be changed by restarting all consumers with a different configuration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a change in pull request #9125: [Docs]Add documentation for consumerless subscriptions and their modes
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #9125:
URL: https://github.com/apache/pulsar/pull/9125#discussion_r553124774
##########
File path: site2/docs/concepts-messaging.md
##########
@@ -242,6 +242,12 @@ A subscription is a named configuration rule that determines how messages are de
> * If you want to achieve "message queuing" among consumers, share the same subscription name among multiple consumers(shared, failover, key_shared).
> * If you want to achieve both effects simultaneously, combine exclusive subscription mode with other subscription modes for consumers.
+### Consumerless Subscriptions and Their Corresponding Modes
+If, at any point in time, there are no consumers for a given subscription, a subscription has no specified mode. This
+includes new subscriptions and existing subscriptions that no longer have any consumers. As a consequence, there is no
+option to specify the subscription mode when creating a subscription. The mode is established when the consumer makes its
+connection, and the mode can be "changed" by restarting all consumers with a different configuration.
Review comment:
Hi @michaeljmarshall, could you please keep the same style for the other two paragraphs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #9125: [Docs]Add documentation for consumerless subscriptions and their modes
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on a change in pull request #9125:
URL: https://github.com/apache/pulsar/pull/9125#discussion_r553723383
##########
File path: site2/docs/concepts-messaging.md
##########
@@ -242,6 +242,12 @@ A subscription is a named configuration rule that determines how messages are de
> * If you want to achieve "message queuing" among consumers, share the same subscription name among multiple consumers(shared, failover, key_shared).
> * If you want to achieve both effects simultaneously, combine exclusive subscription mode with other subscription modes for consumers.
+### Consumerless Subscriptions and Their Corresponding Modes
+If, at any point in time, there are no consumers for a given subscription, a subscription has no specified mode. This
+includes new subscriptions and existing subscriptions that no longer have any consumers. As a consequence, there is no
+option to specify the subscription mode when creating a subscription. The mode is established when the consumer makes its
+connection, and the mode can be "changed" by restarting all consumers with a different configuration.
Review comment:
I've updated all 3 paragraphs with a new commit. @Jennifer88huang and @Anonymitaet - please let me know what you think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jennifer88huang commented on a change in pull request #9125: [Docs]Add documentation for consumerless subscriptions and their modes
Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on a change in pull request #9125:
URL: https://github.com/apache/pulsar/pull/9125#discussion_r553056310
##########
File path: site2/docs/concepts-messaging.md
##########
@@ -242,6 +242,12 @@ A subscription is a named configuration rule that determines how messages are de
> * If you want to achieve "message queuing" among consumers, share the same subscription name among multiple consumers(shared, failover, key_shared).
> * If you want to achieve both effects simultaneously, combine exclusive subscription mode with other subscription modes for consumers.
+### Consumerless Subscriptions and Their Corresponding Modes
+If, at any point in time, there are no consumers for a given subscription, a subscription has no specified mode. This
+includes new subscriptions and existing subscriptions that no longer have any consumers. As a consequence, there is no
+option to specify the subscription mode when creating a subscription. The mode is established when the consumer makes its
+connection, and the mode can be "changed" by restarting all consumers with a different configuration.
Review comment:
I think it's much better
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jennifer88huang commented on a change in pull request #9125: [Docs]Add documentation for consumerless subscriptions and their modes
Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on a change in pull request #9125:
URL: https://github.com/apache/pulsar/pull/9125#discussion_r552619360
##########
File path: site2/docs/concepts-messaging.md
##########
@@ -242,6 +242,12 @@ A subscription is a named configuration rule that determines how messages are de
> * If you want to achieve "message queuing" among consumers, share the same subscription name among multiple consumers(shared, failover, key_shared).
> * If you want to achieve both effects simultaneously, combine exclusive subscription mode with other subscription modes for consumers.
+### Consumerless Subscriptions and Their Corresponding Modes
+If, at any point in time, there are no consumers for a given subscription, a subscription has no specified mode. This
+includes new subscriptions and existing subscriptions that no longer have any consumers. As a consequence, there is no
+option to specify the subscription mode when creating a subscription. The mode is established when the consumer makes its
+connection, and the mode can be "changed" by restarting all consumers with a different configuration.
Review comment:
Could we refine it as follows?
When a subscription has no consumers, you cannot specify the subscription mode. You can specify the subscription mode when a consumer connects to the subscription, and you can change the subscription mode by restarting all consumers with a different configuration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie merged pull request #9125: [Docs]Add documentation for consumerless subscriptions and their modes
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #9125:
URL: https://github.com/apache/pulsar/pull/9125
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a change in pull request #9125: [Docs]Add documentation for consumerless subscriptions and their modes
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #9125:
URL: https://github.com/apache/pulsar/pull/9125#discussion_r553124844
##########
File path: site2/docs/concepts-messaging.md
##########
@@ -242,6 +242,12 @@ A subscription is a named configuration rule that determines how messages are de
> * If you want to achieve "message queuing" among consumers, share the same subscription name among multiple consumers(shared, failover, key_shared).
> * If you want to achieve both effects simultaneously, combine exclusive subscription mode with other subscription modes for consumers.
+### Consumerless Subscriptions and Their Corresponding Modes
+If, at any point in time, there are no consumers for a given subscription, a subscription has no specified mode. This
+includes new subscriptions and existing subscriptions that no longer have any consumers. As a consequence, there is no
+option to specify the subscription mode when creating a subscription. The mode is established when the consumer makes its
+connection, and the mode can be "changed" by restarting all consumers with a different configuration.
Review comment:
Hi @michaeljmarshall, could you please keep the same style for the other two paragraphs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jennifer88huang commented on a change in pull request #9125: [Docs]Add documentation for consumerless subscriptions and their modes
Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on a change in pull request #9125:
URL: https://github.com/apache/pulsar/pull/9125#discussion_r552619360
##########
File path: site2/docs/concepts-messaging.md
##########
@@ -242,6 +242,12 @@ A subscription is a named configuration rule that determines how messages are de
> * If you want to achieve "message queuing" among consumers, share the same subscription name among multiple consumers(shared, failover, key_shared).
> * If you want to achieve both effects simultaneously, combine exclusive subscription mode with other subscription modes for consumers.
+### Consumerless Subscriptions and Their Corresponding Modes
+If, at any point in time, there are no consumers for a given subscription, a subscription has no specified mode. This
+includes new subscriptions and existing subscriptions that no longer have any consumers. As a consequence, there is no
+option to specify the subscription mode when creating a subscription. The mode is established when the consumer makes its
+connection, and the mode can be "changed" by restarting all consumers with a different configuration.
Review comment:
@michaeljmarshall thank you for your contribution. Could we refine it as follows?
When a subscription has no consumers, you cannot specify the subscription mode. You can specify the subscription mode when a consumer connects to the subscription, and you can change the subscription mode by restarting all consumers with a different configuration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #9125: [Docs]Add documentation for consumerless subscriptions and their modes
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #9125:
URL: https://github.com/apache/pulsar/pull/9125#issuecomment-754405034
I read through the documentation on how to add documentation, and I think I did the right things here, but please let me know if anything needs to be fixed. Thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org