[GitHub] twill pull request #18: Fix reset log level for runnables started up later

[yaojiefeng <gi...@git.apache.org>]

GitHub user yaojiefeng opened a pull request:

    https://github.com/apache/twill/pull/18

    Fix reset log level for runnables started up later

    There is a bug when we try to reset log levels for some runnables which are started up later, e.g, restart or instance changes, after some runtime log level changes. For now, when we start up the `TwillContainerService`, we set log levels based on the what we try to set in `TwillPreparer` + runtime log levels. But we do not memorize the old log level for loggers changed at runtime. So we we reset, we will not get back to the state we want.
    This PR fixes this by memorizing the log level changes coming from runtime. And remove when we call reset.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yaojiefeng/twill fix/remember-the-runtime-log-level-change-during-startup

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/twill/pull/18.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #18
    
----
commit ae01446bfd9c02982428b8b25ec7fe40b33c89f6
Author: yaojiefeng <ya...@cask.co>
Date:   2016-12-13T12:03:55Z

    fix reset log level for runnables

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] twill pull request #18: Fix reset log level for runnables started up later

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/twill/pull/18


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] twill issue #18: Fix reset log level for runnables started up later

[chtyim <gi...@git.apache.org>]

Github user chtyim commented on the issue:

    https://github.com/apache/twill/pull/18
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---