You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/30 07:00:15 UTC
[GitHub] [flink] wangyang0918 opened a new pull request #10971:
[FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous
operations in Fabric8FlinkKubeClient
wangyang0918 opened a new pull request #10971: [FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous operations in Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10971
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
We should not use the ForkJoinPool#commonPool() in order to run asynchronous operations in the Fabric8FlinkKubeClient as it is done here. Since we don't know which other component is using this pool, it can be quite dangerous to use it as there might be congestion.
Instead, I propose to provide an explicit I/O Executor which is used for running asynchronous operations.
## Brief change log
* Use explicit I/O Executor for asynchronous operations in Fabric8FlinkKubeClient
## Verifying this change
* All the tests should work well
* Manually starting a Flink cluster on K8s
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 edited a comment on issue #10971:
[FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous
operations in Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
wangyang0918 edited a comment on issue #10971: [FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous operations in Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10971#issuecomment-581287651
Hi @tillrohrmann. Thanks for your comments.
I have added an internal class `Fabric8FlinkKubeClient#ExecutorWrapper`. Its responsibility is to get the executor to run asynchronous operations on. It could create a dedicated thread pool or reuse an existing one.
However, i am not sure it is really what you mean to. Please take a look at your convenience.
After the changes, some tests need to be updated to call `Fabric8FlinkKubeClient#close`. We do not need to do this before because the `Fabric8FlinkKubeClient#internalClient` will be closed automatically. See `MixedKubernetesServer`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #10971:
[FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous
operations in Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #10971: [FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous operations in Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10971#discussion_r373479496
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/Fabric8FlinkKubeClient.java
##########
@@ -81,6 +85,8 @@
private final List<Decorator<Deployment, KubernetesDeployment>> flinkMasterDeploymentDecorators = new ArrayList<>();
private final List<Decorator<Pod, KubernetesPod>> taskManagerPodDecorators = new ArrayList<>();
+ private final ExecutorService executorService = Executors.newFixedThreadPool(4, new ExecutorThreadFactory("Flink-KubeClient-IO"));
Review comment:
Usually, a more flexible approach is to pass in an `Executor` to the `Fabric8FlinkKubeClient`. Then an external component is responsible for the management of the executor. However, on needs to make sure that the `Fabric8FlinkKubeClient` does not live longer than the passed in `Executor`. One could then for example also write a wrapper whose responsibility is the management of the executor. This separates concerns better and it would give one the opportunity to decide whether to create a dedicated thread pool or to reuse an existing one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 removed a comment on issue #10971:
[FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous
operations in Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
wangyang0918 removed a comment on issue #10971: [FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous operations in Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10971#issuecomment-580606278
@flinkbot run travis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 edited a comment on issue #10971:
[FLINK-15791][k8s] Use explicit I/O Executor for asynchronous operations in
Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
wangyang0918 edited a comment on issue #10971: [FLINK-15791][k8s] Use explicit I/O Executor for asynchronous operations in Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10971#issuecomment-581287651
Hi @tillrohrmann. Thanks for your comments.
I have added an internal class `Fabric8FlinkKubeClient#ExecutorWrapper`. Its responsibility is to get the executor to run asynchronous operations on. It could create a dedicated thread pool or reuse an existing one.
Please take a look at your convenience.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10971:
[FLINK-15791][k8s] Use explicit I/O Executor for asynchronous operations in
Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10971: [FLINK-15791][k8s] Use explicit I/O Executor for asynchronous operations in Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10971#issuecomment-580116900
<!--
Meta data
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146711109 TriggerType:PUSH TriggerID:f769194571216372e83fdff8d9898fd693079498
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668 TriggerType:PUSH TriggerID:f769194571216372e83fdff8d9898fd693079498
Hash:f769194571216372e83fdff8d9898fd693079498 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/146711109 TriggerType:MANUAL TriggerID:580606278
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668 TriggerType:MANUAL TriggerID:580606278
Hash:2fcf6bfea870ac7578e8015f6502893abe866e75 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147155576 TriggerType:PUSH TriggerID:2fcf6bfea870ac7578e8015f6502893abe866e75
Hash:2fcf6bfea870ac7578e8015f6502893abe866e75 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4763 TriggerType:PUSH TriggerID:2fcf6bfea870ac7578e8015f6502893abe866e75
Hash:539957eb3eebf7968f336b28a343f2e229c79bc6 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147177503 TriggerType:PUSH TriggerID:539957eb3eebf7968f336b28a343f2e229c79bc6
Hash:539957eb3eebf7968f336b28a343f2e229c79bc6 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4770 TriggerType:PUSH TriggerID:539957eb3eebf7968f336b28a343f2e229c79bc6
Hash:ad97232ad6c202786094c50f3e5333735dab35d1 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4782 TriggerType:PUSH TriggerID:ad97232ad6c202786094c50f3e5333735dab35d1
Hash:ad97232ad6c202786094c50f3e5333735dab35d1 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147207665 TriggerType:PUSH TriggerID:ad97232ad6c202786094c50f3e5333735dab35d1
Hash:51d76b2f9b16f9b136bc62168f5c20ac2700daee Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:51d76b2f9b16f9b136bc62168f5c20ac2700daee
Hash:1f91c1d489cfe3bd139fc5f9be3d981c0ec7dd3a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147213520 TriggerType:PUSH TriggerID:1f91c1d489cfe3bd139fc5f9be3d981c0ec7dd3a
Hash:1f91c1d489cfe3bd139fc5f9be3d981c0ec7dd3a Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4786 TriggerType:PUSH TriggerID:1f91c1d489cfe3bd139fc5f9be3d981c0ec7dd3a
Hash:e2f646e5e5c1c83c7f895bd83b9fb7b64de83164 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/149425175 TriggerType:PUSH TriggerID:e2f646e5e5c1c83c7f895bd83b9fb7b64de83164
-->
## CI report:
* f769194571216372e83fdff8d9898fd693079498 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146711109) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668)
* 2fcf6bfea870ac7578e8015f6502893abe866e75 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147155576) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4763)
* 539957eb3eebf7968f336b28a343f2e229c79bc6 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147177503) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4770)
* ad97232ad6c202786094c50f3e5333735dab35d1 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147207665) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4782)
* 51d76b2f9b16f9b136bc62168f5c20ac2700daee UNKNOWN
* 1f91c1d489cfe3bd139fc5f9be3d981c0ec7dd3a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147213520) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4786)
* e2f646e5e5c1c83c7f895bd83b9fb7b64de83164 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/149425175)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10971:
[FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous
operations in Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10971: [FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous operations in Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10971#issuecomment-580111624
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit f769194571216372e83fdff8d9898fd693079498 (Thu Jan 30 07:02:03 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15791).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10971:
[FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous
operations in Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10971: [FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous operations in Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10971#issuecomment-580116900
<!--
Meta data
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146711109 TriggerType:PUSH TriggerID:f769194571216372e83fdff8d9898fd693079498
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668 TriggerType:PUSH TriggerID:f769194571216372e83fdff8d9898fd693079498
Hash:f769194571216372e83fdff8d9898fd693079498 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/146711109 TriggerType:MANUAL TriggerID:580606278
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668 TriggerType:MANUAL TriggerID:580606278
Hash:2fcf6bfea870ac7578e8015f6502893abe866e75 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147155576 TriggerType:PUSH TriggerID:2fcf6bfea870ac7578e8015f6502893abe866e75
Hash:2fcf6bfea870ac7578e8015f6502893abe866e75 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4763 TriggerType:PUSH TriggerID:2fcf6bfea870ac7578e8015f6502893abe866e75
Hash:539957eb3eebf7968f336b28a343f2e229c79bc6 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147177503 TriggerType:PUSH TriggerID:539957eb3eebf7968f336b28a343f2e229c79bc6
Hash:539957eb3eebf7968f336b28a343f2e229c79bc6 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4770 TriggerType:PUSH TriggerID:539957eb3eebf7968f336b28a343f2e229c79bc6
Hash:ad97232ad6c202786094c50f3e5333735dab35d1 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4782 TriggerType:PUSH TriggerID:ad97232ad6c202786094c50f3e5333735dab35d1
Hash:ad97232ad6c202786094c50f3e5333735dab35d1 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147207665 TriggerType:PUSH TriggerID:ad97232ad6c202786094c50f3e5333735dab35d1
Hash:51d76b2f9b16f9b136bc62168f5c20ac2700daee Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:51d76b2f9b16f9b136bc62168f5c20ac2700daee
Hash:1f91c1d489cfe3bd139fc5f9be3d981c0ec7dd3a Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:1f91c1d489cfe3bd139fc5f9be3d981c0ec7dd3a
-->
## CI report:
* f769194571216372e83fdff8d9898fd693079498 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146711109) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668)
* 2fcf6bfea870ac7578e8015f6502893abe866e75 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147155576) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4763)
* 539957eb3eebf7968f336b28a343f2e229c79bc6 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147177503) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4770)
* ad97232ad6c202786094c50f3e5333735dab35d1 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147207665) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4782)
* 51d76b2f9b16f9b136bc62168f5c20ac2700daee UNKNOWN
* 1f91c1d489cfe3bd139fc5f9be3d981c0ec7dd3a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10971:
[FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous
operations in Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10971: [FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous operations in Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10971#issuecomment-580116900
<!--
Meta data
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146711109 TriggerType:PUSH TriggerID:f769194571216372e83fdff8d9898fd693079498
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668 TriggerType:PUSH TriggerID:f769194571216372e83fdff8d9898fd693079498
Hash:f769194571216372e83fdff8d9898fd693079498 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/146711109 TriggerType:MANUAL TriggerID:580606278
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668 TriggerType:MANUAL TriggerID:580606278
Hash:2fcf6bfea870ac7578e8015f6502893abe866e75 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147155576 TriggerType:PUSH TriggerID:2fcf6bfea870ac7578e8015f6502893abe866e75
Hash:2fcf6bfea870ac7578e8015f6502893abe866e75 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4763 TriggerType:PUSH TriggerID:2fcf6bfea870ac7578e8015f6502893abe866e75
-->
## CI report:
* f769194571216372e83fdff8d9898fd693079498 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146711109) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668)
* 2fcf6bfea870ac7578e8015f6502893abe866e75 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147155576) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4763)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #10971:
[FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous
operations in Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #10971: [FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous operations in Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10971#discussion_r373477951
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/Fabric8FlinkKubeClient.java
##########
@@ -81,6 +85,8 @@
private final List<Decorator<Deployment, KubernetesDeployment>> flinkMasterDeploymentDecorators = new ArrayList<>();
private final List<Decorator<Pod, KubernetesPod>> taskManagerPodDecorators = new ArrayList<>();
+ private final ExecutorService executorService = Executors.newFixedThreadPool(4, new ExecutorThreadFactory("Flink-KubeClient-IO"));
Review comment:
The lifecycle management of `executorService` is missing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10971:
[FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous
operations in Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10971: [FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous operations in Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10971#issuecomment-580116900
<!--
Meta data
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146711109 TriggerType:PUSH TriggerID:f769194571216372e83fdff8d9898fd693079498
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668 TriggerType:PUSH TriggerID:f769194571216372e83fdff8d9898fd693079498
Hash:f769194571216372e83fdff8d9898fd693079498 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/146711109 TriggerType:MANUAL TriggerID:580606278
-->
## CI report:
* f769194571216372e83fdff8d9898fd693079498 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/146711109) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10971:
[FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous
operations in Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10971: [FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous operations in Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10971#issuecomment-580116900
<!--
Meta data
Hash:f769194571216372e83fdff8d9898fd693079498 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:f769194571216372e83fdff8d9898fd693079498
-->
## CI report:
* f769194571216372e83fdff8d9898fd693079498 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 commented on issue #10971: [FLINK-15791][k8s]
Use explicit I/O Executor for asynchronous operations in
Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on issue #10971: [FLINK-15791][k8s] Use explicit I/O Executor for asynchronous operations in Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10971#issuecomment-592463777
This PR needs to rebase on the new decorator #11233 after it is merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 edited a comment on issue #10971:
[FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous
operations in Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
wangyang0918 edited a comment on issue #10971: [FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous operations in Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10971#issuecomment-581287651
Hi @tillrohrmann. Thanks for your comments.
I have added an internal class `Fabric8FlinkKubeClient#ExecutorWrapper`. Its responsibility is to get the executor to run asynchronous operations on. It could create a dedicated thread pool or reuse an existing one.
However, i am not sure it is really what you mean to. Please take a look at your convenience.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10971:
[FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous
operations in Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10971: [FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous operations in Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10971#issuecomment-580116900
<!--
Meta data
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146711109 TriggerType:PUSH TriggerID:f769194571216372e83fdff8d9898fd693079498
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668 TriggerType:PUSH TriggerID:f769194571216372e83fdff8d9898fd693079498
Hash:f769194571216372e83fdff8d9898fd693079498 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/146711109 TriggerType:MANUAL TriggerID:580606278
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668 TriggerType:MANUAL TriggerID:580606278
-->
## CI report:
* f769194571216372e83fdff8d9898fd693079498 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146711109) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10971:
[FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous
operations in Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10971: [FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous operations in Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10971#issuecomment-580116900
<!--
Meta data
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146711109 TriggerType:PUSH TriggerID:f769194571216372e83fdff8d9898fd693079498
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668 TriggerType:PUSH TriggerID:f769194571216372e83fdff8d9898fd693079498
Hash:f769194571216372e83fdff8d9898fd693079498 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/146711109 TriggerType:MANUAL TriggerID:580606278
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668 TriggerType:MANUAL TriggerID:580606278
Hash:2fcf6bfea870ac7578e8015f6502893abe866e75 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147155576 TriggerType:PUSH TriggerID:2fcf6bfea870ac7578e8015f6502893abe866e75
Hash:2fcf6bfea870ac7578e8015f6502893abe866e75 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4763 TriggerType:PUSH TriggerID:2fcf6bfea870ac7578e8015f6502893abe866e75
Hash:539957eb3eebf7968f336b28a343f2e229c79bc6 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147177503 TriggerType:PUSH TriggerID:539957eb3eebf7968f336b28a343f2e229c79bc6
Hash:539957eb3eebf7968f336b28a343f2e229c79bc6 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4770 TriggerType:PUSH TriggerID:539957eb3eebf7968f336b28a343f2e229c79bc6
Hash:ad97232ad6c202786094c50f3e5333735dab35d1 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4782 TriggerType:PUSH TriggerID:ad97232ad6c202786094c50f3e5333735dab35d1
Hash:ad97232ad6c202786094c50f3e5333735dab35d1 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147207665 TriggerType:PUSH TriggerID:ad97232ad6c202786094c50f3e5333735dab35d1
Hash:51d76b2f9b16f9b136bc62168f5c20ac2700daee Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:51d76b2f9b16f9b136bc62168f5c20ac2700daee
Hash:1f91c1d489cfe3bd139fc5f9be3d981c0ec7dd3a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147213520 TriggerType:PUSH TriggerID:1f91c1d489cfe3bd139fc5f9be3d981c0ec7dd3a
Hash:1f91c1d489cfe3bd139fc5f9be3d981c0ec7dd3a Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4786 TriggerType:PUSH TriggerID:1f91c1d489cfe3bd139fc5f9be3d981c0ec7dd3a
-->
## CI report:
* f769194571216372e83fdff8d9898fd693079498 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146711109) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668)
* 2fcf6bfea870ac7578e8015f6502893abe866e75 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147155576) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4763)
* 539957eb3eebf7968f336b28a343f2e229c79bc6 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147177503) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4770)
* ad97232ad6c202786094c50f3e5333735dab35d1 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147207665) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4782)
* 51d76b2f9b16f9b136bc62168f5c20ac2700daee UNKNOWN
* 1f91c1d489cfe3bd139fc5f9be3d981c0ec7dd3a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147213520) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4786)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #10971:
[FLINK-15791][k8s] Use explicit I/O Executor for asynchronous operations in
Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #10971: [FLINK-15791][k8s] Use explicit I/O Executor for asynchronous operations in Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10971#discussion_r387819556
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/Fabric8FlinkKubeClient.java
##########
@@ -355,4 +372,33 @@ private int getServiceNodePort(Service service, ConfigOption<Integer> configPort
}
return port;
}
+
+ /**
+ * The help class to get the executor to run asynchronous operations on. It could create a dedicated thread pool or
+ * reuse an existing one.
+ */
+ private static class ExecutorWrapper {
+
+ private final ExecutorService internalExecutorService;
+ private Executor executor = null;
+
+ ExecutorWrapper(Configuration flinkConfig) {
+ internalExecutorService = Executors.newFixedThreadPool(
+ flinkConfig.getInteger(KubernetesConfigOptions.CLIENT_ASYNC_THREAD_POOL_SIZE),
+ new ExecutorThreadFactory("FlinkKubeClient-IO"));
+ }
+
+ ExecutorWrapper(Configuration flinkConfig, Executor executor) {
+ this(flinkConfig);
+ this.executor = executor;
+ }
+
+ Executor getExecutor() {
+ return executor == null ? this.internalExecutorService : executor;
+ }
+
+ public void close() {
+ ExecutorUtils.gracefulShutdown(5, TimeUnit.SECONDS, this.internalExecutorService);
+ }
+ }
Review comment:
I think your idea here goes in the right direction. But instead of mixing the cases (providing an explicit `Executor` vs. creating your own executor service), I would suggest to split them and have two implementations of `ExecutorWrapper`. At least we should change the implementation that we don't always create a `internalExecutorService`. One could do this by only allowing two factory methods for the `ExecutorWrapper`, one for the `Executor` case and the other for the internal executor. Then one of internal fields of `ExecutorWrapper` would be `null` and the other would be not `null`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10971:
[FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous
operations in Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10971: [FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous operations in Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10971#issuecomment-580116900
<!--
Meta data
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146711109 TriggerType:PUSH TriggerID:f769194571216372e83fdff8d9898fd693079498
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668 TriggerType:PUSH TriggerID:f769194571216372e83fdff8d9898fd693079498
Hash:f769194571216372e83fdff8d9898fd693079498 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/146711109 TriggerType:MANUAL TriggerID:580606278
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668 TriggerType:MANUAL TriggerID:580606278
Hash:2fcf6bfea870ac7578e8015f6502893abe866e75 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147155576 TriggerType:PUSH TriggerID:2fcf6bfea870ac7578e8015f6502893abe866e75
Hash:2fcf6bfea870ac7578e8015f6502893abe866e75 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4763 TriggerType:PUSH TriggerID:2fcf6bfea870ac7578e8015f6502893abe866e75
Hash:539957eb3eebf7968f336b28a343f2e229c79bc6 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147177503 TriggerType:PUSH TriggerID:539957eb3eebf7968f336b28a343f2e229c79bc6
Hash:539957eb3eebf7968f336b28a343f2e229c79bc6 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4770 TriggerType:PUSH TriggerID:539957eb3eebf7968f336b28a343f2e229c79bc6
Hash:ad97232ad6c202786094c50f3e5333735dab35d1 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4782 TriggerType:PUSH TriggerID:ad97232ad6c202786094c50f3e5333735dab35d1
Hash:ad97232ad6c202786094c50f3e5333735dab35d1 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147207665 TriggerType:PUSH TriggerID:ad97232ad6c202786094c50f3e5333735dab35d1
Hash:51d76b2f9b16f9b136bc62168f5c20ac2700daee Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:51d76b2f9b16f9b136bc62168f5c20ac2700daee
-->
## CI report:
* f769194571216372e83fdff8d9898fd693079498 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146711109) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668)
* 2fcf6bfea870ac7578e8015f6502893abe866e75 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147155576) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4763)
* 539957eb3eebf7968f336b28a343f2e229c79bc6 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147177503) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4770)
* ad97232ad6c202786094c50f3e5333735dab35d1 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147207665) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4782)
* 51d76b2f9b16f9b136bc62168f5c20ac2700daee UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 commented on issue #10971:
[FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous
operations in Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on issue #10971: [FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous operations in Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10971#issuecomment-581287651
Hi @tillrohrmann. Thanks for your comments.
I have added an internal class `Fabric8FlinkKubeClient#ExecutorWrapper`. Its responsibility is to get the executor to run asynchronous operations on. It could create a dedicated thread pool or reuse an existing one.
However, i am not sure it is really what you mean to. Please take a look at your convenience.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10971:
[FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous
operations in Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10971: [FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous operations in Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10971#issuecomment-580116900
<!--
Meta data
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146711109 TriggerType:PUSH TriggerID:f769194571216372e83fdff8d9898fd693079498
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668 TriggerType:PUSH TriggerID:f769194571216372e83fdff8d9898fd693079498
Hash:f769194571216372e83fdff8d9898fd693079498 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/146711109 TriggerType:MANUAL TriggerID:580606278
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668 TriggerType:MANUAL TriggerID:580606278
-->
## CI report:
* f769194571216372e83fdff8d9898fd693079498 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/146711109) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 commented on issue #10971: [FLINK-15791][k8s]
Use explicit I/O Executor for asynchronous operations in
Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on issue #10971: [FLINK-15791][k8s] Use explicit I/O Executor for asynchronous operations in Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10971#issuecomment-595192579
@tillrohrmann @TisonKun
Thanks a lot for your suggestion. Since the #11233(Refactor the Kubernetes decorator design) has remove the action watcher. I will close this PR and moving the explicit I/O Executor to [FLINK-15790](https://issues.apache.org/jira/browse/FLINK-15790)(Make FlinkKubeClient and its implementations asynchronous).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10971:
[FLINK-15791][k8s] Use explicit I/O Executor for asynchronous operations in
Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10971: [FLINK-15791][k8s] Use explicit I/O Executor for asynchronous operations in Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10971#issuecomment-580116900
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f769194571216372e83fdff8d9898fd693079498",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/146711109",
"triggerID" : "f769194571216372e83fdff8d9898fd693079498",
"triggerType" : "PUSH"
}, {
"hash" : "f769194571216372e83fdff8d9898fd693079498",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668",
"triggerID" : "f769194571216372e83fdff8d9898fd693079498",
"triggerType" : "PUSH"
}, {
"hash" : "f769194571216372e83fdff8d9898fd693079498",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/146711109",
"triggerID" : "580606278",
"triggerType" : "MANUAL"
}, {
"hash" : "f769194571216372e83fdff8d9898fd693079498",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668",
"triggerID" : "580606278",
"triggerType" : "MANUAL"
}, {
"hash" : "2fcf6bfea870ac7578e8015f6502893abe866e75",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/147155576",
"triggerID" : "2fcf6bfea870ac7578e8015f6502893abe866e75",
"triggerType" : "PUSH"
}, {
"hash" : "2fcf6bfea870ac7578e8015f6502893abe866e75",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4763",
"triggerID" : "2fcf6bfea870ac7578e8015f6502893abe866e75",
"triggerType" : "PUSH"
}, {
"hash" : "539957eb3eebf7968f336b28a343f2e229c79bc6",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/147177503",
"triggerID" : "539957eb3eebf7968f336b28a343f2e229c79bc6",
"triggerType" : "PUSH"
}, {
"hash" : "539957eb3eebf7968f336b28a343f2e229c79bc6",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4770",
"triggerID" : "539957eb3eebf7968f336b28a343f2e229c79bc6",
"triggerType" : "PUSH"
}, {
"hash" : "ad97232ad6c202786094c50f3e5333735dab35d1",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4782",
"triggerID" : "ad97232ad6c202786094c50f3e5333735dab35d1",
"triggerType" : "PUSH"
}, {
"hash" : "ad97232ad6c202786094c50f3e5333735dab35d1",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/147207665",
"triggerID" : "ad97232ad6c202786094c50f3e5333735dab35d1",
"triggerType" : "PUSH"
}, {
"hash" : "51d76b2f9b16f9b136bc62168f5c20ac2700daee",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "51d76b2f9b16f9b136bc62168f5c20ac2700daee",
"triggerType" : "PUSH"
}, {
"hash" : "1f91c1d489cfe3bd139fc5f9be3d981c0ec7dd3a",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/147213520",
"triggerID" : "1f91c1d489cfe3bd139fc5f9be3d981c0ec7dd3a",
"triggerType" : "PUSH"
}, {
"hash" : "1f91c1d489cfe3bd139fc5f9be3d981c0ec7dd3a",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4786",
"triggerID" : "1f91c1d489cfe3bd139fc5f9be3d981c0ec7dd3a",
"triggerType" : "PUSH"
}, {
"hash" : "e2f646e5e5c1c83c7f895bd83b9fb7b64de83164",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149425175",
"triggerID" : "e2f646e5e5c1c83c7f895bd83b9fb7b64de83164",
"triggerType" : "PUSH"
}, {
"hash" : "e2f646e5e5c1c83c7f895bd83b9fb7b64de83164",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5270",
"triggerID" : "e2f646e5e5c1c83c7f895bd83b9fb7b64de83164",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 51d76b2f9b16f9b136bc62168f5c20ac2700daee UNKNOWN
* e2f646e5e5c1c83c7f895bd83b9fb7b64de83164 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149425175) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5270)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 commented on issue #10971:
[FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous
operations in Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on issue #10971: [FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous operations in Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10971#issuecomment-580606278
@flinkbot run travis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10971:
[FLINK-15791][k8s] Use explicit I/O Executor for asynchronous operations in
Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10971: [FLINK-15791][k8s] Use explicit I/O Executor for asynchronous operations in Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10971#issuecomment-580116900
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f769194571216372e83fdff8d9898fd693079498",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/146711109",
"triggerID" : "f769194571216372e83fdff8d9898fd693079498",
"triggerType" : "PUSH"
}, {
"hash" : "f769194571216372e83fdff8d9898fd693079498",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668",
"triggerID" : "f769194571216372e83fdff8d9898fd693079498",
"triggerType" : "PUSH"
}, {
"hash" : "f769194571216372e83fdff8d9898fd693079498",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/146711109",
"triggerID" : "580606278",
"triggerType" : "MANUAL"
}, {
"hash" : "f769194571216372e83fdff8d9898fd693079498",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668",
"triggerID" : "580606278",
"triggerType" : "MANUAL"
}, {
"hash" : "2fcf6bfea870ac7578e8015f6502893abe866e75",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/147155576",
"triggerID" : "2fcf6bfea870ac7578e8015f6502893abe866e75",
"triggerType" : "PUSH"
}, {
"hash" : "2fcf6bfea870ac7578e8015f6502893abe866e75",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4763",
"triggerID" : "2fcf6bfea870ac7578e8015f6502893abe866e75",
"triggerType" : "PUSH"
}, {
"hash" : "539957eb3eebf7968f336b28a343f2e229c79bc6",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/147177503",
"triggerID" : "539957eb3eebf7968f336b28a343f2e229c79bc6",
"triggerType" : "PUSH"
}, {
"hash" : "539957eb3eebf7968f336b28a343f2e229c79bc6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4770",
"triggerID" : "539957eb3eebf7968f336b28a343f2e229c79bc6",
"triggerType" : "PUSH"
}, {
"hash" : "ad97232ad6c202786094c50f3e5333735dab35d1",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4782",
"triggerID" : "ad97232ad6c202786094c50f3e5333735dab35d1",
"triggerType" : "PUSH"
}, {
"hash" : "ad97232ad6c202786094c50f3e5333735dab35d1",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/147207665",
"triggerID" : "ad97232ad6c202786094c50f3e5333735dab35d1",
"triggerType" : "PUSH"
}, {
"hash" : "51d76b2f9b16f9b136bc62168f5c20ac2700daee",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "51d76b2f9b16f9b136bc62168f5c20ac2700daee",
"triggerType" : "PUSH"
}, {
"hash" : "1f91c1d489cfe3bd139fc5f9be3d981c0ec7dd3a",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/147213520",
"triggerID" : "1f91c1d489cfe3bd139fc5f9be3d981c0ec7dd3a",
"triggerType" : "PUSH"
}, {
"hash" : "1f91c1d489cfe3bd139fc5f9be3d981c0ec7dd3a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4786",
"triggerID" : "1f91c1d489cfe3bd139fc5f9be3d981c0ec7dd3a",
"triggerType" : "PUSH"
}, {
"hash" : "e2f646e5e5c1c83c7f895bd83b9fb7b64de83164",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149425175",
"triggerID" : "e2f646e5e5c1c83c7f895bd83b9fb7b64de83164",
"triggerType" : "PUSH"
}, {
"hash" : "e2f646e5e5c1c83c7f895bd83b9fb7b64de83164",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5270",
"triggerID" : "e2f646e5e5c1c83c7f895bd83b9fb7b64de83164",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f769194571216372e83fdff8d9898fd693079498 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146711109) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668)
* 2fcf6bfea870ac7578e8015f6502893abe866e75 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147155576) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4763)
* 539957eb3eebf7968f336b28a343f2e229c79bc6 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147177503) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4770)
* ad97232ad6c202786094c50f3e5333735dab35d1 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147207665) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4782)
* 51d76b2f9b16f9b136bc62168f5c20ac2700daee UNKNOWN
* 1f91c1d489cfe3bd139fc5f9be3d981c0ec7dd3a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147213520) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4786)
* e2f646e5e5c1c83c7f895bd83b9fb7b64de83164 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149425175) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5270)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10971:
[FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous
operations in Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10971: [FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous operations in Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10971#issuecomment-580116900
<!--
Meta data
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146711109 TriggerType:PUSH TriggerID:f769194571216372e83fdff8d9898fd693079498
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668 TriggerType:PUSH TriggerID:f769194571216372e83fdff8d9898fd693079498
Hash:f769194571216372e83fdff8d9898fd693079498 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/146711109 TriggerType:MANUAL TriggerID:580606278
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668 TriggerType:MANUAL TriggerID:580606278
Hash:2fcf6bfea870ac7578e8015f6502893abe866e75 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:2fcf6bfea870ac7578e8015f6502893abe866e75
-->
## CI report:
* f769194571216372e83fdff8d9898fd693079498 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146711109) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668)
* 2fcf6bfea870ac7578e8015f6502893abe866e75 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10971:
[FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous
operations in Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10971: [FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous operations in Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10971#issuecomment-580116900
<!--
Meta data
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146711109 TriggerType:PUSH TriggerID:f769194571216372e83fdff8d9898fd693079498
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668 TriggerType:PUSH TriggerID:f769194571216372e83fdff8d9898fd693079498
Hash:f769194571216372e83fdff8d9898fd693079498 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/146711109 TriggerType:MANUAL TriggerID:580606278
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668 TriggerType:MANUAL TriggerID:580606278
Hash:2fcf6bfea870ac7578e8015f6502893abe866e75 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147155576 TriggerType:PUSH TriggerID:2fcf6bfea870ac7578e8015f6502893abe866e75
Hash:2fcf6bfea870ac7578e8015f6502893abe866e75 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4763 TriggerType:PUSH TriggerID:2fcf6bfea870ac7578e8015f6502893abe866e75
Hash:539957eb3eebf7968f336b28a343f2e229c79bc6 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:539957eb3eebf7968f336b28a343f2e229c79bc6
-->
## CI report:
* f769194571216372e83fdff8d9898fd693079498 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146711109) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668)
* 2fcf6bfea870ac7578e8015f6502893abe866e75 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147155576) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4763)
* 539957eb3eebf7968f336b28a343f2e229c79bc6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 closed pull request #10971: [FLINK-15791][k8s]
Use explicit I/O Executor for asynchronous operations in
Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
wangyang0918 closed pull request #10971: [FLINK-15791][k8s] Use explicit I/O Executor for asynchronous operations in Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10971
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10971:
[FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous
operations in Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10971: [FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous operations in Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10971#issuecomment-580116900
<!--
Meta data
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146711109 TriggerType:PUSH TriggerID:f769194571216372e83fdff8d9898fd693079498
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668 TriggerType:PUSH TriggerID:f769194571216372e83fdff8d9898fd693079498
Hash:f769194571216372e83fdff8d9898fd693079498 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/146711109 TriggerType:MANUAL TriggerID:580606278
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668 TriggerType:MANUAL TriggerID:580606278
Hash:2fcf6bfea870ac7578e8015f6502893abe866e75 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147155576 TriggerType:PUSH TriggerID:2fcf6bfea870ac7578e8015f6502893abe866e75
Hash:2fcf6bfea870ac7578e8015f6502893abe866e75 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4763 TriggerType:PUSH TriggerID:2fcf6bfea870ac7578e8015f6502893abe866e75
Hash:539957eb3eebf7968f336b28a343f2e229c79bc6 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147177503 TriggerType:PUSH TriggerID:539957eb3eebf7968f336b28a343f2e229c79bc6
Hash:539957eb3eebf7968f336b28a343f2e229c79bc6 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4770 TriggerType:PUSH TriggerID:539957eb3eebf7968f336b28a343f2e229c79bc6
-->
## CI report:
* f769194571216372e83fdff8d9898fd693079498 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146711109) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668)
* 2fcf6bfea870ac7578e8015f6502893abe866e75 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147155576) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4763)
* 539957eb3eebf7968f336b28a343f2e229c79bc6 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147177503) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4770)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10971:
[FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous
operations in Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10971: [FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous operations in Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10971#issuecomment-580116900
<!--
Meta data
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146711109 TriggerType:PUSH TriggerID:f769194571216372e83fdff8d9898fd693079498
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668 TriggerType:PUSH TriggerID:f769194571216372e83fdff8d9898fd693079498
Hash:f769194571216372e83fdff8d9898fd693079498 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/146711109 TriggerType:MANUAL TriggerID:580606278
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668 TriggerType:MANUAL TriggerID:580606278
Hash:2fcf6bfea870ac7578e8015f6502893abe866e75 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147155576 TriggerType:PUSH TriggerID:2fcf6bfea870ac7578e8015f6502893abe866e75
Hash:2fcf6bfea870ac7578e8015f6502893abe866e75 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4763 TriggerType:PUSH TriggerID:2fcf6bfea870ac7578e8015f6502893abe866e75
-->
## CI report:
* f769194571216372e83fdff8d9898fd693079498 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146711109) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668)
* 2fcf6bfea870ac7578e8015f6502893abe866e75 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147155576) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4763)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10971:
[FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous
operations in Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10971: [FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous operations in Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10971#issuecomment-580116900
<!--
Meta data
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146711109 TriggerType:PUSH TriggerID:f769194571216372e83fdff8d9898fd693079498
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668 TriggerType:PUSH TriggerID:f769194571216372e83fdff8d9898fd693079498
Hash:f769194571216372e83fdff8d9898fd693079498 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/146711109 TriggerType:MANUAL TriggerID:580606278
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668 TriggerType:MANUAL TriggerID:580606278
Hash:2fcf6bfea870ac7578e8015f6502893abe866e75 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147155576 TriggerType:PUSH TriggerID:2fcf6bfea870ac7578e8015f6502893abe866e75
Hash:2fcf6bfea870ac7578e8015f6502893abe866e75 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4763 TriggerType:PUSH TriggerID:2fcf6bfea870ac7578e8015f6502893abe866e75
Hash:539957eb3eebf7968f336b28a343f2e229c79bc6 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147177503 TriggerType:PUSH TriggerID:539957eb3eebf7968f336b28a343f2e229c79bc6
Hash:539957eb3eebf7968f336b28a343f2e229c79bc6 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4770 TriggerType:PUSH TriggerID:539957eb3eebf7968f336b28a343f2e229c79bc6
-->
## CI report:
* f769194571216372e83fdff8d9898fd693079498 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146711109) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668)
* 2fcf6bfea870ac7578e8015f6502893abe866e75 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147155576) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4763)
* 539957eb3eebf7968f336b28a343f2e229c79bc6 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147177503) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4770)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10971:
[FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous
operations in Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10971: [FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous operations in Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10971#issuecomment-580116900
<!--
Meta data
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146711109 TriggerType:PUSH TriggerID:f769194571216372e83fdff8d9898fd693079498
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668 TriggerType:PUSH TriggerID:f769194571216372e83fdff8d9898fd693079498
-->
## CI report:
* f769194571216372e83fdff8d9898fd693079498 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146711109) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10971:
[FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous
operations in Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10971: [FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous operations in Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10971#issuecomment-580116900
<!--
Meta data
Hash:f769194571216372e83fdff8d9898fd693079498 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/146711109 TriggerType:PUSH TriggerID:f769194571216372e83fdff8d9898fd693079498
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668 TriggerType:PUSH TriggerID:f769194571216372e83fdff8d9898fd693079498
-->
## CI report:
* f769194571216372e83fdff8d9898fd693079498 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/146711109) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] TisonKun commented on a change in pull request #10971:
[FLINK-15791][k8s] Use explicit I/O Executor for asynchronous operations in
Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
TisonKun commented on a change in pull request #10971: [FLINK-15791][k8s] Use explicit I/O Executor for asynchronous operations in Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10971#discussion_r387827116
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/Fabric8FlinkKubeClient.java
##########
@@ -355,4 +372,33 @@ private int getServiceNodePort(Service service, ConfigOption<Integer> configPort
}
return port;
}
+
+ /**
+ * The help class to get the executor to run asynchronous operations on. It could create a dedicated thread pool or
+ * reuse an existing one.
+ */
+ private static class ExecutorWrapper {
+
+ private final ExecutorService internalExecutorService;
+ private Executor executor = null;
+
+ ExecutorWrapper(Configuration flinkConfig) {
+ internalExecutorService = Executors.newFixedThreadPool(
+ flinkConfig.getInteger(KubernetesConfigOptions.CLIENT_ASYNC_THREAD_POOL_SIZE),
+ new ExecutorThreadFactory("FlinkKubeClient-IO"));
+ }
+
+ ExecutorWrapper(Configuration flinkConfig, Executor executor) {
+ this(flinkConfig);
+ this.executor = executor;
+ }
+
+ Executor getExecutor() {
+ return executor == null ? this.internalExecutorService : executor;
+ }
+
+ public void close() {
+ ExecutorUtils.gracefulShutdown(5, TimeUnit.SECONDS, this.internalExecutorService);
+ }
+ }
Review comment:
An alternative is that we always have two final field
```
private final Executor executor;
private final Runnable onClose;
```
and compose the close manner where
```
() -> {} // for passed Executor
() -> ExecutorUtils.gracefulShutdown(5, TimeUnit.SECONDS, services); // for internal service
```
since we initialize `onClose` in constructor we know whether `executor` is a passed `Executor` or an internal initialized service.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10971:
[FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous
operations in Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10971: [FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous operations in Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10971#issuecomment-580116900
<!--
Meta data
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146711109 TriggerType:PUSH TriggerID:f769194571216372e83fdff8d9898fd693079498
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668 TriggerType:PUSH TriggerID:f769194571216372e83fdff8d9898fd693079498
Hash:f769194571216372e83fdff8d9898fd693079498 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/146711109 TriggerType:MANUAL TriggerID:580606278
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668 TriggerType:MANUAL TriggerID:580606278
Hash:2fcf6bfea870ac7578e8015f6502893abe866e75 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147155576 TriggerType:PUSH TriggerID:2fcf6bfea870ac7578e8015f6502893abe866e75
Hash:2fcf6bfea870ac7578e8015f6502893abe866e75 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4763 TriggerType:PUSH TriggerID:2fcf6bfea870ac7578e8015f6502893abe866e75
Hash:539957eb3eebf7968f336b28a343f2e229c79bc6 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147177503 TriggerType:PUSH TriggerID:539957eb3eebf7968f336b28a343f2e229c79bc6
Hash:539957eb3eebf7968f336b28a343f2e229c79bc6 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4770 TriggerType:PUSH TriggerID:539957eb3eebf7968f336b28a343f2e229c79bc6
Hash:ad97232ad6c202786094c50f3e5333735dab35d1 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4782 TriggerType:PUSH TriggerID:ad97232ad6c202786094c50f3e5333735dab35d1
Hash:ad97232ad6c202786094c50f3e5333735dab35d1 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147207665 TriggerType:PUSH TriggerID:ad97232ad6c202786094c50f3e5333735dab35d1
Hash:51d76b2f9b16f9b136bc62168f5c20ac2700daee Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:51d76b2f9b16f9b136bc62168f5c20ac2700daee
Hash:1f91c1d489cfe3bd139fc5f9be3d981c0ec7dd3a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147213520 TriggerType:PUSH TriggerID:1f91c1d489cfe3bd139fc5f9be3d981c0ec7dd3a
Hash:1f91c1d489cfe3bd139fc5f9be3d981c0ec7dd3a Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4786 TriggerType:PUSH TriggerID:1f91c1d489cfe3bd139fc5f9be3d981c0ec7dd3a
-->
## CI report:
* f769194571216372e83fdff8d9898fd693079498 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146711109) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668)
* 2fcf6bfea870ac7578e8015f6502893abe866e75 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147155576) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4763)
* 539957eb3eebf7968f336b28a343f2e229c79bc6 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147177503) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4770)
* ad97232ad6c202786094c50f3e5333735dab35d1 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147207665) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4782)
* 51d76b2f9b16f9b136bc62168f5c20ac2700daee UNKNOWN
* 1f91c1d489cfe3bd139fc5f9be3d981c0ec7dd3a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147213520) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4786)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10971:
[FLINK-15791][k8s] Use explicit I/O Executor for asynchronous operations in
Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10971: [FLINK-15791][k8s] Use explicit I/O Executor for asynchronous operations in Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10971#issuecomment-580116900
<!--
Meta data
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146711109 TriggerType:PUSH TriggerID:f769194571216372e83fdff8d9898fd693079498
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668 TriggerType:PUSH TriggerID:f769194571216372e83fdff8d9898fd693079498
Hash:f769194571216372e83fdff8d9898fd693079498 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/146711109 TriggerType:MANUAL TriggerID:580606278
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668 TriggerType:MANUAL TriggerID:580606278
Hash:2fcf6bfea870ac7578e8015f6502893abe866e75 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147155576 TriggerType:PUSH TriggerID:2fcf6bfea870ac7578e8015f6502893abe866e75
Hash:2fcf6bfea870ac7578e8015f6502893abe866e75 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4763 TriggerType:PUSH TriggerID:2fcf6bfea870ac7578e8015f6502893abe866e75
Hash:539957eb3eebf7968f336b28a343f2e229c79bc6 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147177503 TriggerType:PUSH TriggerID:539957eb3eebf7968f336b28a343f2e229c79bc6
Hash:539957eb3eebf7968f336b28a343f2e229c79bc6 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4770 TriggerType:PUSH TriggerID:539957eb3eebf7968f336b28a343f2e229c79bc6
Hash:ad97232ad6c202786094c50f3e5333735dab35d1 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4782 TriggerType:PUSH TriggerID:ad97232ad6c202786094c50f3e5333735dab35d1
Hash:ad97232ad6c202786094c50f3e5333735dab35d1 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147207665 TriggerType:PUSH TriggerID:ad97232ad6c202786094c50f3e5333735dab35d1
Hash:51d76b2f9b16f9b136bc62168f5c20ac2700daee Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:51d76b2f9b16f9b136bc62168f5c20ac2700daee
Hash:1f91c1d489cfe3bd139fc5f9be3d981c0ec7dd3a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147213520 TriggerType:PUSH TriggerID:1f91c1d489cfe3bd139fc5f9be3d981c0ec7dd3a
Hash:1f91c1d489cfe3bd139fc5f9be3d981c0ec7dd3a Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4786 TriggerType:PUSH TriggerID:1f91c1d489cfe3bd139fc5f9be3d981c0ec7dd3a
Hash:e2f646e5e5c1c83c7f895bd83b9fb7b64de83164 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149425175 TriggerType:PUSH TriggerID:e2f646e5e5c1c83c7f895bd83b9fb7b64de83164
Hash:e2f646e5e5c1c83c7f895bd83b9fb7b64de83164 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5270 TriggerType:PUSH TriggerID:e2f646e5e5c1c83c7f895bd83b9fb7b64de83164
-->
## CI report:
* f769194571216372e83fdff8d9898fd693079498 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146711109) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668)
* 2fcf6bfea870ac7578e8015f6502893abe866e75 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147155576) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4763)
* 539957eb3eebf7968f336b28a343f2e229c79bc6 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147177503) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4770)
* ad97232ad6c202786094c50f3e5333735dab35d1 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147207665) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4782)
* 51d76b2f9b16f9b136bc62168f5c20ac2700daee UNKNOWN
* 1f91c1d489cfe3bd139fc5f9be3d981c0ec7dd3a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147213520) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4786)
* e2f646e5e5c1c83c7f895bd83b9fb7b64de83164 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149425175) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5270)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10971:
[FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous
operations in Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10971: [FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous operations in Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10971#issuecomment-580116900
<!--
Meta data
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146711109 TriggerType:PUSH TriggerID:f769194571216372e83fdff8d9898fd693079498
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668 TriggerType:PUSH TriggerID:f769194571216372e83fdff8d9898fd693079498
Hash:f769194571216372e83fdff8d9898fd693079498 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/146711109 TriggerType:MANUAL TriggerID:580606278
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668 TriggerType:MANUAL TriggerID:580606278
Hash:2fcf6bfea870ac7578e8015f6502893abe866e75 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147155576 TriggerType:PUSH TriggerID:2fcf6bfea870ac7578e8015f6502893abe866e75
Hash:2fcf6bfea870ac7578e8015f6502893abe866e75 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4763 TriggerType:PUSH TriggerID:2fcf6bfea870ac7578e8015f6502893abe866e75
Hash:539957eb3eebf7968f336b28a343f2e229c79bc6 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147177503 TriggerType:PUSH TriggerID:539957eb3eebf7968f336b28a343f2e229c79bc6
Hash:539957eb3eebf7968f336b28a343f2e229c79bc6 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4770 TriggerType:PUSH TriggerID:539957eb3eebf7968f336b28a343f2e229c79bc6
Hash:ad97232ad6c202786094c50f3e5333735dab35d1 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:ad97232ad6c202786094c50f3e5333735dab35d1
-->
## CI report:
* f769194571216372e83fdff8d9898fd693079498 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146711109) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668)
* 2fcf6bfea870ac7578e8015f6502893abe866e75 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147155576) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4763)
* 539957eb3eebf7968f336b28a343f2e229c79bc6 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147177503) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4770)
* ad97232ad6c202786094c50f3e5333735dab35d1 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] TisonKun commented on a change in pull request #10971:
[FLINK-15791][k8s] Use explicit I/O Executor for asynchronous operations in
Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
TisonKun commented on a change in pull request #10971: [FLINK-15791][k8s] Use explicit I/O Executor for asynchronous operations in Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10971#discussion_r387827116
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/Fabric8FlinkKubeClient.java
##########
@@ -355,4 +372,33 @@ private int getServiceNodePort(Service service, ConfigOption<Integer> configPort
}
return port;
}
+
+ /**
+ * The help class to get the executor to run asynchronous operations on. It could create a dedicated thread pool or
+ * reuse an existing one.
+ */
+ private static class ExecutorWrapper {
+
+ private final ExecutorService internalExecutorService;
+ private Executor executor = null;
+
+ ExecutorWrapper(Configuration flinkConfig) {
+ internalExecutorService = Executors.newFixedThreadPool(
+ flinkConfig.getInteger(KubernetesConfigOptions.CLIENT_ASYNC_THREAD_POOL_SIZE),
+ new ExecutorThreadFactory("FlinkKubeClient-IO"));
+ }
+
+ ExecutorWrapper(Configuration flinkConfig, Executor executor) {
+ this(flinkConfig);
+ this.executor = executor;
+ }
+
+ Executor getExecutor() {
+ return executor == null ? this.internalExecutorService : executor;
+ }
+
+ public void close() {
+ ExecutorUtils.gracefulShutdown(5, TimeUnit.SECONDS, this.internalExecutorService);
+ }
+ }
Review comment:
An alternative is that we always have two final field
```
private final Executor execute;
private final Runnable onClose;
```
and compose the close manner where
```
() -> {} // for passed Executor
() -> ExecutorUtils.gracefulShutdown(5, TimeUnit.SECONDS, this.internalExecutorService); // for internal service
```
since we initialize `onClose` in constructor we know whether `executor` is a passed `Executor` or an internal initialized service.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10971:
[FLINK-15791][k8s] Use explicit I/O Executor for asynchronous operations in
Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10971: [FLINK-15791][k8s] Use explicit I/O Executor for asynchronous operations in Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10971#issuecomment-580116900
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f769194571216372e83fdff8d9898fd693079498",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/146711109",
"triggerID" : "f769194571216372e83fdff8d9898fd693079498",
"triggerType" : "PUSH"
}, {
"hash" : "f769194571216372e83fdff8d9898fd693079498",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668",
"triggerID" : "f769194571216372e83fdff8d9898fd693079498",
"triggerType" : "PUSH"
}, {
"hash" : "f769194571216372e83fdff8d9898fd693079498",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/146711109",
"triggerID" : "580606278",
"triggerType" : "MANUAL"
}, {
"hash" : "f769194571216372e83fdff8d9898fd693079498",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668",
"triggerID" : "580606278",
"triggerType" : "MANUAL"
}, {
"hash" : "2fcf6bfea870ac7578e8015f6502893abe866e75",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/147155576",
"triggerID" : "2fcf6bfea870ac7578e8015f6502893abe866e75",
"triggerType" : "PUSH"
}, {
"hash" : "2fcf6bfea870ac7578e8015f6502893abe866e75",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4763",
"triggerID" : "2fcf6bfea870ac7578e8015f6502893abe866e75",
"triggerType" : "PUSH"
}, {
"hash" : "539957eb3eebf7968f336b28a343f2e229c79bc6",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/147177503",
"triggerID" : "539957eb3eebf7968f336b28a343f2e229c79bc6",
"triggerType" : "PUSH"
}, {
"hash" : "539957eb3eebf7968f336b28a343f2e229c79bc6",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4770",
"triggerID" : "539957eb3eebf7968f336b28a343f2e229c79bc6",
"triggerType" : "PUSH"
}, {
"hash" : "ad97232ad6c202786094c50f3e5333735dab35d1",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4782",
"triggerID" : "ad97232ad6c202786094c50f3e5333735dab35d1",
"triggerType" : "PUSH"
}, {
"hash" : "ad97232ad6c202786094c50f3e5333735dab35d1",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/147207665",
"triggerID" : "ad97232ad6c202786094c50f3e5333735dab35d1",
"triggerType" : "PUSH"
}, {
"hash" : "1f91c1d489cfe3bd139fc5f9be3d981c0ec7dd3a",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/147213520",
"triggerID" : "1f91c1d489cfe3bd139fc5f9be3d981c0ec7dd3a",
"triggerType" : "PUSH"
}, {
"hash" : "1f91c1d489cfe3bd139fc5f9be3d981c0ec7dd3a",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4786",
"triggerID" : "1f91c1d489cfe3bd139fc5f9be3d981c0ec7dd3a",
"triggerType" : "PUSH"
}, {
"hash" : "e2f646e5e5c1c83c7f895bd83b9fb7b64de83164",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149425175",
"triggerID" : "e2f646e5e5c1c83c7f895bd83b9fb7b64de83164",
"triggerType" : "PUSH"
}, {
"hash" : "e2f646e5e5c1c83c7f895bd83b9fb7b64de83164",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5270",
"triggerID" : "e2f646e5e5c1c83c7f895bd83b9fb7b64de83164",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e2f646e5e5c1c83c7f895bd83b9fb7b64de83164 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149425175) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5270)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10971:
[FLINK-15791][k8s] Use explicit I/O Executor for asynchronous operations in
Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10971: [FLINK-15791][k8s] Use explicit I/O Executor for asynchronous operations in Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10971#issuecomment-580116900
<!--
Meta data
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146711109 TriggerType:PUSH TriggerID:f769194571216372e83fdff8d9898fd693079498
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668 TriggerType:PUSH TriggerID:f769194571216372e83fdff8d9898fd693079498
Hash:f769194571216372e83fdff8d9898fd693079498 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/146711109 TriggerType:MANUAL TriggerID:580606278
Hash:f769194571216372e83fdff8d9898fd693079498 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668 TriggerType:MANUAL TriggerID:580606278
Hash:2fcf6bfea870ac7578e8015f6502893abe866e75 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147155576 TriggerType:PUSH TriggerID:2fcf6bfea870ac7578e8015f6502893abe866e75
Hash:2fcf6bfea870ac7578e8015f6502893abe866e75 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4763 TriggerType:PUSH TriggerID:2fcf6bfea870ac7578e8015f6502893abe866e75
Hash:539957eb3eebf7968f336b28a343f2e229c79bc6 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147177503 TriggerType:PUSH TriggerID:539957eb3eebf7968f336b28a343f2e229c79bc6
Hash:539957eb3eebf7968f336b28a343f2e229c79bc6 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4770 TriggerType:PUSH TriggerID:539957eb3eebf7968f336b28a343f2e229c79bc6
Hash:ad97232ad6c202786094c50f3e5333735dab35d1 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4782 TriggerType:PUSH TriggerID:ad97232ad6c202786094c50f3e5333735dab35d1
Hash:ad97232ad6c202786094c50f3e5333735dab35d1 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147207665 TriggerType:PUSH TriggerID:ad97232ad6c202786094c50f3e5333735dab35d1
Hash:51d76b2f9b16f9b136bc62168f5c20ac2700daee Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:51d76b2f9b16f9b136bc62168f5c20ac2700daee
Hash:1f91c1d489cfe3bd139fc5f9be3d981c0ec7dd3a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147213520 TriggerType:PUSH TriggerID:1f91c1d489cfe3bd139fc5f9be3d981c0ec7dd3a
Hash:1f91c1d489cfe3bd139fc5f9be3d981c0ec7dd3a Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4786 TriggerType:PUSH TriggerID:1f91c1d489cfe3bd139fc5f9be3d981c0ec7dd3a
Hash:e2f646e5e5c1c83c7f895bd83b9fb7b64de83164 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:e2f646e5e5c1c83c7f895bd83b9fb7b64de83164
-->
## CI report:
* f769194571216372e83fdff8d9898fd693079498 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146711109) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668)
* 2fcf6bfea870ac7578e8015f6502893abe866e75 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147155576) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4763)
* 539957eb3eebf7968f336b28a343f2e229c79bc6 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147177503) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4770)
* ad97232ad6c202786094c50f3e5333735dab35d1 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147207665) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4782)
* 51d76b2f9b16f9b136bc62168f5c20ac2700daee UNKNOWN
* 1f91c1d489cfe3bd139fc5f9be3d981c0ec7dd3a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147213520) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4786)
* e2f646e5e5c1c83c7f895bd83b9fb7b64de83164 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services