You are viewing a plain text version of this content. The canonical link for it is here.
Posted to general@incubator.apache.org by Otto van der Schaaf <os...@gmail.com> on 2020/02/02 09:53:23 UTC
Re: [VOTE] Release Apache PageSpeed 1.14.36.1-rc3
I staged another release candidate over at
http://people.apache.org/~oschaaf/mod_pagespeed/1.14.36.1-rc4/ which
doesn't
contain any compiled code plus moves to DISCLAIMER-WIP to track the
remaining issues. I'll try to move this to the right
staging location (https://dist.apache.org/repos/dist/dev/incubator/pagespeed)
but need to polish my subversion skills, it has been
quite a while since last using that :-)
The MPL licensed source code is still there, it gets pulled in via
Chromium. This involves nspr via our chromium dependency
https://github.com/chromium/chromium/blob/2ca8c5037021c9d2ecc00b787d58a31ed8fc8bcb/base/third_party/nspr/
<https://github.com/chromium/chromium/blob/2ca8c5037021c9d2ecc00b787d58a31ed8fc8bcb/base/third_party/nspr/prtime.h>
I think we rely on prtime.cc/.h, possibly we can replace that. Is this a
blocking issue now that we have the WIP disclaimer in place?
Otto
Op wo 27 nov. 2019 om 01:36 schreef Justin Mclean <justin@classsoftware.com
>:
> Hi,
>
> Is this a call for an IPMC vote on this podlings release? If so the
> release candidate isn't in the correct place [1] (but that's easily fixed
> without revoting).
>
> However, there seems to be some larger issues, so sorry but I’m -1
> (binding) as there category B code and compiled code in the source release.
>
> I checked:
> - incubating in name
> - hashes and signatures are fine
> - DISCLAIMER exists
> - LICENSE and NOTICE exist
> - The code base appears to contain MPL licensed source code, this is not
> allowed as it’s category B. This is OK if these are dependancies and not
> included.
> - The release contains compiled code.
> [3][4][5][7][8][9][10][11][12][13][14]
> - The release contains cryptography [6]. Has an export license been
> obtained for this? [17]
> - How is this file [15] licensed? from here? [16] I notice a number of
> other images are used in tests, how are these files licensed?
> - There are a large number of files without ASF headers, while not all of
> the files need ASF headers a large number will.
> - I didn’t try to compile
>
> It may be that the LICENSE file need some more work I’ve not done an
> exhaustive check but this to can be refined over time with the WIP
> DISCLAIMER in place. It is missing a few thing I think for example:
> - This MIT licensed file [19]
> - This MIT licensed file [20] which also includes sizzle.js
>
> You might also want to consider replacing the license text of each 3rd
> party bit in a seperate file in a single folder (called say licenses) and
> point to that from the LICENSE as it can be easier to read.
>
> What I suggest you do is move to using the WIP disclaimer [18], add the
> known issues above, make a new release (without any compiled code if
> possible), and then work on a way to resolve each of the issues in future
> releases.
>
> Thanks,
> Justin
>
> 1. https://dist.apache.org/repos/dist/dev/incubator/pagespeed
> 2. https://www.apache.org/legal/resolved.html#category-b
> 3. ./pagespeed/automatic/rewriter_speed_test.o
> 4. ./pagespeed/automatic/static_rewriter_main.o
> 5. ./pagespeed/automatic/static_rewriter.o
> 6 ./third_party/grpc/src/third_party/boringssl
> 7. ./third_party/libwebp/swig/libwebp.jar
> 8. ./third_party/libwebp/gradle/wrapper/gradle-wrapper.jar
> 9 ./pagespeed/automatic/static_rewriter
> 10 ./pagespeed/automatic/rewriter_speed_test
> 11 ./pagespeed/automatic/pagespeed_automatic.a
> 12 ./third_party/brotli/src/tests/testdata/bb.binast
> 13 ./third_party/libwebp/webp_js/test_webp_wasm.webp
> 14 ./third_party/libwebp/webp_js/test_webp_js.webp
> 15. ./install/mod_pagespeed_example/images/Beach.jpg
> 16. https://www.pexels.com/photo/dirt-road-dry-fence-footprints-210289/
> 17. http://www.apache.org/licenses/exports/
> 18. https://incubator.apache.org/policy/incubation.html#disclaimers
> 19 ./pagespeed/kernel/js/testdata/third_party/prototype.original
> 20 ./pagespeed/kernel/js/testdata/third_party/jquery.original
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>
Re: [VOTE] Release Apache PageSpeed 1.14.36.1-rc3
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> Can I raise a new VOTE thread for that?
After you have VOTEed on your dev list yes.
Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache PageSpeed 1.14.36.1-rc3
Posted by Otto van der Schaaf <os...@gmail.com>.
So with some help, rc4 is now staged in the right location!
https://dist.apache.org/repos/dist/dev/incubator/pagespeed/1.14.36.1-rc4/
Can I raise a new VOTE thread for that?
Otto
Op zo 2 feb. 2020 om 11:40 schreef Otto van der Schaaf <os...@gmail.com>:
> Well, we include
> https://github.com/chromium/chromium/blob/2ca8c5037021c9d2ecc00b787d58a31ed8fc8bcb/base/third_party/nspr/LICENSE
> [1]
> Now I'm wondering: should that propagate to our top-level LICENSE?
>
> [1] ~/rc-4/third_party/chromium/src/base/third_party/nspr$ ls -lah
> ....
> -rw-r--r-- 1 oschaaf oschaaf 1.7K Jan 31 19:52 LICENSE
> .....
>
> Op zo 2 feb. 2020 om 11:17 schreef Justin Mclean <justin@classsoftware.com
> >:
>
>> Hi,
>>
>> > which doesn’t contain any compiled code plus moves to DISCLAIMER-WIP to
>> track the
>> > remaining issues.
>>
>> Great!
>>
>> > The MPL licensed source code is still there
>>
>> Have you included it’s license?
>>
>> > Is this a blocking issue now that we have the WIP disclaimer in place?
>>
>> In general not, but you still need to abide by the MPL license terms.
>>
>> Thanks,
>> Justin
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: general-help@incubator.apache.org
>>
>>
Re: [VOTE] Release Apache PageSpeed 1.14.36.1-rc3
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> Well, we include
> https://github.com/chromium/chromium/blob/2ca8c5037021c9d2ecc00b787d58a31ed8fc8bcb/base/third_party/nspr/LICENSE
> [1]
> Now I'm wondering: should that propagate to our top-level LICENSE?
Ideally yes, but you are an incubating project and do include the license so IMO that’s OK.
Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache PageSpeed 1.14.36.1-rc3
Posted by Otto van der Schaaf <os...@gmail.com>.
Well, we include
https://github.com/chromium/chromium/blob/2ca8c5037021c9d2ecc00b787d58a31ed8fc8bcb/base/third_party/nspr/LICENSE
[1]
Now I'm wondering: should that propagate to our top-level LICENSE?
[1] ~/rc-4/third_party/chromium/src/base/third_party/nspr$ ls -lah
....
-rw-r--r-- 1 oschaaf oschaaf 1.7K Jan 31 19:52 LICENSE
.....
Op zo 2 feb. 2020 om 11:17 schreef Justin Mclean <ju...@classsoftware.com>:
> Hi,
>
> > which doesn’t contain any compiled code plus moves to DISCLAIMER-WIP to
> track the
> > remaining issues.
>
> Great!
>
> > The MPL licensed source code is still there
>
> Have you included it’s license?
>
> > Is this a blocking issue now that we have the WIP disclaimer in place?
>
> In general not, but you still need to abide by the MPL license terms.
>
> Thanks,
> Justin
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>
Re: [VOTE] Release Apache PageSpeed 1.14.36.1-rc3
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> which doesn’t contain any compiled code plus moves to DISCLAIMER-WIP to track the
> remaining issues.
Great!
> The MPL licensed source code is still there
Have you included it’s license?
> Is this a blocking issue now that we have the WIP disclaimer in place?
In general not, but you still need to abide by the MPL license terms.
Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org