[GitHub] [helix] jiajunwang commented on a change in pull request #1066: Prevent parallel controller pipelines run causing two master replicas

[GitBox <gi...@apache.org>]

jiajunwang commented on a change in pull request #1066:
URL: https://github.com/apache/helix/pull/1066#discussion_r483297080



##########
File path: helix-core/src/test/java/org/apache/helix/common/ZkTestBase.java
##########
@@ -788,14 +788,18 @@ protected void setupInstances(String clusterName, int[] instances) {
     }
   }
 
-  protected void runPipeline(ClusterEvent event, Pipeline pipeline) {
+  protected void runPipeline(ClusterEvent event, Pipeline pipeline, boolean shouldThrowException)

Review comment:
       How about giving us a break by keeping the existing method with shouldThrowException default to be false?
   So you have much less changed files.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org