[jira] [Reopened] (ZOOKEEPER-1440) Spurious log error messages when QuorumCnxManager is shutting down

["Patrick Hunt (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt reopened ZOOKEEPER-1440:
-------------------------------------


I think we need to revert this commit. The patch as committed introduces a socket leak - there is a race condition where 1) the run method could be processing a socket operation that throws an ioexception, and 2) the shutdown flag being set. As a result we might not close the socket.

                
> Spurious log error messages when QuorumCnxManager is shutting down
> ------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1440
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1440
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: quorum, server
>    Affects Versions: 3.4.3
>            Reporter: Jordan Zimmerman
>            Assignee: Jordan Zimmerman
>            Priority: Minor
>             Fix For: 3.5.0
>
>         Attachments: patch.txt
>
>
> When shutting down the QuroumPeer, ZK server logs unnecessary errors. See QuorumCnxManager.Listener.run() - ss.accept() will throw an exception when it is closed. The catch (IOException e) will log errors. It should first check the shutdown field to see if the Listener is being shutdown. If it is, the exception is correct and no errors should be logged.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira