You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "paleolimbot (via GitHub)" <gi...@apache.org> on 2025/03/12 05:23:25 UTC
[PR] feat: Add `ArrowDecimalAppendStringToBuffer()` [arrow-nanoarrow]
paleolimbot opened a new pull request, #720:
URL: https://github.com/apache/arrow-nanoarrow/pull/720
We've had `ArrowDecimalAppendDigitsToBuffer()` (because it was required for integration testing), but this only gets the underlying integer representation (e.g., 1234), not the "logical" decimal representation (e.g., 1.234). This logical representation gets returned in database results (e.g., it's what ADBC does for postgres) and can be used to support convert to double where an implementation can parse a string (e.g., in R).
This was extracted out of https://github.com/apache/arrow-nanoarrow/pull/717 , which is a fix for an ADBC issue ( https://github.com/apache/arrow-adbc/issues/2508 ).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add `ArrowDecimalAppendStringToBuffer()` [arrow-nanoarrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on PR #720:
URL: https://github.com/apache/arrow-nanoarrow/pull/720#issuecomment-2718503854
@zeroshade Any chance you have the bandwidth to take a look here? I'm trying to solve that Snowflake issue in ADBC properly and there's some stuff that should be in the C library and not in R (with the side effect of all of this being that I can add Decimal32/64 support in the R package with this 🙂 )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add `ArrowDecimalAppendStringToBuffer()` [arrow-nanoarrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot merged PR #720:
URL: https://github.com/apache/arrow-nanoarrow/pull/720
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add `ArrowDecimalAppendStringToBuffer()` [arrow-nanoarrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on PR #720:
URL: https://github.com/apache/arrow-nanoarrow/pull/720#issuecomment-2719497720
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org