[GitHub] [iceberg] samredai commented on a diff in pull request #5457: Move base.py for catalog to __init__

[GitBox <gi...@apache.org>]

samredai commented on code in PR #5457:
URL: https://github.com/apache/iceberg/pull/5457#discussion_r939711271


##########
python/pyiceberg/typedef.py:
##########
@@ -0,0 +1,20 @@
+# Licensed to the Apache Software Foundation (ASF) under one

Review Comment:
   These were moved to this new file to avoid this circular import error:
   ```py
   ImportError while loading conftest '/Users/sam/iceberg/python/tests/conftest.py'.
   tests/conftest.py:55: in <module>
       from tests.catalog.test_base import InMemoryCatalog
   tests/catalog/test_base.py:28: in <module>
       from pyiceberg.catalog import (
   pyiceberg/catalog/__init__.py:25: in <module>
       from pyiceberg.table.base import Table
   pyiceberg/table/base.py:23: in <module>
       from pyiceberg.catalog import Identifier
   E   ImportError: cannot import name 'Identifier' from partially initialized module 'pyiceberg.catalog' (most likely due to a circular import) (/Users/sam/iceberg/python/pyiceberg/catalog/__init__.py)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org