You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "thisisnic (via GitHub)" <gi...@apache.org> on 2023/05/17 09:48:06 UTC
[GitHub] [arrow] thisisnic opened a new pull request, #35634: GH-35633: [C++] R builds failing with error 'Invalid: Timestamps already have a timezone: 'UTC'. Cannot localize to 'UTC''
thisisnic opened a new pull request, #35634:
URL: https://github.com/apache/arrow/pull/35634
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on a diff in pull request #35634: GH-35633: [C++] R builds failing with error 'Invalid: Timestamps already have a timezone: 'UTC'. Cannot localize to 'UTC''
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on code in PR #35634:
URL: https://github.com/apache/arrow/pull/35634#discussion_r1196716639
##########
cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc:
##########
@@ -120,7 +120,7 @@ struct AssumeTimezoneExtractor
static Status Exec(KernelContext* ctx, const ExecSpan& batch, ExecResult* out) {
const AssumeTimezoneOptions& options = AssumeTimezoneState::Get(ctx);
const auto& timezone = GetInputTimezone(*batch[0].type());
- if (!timezone.empty()) {
+ if (!timezone.empty() && timezone != options.timezone) {
Review Comment:
Fair
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35634: GH-35633: [C++] R builds failing with error 'Invalid: Timestamps already have a timezone: 'UTC'. Cannot localize to 'UTC''
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35634:
URL: https://github.com/apache/arrow/pull/35634#issuecomment-1551087267
:warning: GitHub issue #35633 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on pull request #35634: GH-35633: [C++] R builds failing with error 'Invalid: Timestamps already have a timezone: 'UTC'. Cannot localize to 'UTC''
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on PR #35634:
URL: https://github.com/apache/arrow/pull/35634#issuecomment-1551088380
@github-actions crossbow submit test-r-versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on pull request #35634: GH-35633: [R] R builds failing with error 'Invalid: Timestamps already have a timezone: 'UTC'. Cannot localize to 'UTC''
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on PR #35634:
URL: https://github.com/apache/arrow/pull/35634#issuecomment-1552991316
> I'm fine with skipping `%z` in the tests; however, you could also test the strptime format for `%z`. This seems to pass tests for me locally ( [main...paleolimbot:arrow:r-assume-tz-fix2](https://github.com/apache/arrow/compare/main...paleolimbot:arrow:r-assume-tz-fix2) ).
If you've already done that on another branch, can you make a PR with that and I'll just close this one then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic closed pull request #35634: GH-35633: [R] R builds failing with error 'Invalid: Timestamps already have a timezone: 'UTC'. Cannot localize to 'UTC''
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic closed pull request #35634: GH-35633: [R] R builds failing with error 'Invalid: Timestamps already have a timezone: 'UTC'. Cannot localize to 'UTC''
URL: https://github.com/apache/arrow/pull/35634
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] paleolimbot commented on pull request #35634: GH-35633: [R] R builds failing with error 'Invalid: Timestamps already have a timezone: 'UTC'. Cannot localize to 'UTC''
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on PR #35634:
URL: https://github.com/apache/arrow/pull/35634#issuecomment-1553001616
Sure!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35634: GH-35633: [C++] R builds failing with error 'Invalid: Timestamps already have a timezone: 'UTC'. Cannot localize to 'UTC''
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35634:
URL: https://github.com/apache/arrow/pull/35634#issuecomment-1551087214
* Closes: #35633
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35634: GH-35633: [C++] R builds failing with error 'Invalid: Timestamps already have a timezone: 'UTC'. Cannot localize to 'UTC''
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35634:
URL: https://github.com/apache/arrow/pull/35634#issuecomment-1551091642
Revision: e229100c75d76846e9b83674693e888b3d4c8501
Submitted crossbow builds: [ursacomputing/crossbow @ actions-3beeb05939](https://github.com/ursacomputing/crossbow/branches/all?query=actions-3beeb05939)
|Task|Status|
|----|------|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions/runs/5001803884/jobs/8960961542)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on a diff in pull request #35634: GH-35633: [C++] R builds failing with error 'Invalid: Timestamps already have a timezone: 'UTC'. Cannot localize to 'UTC''
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche commented on code in PR #35634:
URL: https://github.com/apache/arrow/pull/35634#discussion_r1196702982
##########
cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc:
##########
@@ -120,7 +120,7 @@ struct AssumeTimezoneExtractor
static Status Exec(KernelContext* ctx, const ExecSpan& batch, ExecResult* out) {
const AssumeTimezoneOptions& options = AssumeTimezoneState::Get(ctx);
const auto& timezone = GetInputTimezone(*batch[0].type());
- if (!timezone.empty()) {
+ if (!timezone.empty() && timezone != options.timezone) {
Review Comment:
This should be reverted back I think (it shouldn't be needed to fix the failures, and I _think_ it's better to keep the "assume_timezone" kernel strict about input being tz-naive)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org