You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by rk...@apache.org on 2016/07/12 22:12:42 UTC
hadoop git commit: YARN-4366. Fix Lint Warnings in YARN Common
(templedf via rkanter)
Repository: hadoop
Updated Branches:
refs/heads/trunk 10b704c59 -> bf6f4a3b9
YARN-4366. Fix Lint Warnings in YARN Common (templedf via rkanter)
Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo
Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/bf6f4a3b
Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/bf6f4a3b
Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/bf6f4a3b
Branch: refs/heads/trunk
Commit: bf6f4a3b980a07d0b268eeb984a649a362877734
Parents: 10b704c
Author: Robert Kanter <rk...@apache.org>
Authored: Tue Jul 12 15:12:25 2016 -0700
Committer: Robert Kanter <rk...@apache.org>
Committed: Tue Jul 12 15:12:25 2016 -0700
----------------------------------------------------------------------
.../yarn/factory/providers/RpcFactoryProvider.java | 13 ++++---------
.../java/org/apache/hadoop/yarn/webapp/Router.java | 2 +-
2 files changed, 5 insertions(+), 10 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hadoop/blob/bf6f4a3b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/factory/providers/RpcFactoryProvider.java
----------------------------------------------------------------------
diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/factory/providers/RpcFactoryProvider.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/factory/providers/RpcFactoryProvider.java
index 42067e8..027dc84 100644
--- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/factory/providers/RpcFactoryProvider.java
+++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/factory/providers/RpcFactoryProvider.java
@@ -59,16 +59,11 @@ public class RpcFactoryProvider {
private static Object getFactoryClassInstance(String factoryClassName) {
try {
Class<?> clazz = Class.forName(factoryClassName);
- Method method = clazz.getMethod("get", null);
+ Method method = clazz.getMethod("get");
method.setAccessible(true);
- return method.invoke(null, null);
- } catch (ClassNotFoundException e) {
- throw new YarnRuntimeException(e);
- } catch (NoSuchMethodException e) {
- throw new YarnRuntimeException(e);
- } catch (InvocationTargetException e) {
- throw new YarnRuntimeException(e);
- } catch (IllegalAccessException e) {
+ return method.invoke(null);
+ } catch (ClassNotFoundException | NoSuchMethodException |
+ InvocationTargetException | IllegalAccessException e) {
throw new YarnRuntimeException(e);
}
}
http://git-wip-us.apache.org/repos/asf/hadoop/blob/bf6f4a3b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/Router.java
----------------------------------------------------------------------
diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/Router.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/Router.java
index cf78818..c46b50e 100644
--- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/Router.java
+++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/Router.java
@@ -97,7 +97,7 @@ class Router {
// Note: this does not distinguish methods with the same signature
// but different return types.
// TODO: We may want to deal with methods that take parameters in the future
- Method method = cls.getMethod(action, null);
+ Method method = cls.getMethod(action);
Dest dest = routes.get(path);
if (dest == null) {
method.setAccessible(true); // avoid any runtime checks
---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org