[GitHub] [iceberg] RussellSpitzer commented on a change in pull request #3845: Partition Metadata table breaks with a partition column named 'partition'

[GitBox <gi...@apache.org>]

RussellSpitzer commented on a change in pull request #3845:
URL: https://github.com/apache/iceberg/pull/3845#discussion_r780399458



##########
File path: core/src/main/java/org/apache/iceberg/BaseMetadataTable.java
##########
@@ -63,7 +63,8 @@ protected BaseMetadataTable(TableOperations ops, Table table, String name) {
    */
   static PartitionSpec transformSpec(Schema metadataTableSchema, PartitionSpec spec, String partitionPrefix) {
     PartitionSpec.Builder identitySpecBuilder = PartitionSpec.builderFor(metadataTableSchema);

Review comment:
       call checkConflict here instead of in the loop, it will also make it all fit on one line below :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org