You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@creadur.apache.org by Olivier Lamy <ol...@apache.org> on 2012/08/29 18:20:44 UTC

Unit test failure in trunk

Hi Folks,
I wanted to have a look @ RAT-118 in order to improve report of the
maven plugin.
But I have a unit test failure in trunk:
Failed tests:
  realBinaryContent(org.apache.rat.document.impl.guesser.BinaryGuesserTest)

I wonder if it's due to my env ?

assertTrue(BinaryGuesser.isBinary(new FileDocument(new
File("src/test/resources/binaries/Image-png.not"))));

I don't know exactly what is the content of this file :-)

BTW could you upgrade compiler plugin version to 2.5.1 which is really
faster in multi modules build.

Thanks!
-- 
Olivier Lamy
Talend: http://coders.talend.com
http://twitter.com/olamy | http://linkedin.com/in/olamy

Re: Unit test failure in trunk

Posted by Robert Burrell Donkin <ro...@blueyonder.co.uk>.
On 08/30/12 22:11, Olivier Lamy wrote:

<snip>

>> BTW could you upgrade compiler plugin version to 2.5.1 which is really
>> faster in multi modules build.

Done. Thanks :-)

Robert

Re: Unit test failure in trunk

Posted by Stefan Bodewig <bo...@apache.org>.
On 2012-08-30, Olivier Lamy wrote:

> any idea ?
> My env:
> Java version: 1.6.0_33, vendor: Apple Inc.
> Java home: /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home
> Default locale: fr_FR, platform encoding: MacRoman
> OS name: "mac os x", version: "10.8", arch: "x86_64", family: "mac"

I don't know whether anybody of us is using a Mac.

>> I don't know exactly what is the content of this file :-)

It's a PNG just with a different extension.

Stefan

Re: Unit test failure in trunk

Posted by Robert Burrell Donkin <ro...@blueyonder.co.uk>.
On 09/21/12 22:44, Olivier Lamy wrote:
> Sure I have seen the change  :-)
> Thanks it works now.
> I will try to propose some patches for the maven plugin (probably next week)

:-)

Robert (who's now feeling much better after a little bit of a set-back 
at the start of September)

Re: Unit test failure in trunk

Posted by Robert Burrell Donkin <ro...@blueyonder.co.uk>.
On 09/21/12 22:44, Olivier Lamy wrote:
> Sure I have seen the change  :-)
> Thanks it works now.
> I will try to propose some patches for the maven plugin (probably next week)

Deeper Maven integration for Whisker would be cool too (Whisker 
generates and validates legal information from mete-data). Advice on the 
latest thinking in the Maven community about best practices and style 
would be great. So hopefully you'll hang around :-)

Robert

Re: Unit test failure in trunk

Posted by Olivier Lamy <ol...@apache.org>.
Sure I have seen the change  :-)
Thanks it works now.
I will try to propose some patches for the maven plugin (probably next week)


2012/9/20 Robert Burrell Donkin <rd...@apache.org>:
> On 09/16/12 20:51, Robert Burrell Donkin wrote:
>>
>> On 09/16/12 17:57, Robert Burrell Donkin wrote:
>>>
>>> On 08/30/12 22:11, Olivier Lamy wrote:
>>>>
>>>> any idea ?
>>
>>
>> <snip>
>>
>>>>> But I have a unit test failure in trunk:
>>>>> Failed tests:
>>>>>
>>>>> realBinaryContent(org.apache.rat.document.impl.guesser.BinaryGuesserTest)
>>>>>
>>>>>
>>>>>
>>>>> I wonder if it's due to my env ?
>>>
>>>
>>> Quite possibly. I wonder whether this could be a platform encoding
>>> issue. I'll take a look at the code...
>>
>>
>> The binary guesses specifically (and probably rightly) uses the platform
>> encoding. This makes it a PITA to test. I think the best approach is to
>> make this test conditional on a suitable platform encoding. The binary
>> guesser code is reasonably stable, so I'm happy to trade a little test
>> coverage to allow Mac users to run the tests.
>
>
> I've committed code to make that test conditional (on platform encoding).
> Please give this another go, and see whether it works for you now...
>
> Robert



-- 
Olivier Lamy
Talend: http://coders.talend.com
http://twitter.com/olamy | http://linkedin.com/in/olamy

Re: Unit test failure in trunk

Posted by Robert Burrell Donkin <rd...@apache.org>.
On 09/16/12 20:51, Robert Burrell Donkin wrote:
> On 09/16/12 17:57, Robert Burrell Donkin wrote:
>> On 08/30/12 22:11, Olivier Lamy wrote:
>>> any idea ?
>
> <snip>
>
>>>> But I have a unit test failure in trunk:
>>>> Failed tests:
>>>> realBinaryContent(org.apache.rat.document.impl.guesser.BinaryGuesserTest)
>>>>
>>>>
>>>>
>>>> I wonder if it's due to my env ?
>>
>> Quite possibly. I wonder whether this could be a platform encoding
>> issue. I'll take a look at the code...
>
> The binary guesses specifically (and probably rightly) uses the platform
> encoding. This makes it a PITA to test. I think the best approach is to
> make this test conditional on a suitable platform encoding. The binary
> guesser code is reasonably stable, so I'm happy to trade a little test
> coverage to allow Mac users to run the tests.

I've committed code to make that test conditional (on platform 
encoding). Please give this another go, and see whether it works for you 
now...

Robert

Re: Unit test failure in trunk

Posted by Robert Burrell Donkin <ro...@blueyonder.co.uk>.
On 09/16/12 17:57, Robert Burrell Donkin wrote:
> On 08/30/12 22:11, Olivier Lamy wrote:
>> any idea ?

<snip>

>>> But I have a unit test failure in trunk:
>>> Failed tests:
>>> realBinaryContent(org.apache.rat.document.impl.guesser.BinaryGuesserTest)
>>>
>>>
>>> I wonder if it's due to my env ?
>
> Quite possibly. I wonder whether this could be a platform encoding
> issue. I'll take a look at the code...

The binary guesses specifically (and probably rightly) uses the platform 
encoding. This makes it a PITA to test. I think the best approach is to 
make this test conditional on a suitable platform encoding. The binary 
guesser code is reasonably stable, so I'm happy to trade a little test 
coverage to allow Mac users to run the tests.

Robert

Re: Unit test failure in trunk

Posted by Robert Burrell Donkin <ro...@blueyonder.co.uk>.
On 08/30/12 22:11, Olivier Lamy wrote:
> any idea ?

Hi Olivier

Apologies for being slow (I've been AFK for last couple of weeks)

> My env:
> Java version: 1.6.0_33, vendor: Apple Inc.
> Java home: /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home
> Default locale: fr_FR, platform encoding: MacRoman
> OS name: "mac os x", version: "10.8", arch: "x86_64", family: "mac"

The tests run on trunk for me with

Apache Maven 2.2.1 (r801777; 2009-08-06 20:16:01+0100)
Java version: 1.6.0_24
Java home: /opt/icedtea-bin-6.1.11.4/jre
Default locale: en_US, platform encoding: ANSI_X3.4-1968
OS name: "linux" version: "3.3.8-gentoo" arch: "amd64" Family: "unix"

:-/

> 2012/8/29 Olivier Lamy<ol...@apache.org>:
>> Hi Folks,
>> I wanted to have a look @ RAT-118 in order to improve report of the
>> maven plugin.

Sounds great :-)

>> But I have a unit test failure in trunk:
>> Failed tests:
>>    realBinaryContent(org.apache.rat.document.impl.guesser.BinaryGuesserTest)
>>
>> I wonder if it's due to my env ?

Quite possibly. I wonder whether this could be a platform encoding 
issue. I'll take a look at the code...

>> assertTrue(BinaryGuesser.isBinary(new FileDocument(new
>> File("src/test/resources/binaries/Image-png.not"))));
>>
>> I don't know exactly what is the content of this file :-)

Quite possibly an image file...

Robert

Re: Unit test failure in trunk

Posted by Olivier Lamy <ol...@apache.org>.
any idea ?
My env:
Java version: 1.6.0_33, vendor: Apple Inc.
Java home: /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home
Default locale: fr_FR, platform encoding: MacRoman
OS name: "mac os x", version: "10.8", arch: "x86_64", family: "mac"

2012/8/29 Olivier Lamy <ol...@apache.org>:
> Hi Folks,
> I wanted to have a look @ RAT-118 in order to improve report of the
> maven plugin.
> But I have a unit test failure in trunk:
> Failed tests:
>   realBinaryContent(org.apache.rat.document.impl.guesser.BinaryGuesserTest)
>
> I wonder if it's due to my env ?
>
> assertTrue(BinaryGuesser.isBinary(new FileDocument(new
> File("src/test/resources/binaries/Image-png.not"))));
>
> I don't know exactly what is the content of this file :-)
>
> BTW could you upgrade compiler plugin version to 2.5.1 which is really
> faster in multi modules build.
>
> Thanks!
> --
> Olivier Lamy
> Talend: http://coders.talend.com
> http://twitter.com/olamy | http://linkedin.com/in/olamy



-- 
Olivier Lamy
Talend: http://coders.talend.com
http://twitter.com/olamy | http://linkedin.com/in/olamy