[jira] [Commented] (HADOOP-8620) Add -Drequire.fuse and -Drequire.snappy

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-8620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421924#comment-13421924 ] 

Hadoop QA commented on HADOOP-8620:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12537762/HADOOP-8620.002.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.ha.TestZKFailoverController
                  org.apache.hadoop.hdfs.TestDFSClientRetries
                  org.apache.hadoop.hdfs.TestPersistBlocks

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1216//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1216//console

This message is automatically generated.
                
> Add -Drequire.fuse and -Drequire.snappy
> ---------------------------------------
>
>                 Key: HADOOP-8620
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8620
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 2.0.1-alpha
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>         Attachments: HADOOP-8620.002.patch
>
>
> We have some optional build components which don't get built if they are not installed on the build machine.  One of those components is fuse_dfs.  Another is the snappy support in libhadoop.so.
> Unfortunately, since these components are silently ignored if they are not present, it's easy to unintentionally create an incomplete build.
> We should add two flags, -Drequire.fuse and -Drequire.snappy, that do exactly what the names suggest.  This will make the build more repeatable.  Those who want a complete build can specify these system properties to maven.  If the build cannot be created as requested, it will be a hard error.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira