[GitHub] [flink] wangyang0918 commented on pull request #14629: [FLINK-15656][k8s] Support pod template for native kubernetes integration

[GitBox <gi...@apache.org>]

wangyang0918 commented on pull request #14629:
URL: https://github.com/apache/flink/pull/14629#issuecomment-765097339


   @blublinsky Thanks for your testing on the preview version and sharing your thoughts.
   
   > The priority between pod template and Flink config options
   
   This is a very good and important concern. When I try to introduce the pod template, I always have a rule in my mind, "Flink config options have a high priority than pod template". If you could enable this feature(e.g. labels, annotations, tolerations, etc.) via config options, then you should do it.
   
   Flink allows users to define the JobManager and TaskManager via pod template file with the non-common features, which are not supported by Flink [Kubernetes config options](https://ci.apache.org/projects/flink/flink-docs-master/deployment/config.html#kubernetes) directly. Please use [kubernetes.jobmanager.pod-template-file](https://ci.apache.org/projects/flink/flink-docs-master/deployment/config.html#kubernetes-jobmanager-pod-template-file)
   or [kubernetes.taskmanager.pod-template-file](https://ci.apache.org/projects/flink/flink-docs-master/deployment/config.html#kubernetes-taskmanager-pod-template-file) to specify a local file that contains pod definition. It will be used to **initialize** the JobManager/TaskManager instead of an empty pod. Please note that some fields of the pod template will always be overridden by Flink. Refer to the following tables for the full list of pod fields that will be overwritten by Flink. _I am now working to provide such tables in this PR._
   
   I know some guys may argue for that. In the pod template design, it is a supplement for some un-common features and provide enough flexibility to use new K8s features. Also I believe for Flink users, they prefer the config option if they could.
   
   > Both this and owner manager PRs are still not merged. - do you have a time frame for merging/releasing them?
   
   I am trying to refine this PR and also provide a thorough documentation so that users could easily use it. For owner reference PR, I already left some comments few days ago, could you please address them before merging?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org