You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2022/03/13 10:27:55 UTC

[GitHub] [libcloud] Kami commented on pull request #1663: Authenticate with Azure Ad for Provider AZURE_BLOBS

Kami commented on pull request #1663:
URL: https://github.com/apache/libcloud/pull/1663#issuecomment-1066070339


   Thanks for the contribution.
   
   Overall the change seems reasonable to me, but I'm not an Azure expert so I would prefer @c-w to review it as well.
   
   In addition to that, since it's a large change, end to end tests would also be good - we already do have some azure end to end tests in place (ones based on Azurite docker image and other ones talking directly to Azure API).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org