You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/08/25 18:10:18 UTC

Review Request 61915: Enabled `DockerContainerizerProcess::usage` for all platforms.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61915/
-----------------------------------------------------------

Review request for mesos, Jie Yu, Joseph Wu, and Li Li.


Bugs: MESOS-7917
    https://issues.apache.org/jira/browse/MESOS-7917


Repository: mesos


Description
-------

When originally implemented this code was enabled only for Linux.
However, this code should work anywhere Docker is being used, as it
obtains the information by shelling out to the `docker` executable.

This patch fixes the resources information provided by the `mesos-agent`
on Windows platforms for Docker containers by making the `statistics`
JSON object available.

Note that the `cgroupsStatistics` is Linux specific, and so the
pre-processor guard was not removed but reduced in scope for just it.


Diffs
-----

  src/slave/containerizer/docker.cpp cbcff39a5d8398f71570849615aeb4368130b433 


Diff: https://reviews.apache.org/r/61915/diff/1/


Testing
-------

Built on Windows, started a Windows Docker container, observed the `statistics` field from `<theagent>/container` being populated where it was not previously included.

Building and running `mesos-tests`, update pending.


Thanks,

Andrew Schwartzmeyer