[GitHub] [spark] Yikun commented on a diff in pull request #36569: [SPARK-39201][PYTHON][PS] Implement `ignore_index` of `DataFrame.explode` and `DataFrame.drop_duplicates`

[GitBox <gi...@apache.org>]

Yikun commented on code in PR #36569:
URL: https://github.com/apache/spark/pull/36569#discussion_r876716230


##########
python/pyspark/pandas/frame.py:
##########
@@ -12212,7 +12237,8 @@ def explode(self, column: Name) -> "DataFrame":
         data_fields[idx] = field.copy(dtype=dtype, spark_type=spark_type, nullable=True)
 
         internal = psdf._internal.with_new_sdf(sdf, data_fields=data_fields)
-        return DataFrame(internal)
+        result_df: DataFrame = DataFrame(internal)

Review Comment:
   Just curious: any helps of this annotaion? Because I saw many inconsist in current PS codebase.
   
   ```python
   pdf = DataFrame(internal)
   pdf: DataFrame = DataFrame(internal)
   ```
   
   I thought annotation only helps in public interface/parameter or schema infer, so any other one should be cleanup.
   
   cc @zero323 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org