You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "roczei (via GitHub)" <gi...@apache.org> on 2024/08/17 19:15:39 UTC

Re: [PR] [SPARK-48867][BUILD] Upgrade `okhttp` to 4.12.0 and `okio` to 3.9.0 [spark]

roczei commented on code in PR #47795:
URL: https://github.com/apache/spark/pull/47795#discussion_r1720820812


##########
pom.xml:
##########
@@ -231,7 +231,9 @@
     <!-- org.fusesource.leveldbjni will be used except on arm64 platform. -->
     <leveldbjni.group>org.fusesource.leveldbjni</leveldbjni.group>
     <kubernetes-client.version>6.13.3</kubernetes-client.version>
-    <okio.version>1.17.6</okio.version>
+    <okio.version>3.6.0</okio.version>
+    <okhttp.version>4.12.0</okhttp.version>
+    <kotlin-stdlib.version>1.9.10</kotlin-stdlib.version>

Review Comment:
   Hi @dongjoon-hyun,
   
   Thanks for the review! 
   
   > This looks like outdated because this is not the latest (2.0.10) nor the latest of 1.9.x line. Is there a reason we need to be stuck with this specific version?
   
   No special reason, I just used the higher version number what I have seen in the build/mvn dependency:tree command's output. 
   
   Updated the pull request and increased the okio version to 3.9.0 and the kotlin-stdlib version to 2.0.10. I found these latest versions in the Updates column of the following page:
   
   https://mvnrepository.com/artifact/com.squareup.okhttp3/okhttp/4.12.0



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org