You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Rob Schapper (JIRA)" <ji...@apache.org> on 2008/06/30 22:20:45 UTC
[jira] Created: (OFBIZ-1858) Moved screenlets out of table and into
div's to make it CSS stylable
Moved screenlets out of table and into div's to make it CSS stylable
--------------------------------------------------------------------
Key: OFBIZ-1858
URL: https://issues.apache.org/jira/browse/OFBIZ-1858
Project: OFBiz
Issue Type: Improvement
Reporter: Rob Schapper
Priority: Trivial
Removed the tables that the screenlets were in. I also added Id's to the screenlets and made entries into the ecommain.css file to have the default style be the same as the table layout.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1858) Moved screenlets out of table and
into div's to make it CSS stylable in checkoutoptions.ftl for ecommerce
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12612832#action_12612832 ]
Jacques Le Roux commented on OFBIZ-1858:
----------------------------------------
Sorry Rob,
I realise that this might be interpreted as a bit rude. It comes from my poor English (and my poor English manners too).
So it should have been : <<Had you a chance to have a fresh look at this ? And do you think you would be able to provide a new patch soon>> :o)
> Moved screenlets out of table and into div's to make it CSS stylable in checkoutoptions.ftl for ecommerce
> ----------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1858
> URL: https://issues.apache.org/jira/browse/OFBIZ-1858
> Project: OFBiz
> Issue Type: Improvement
> Components: ecommerce
> Reporter: Rob Schapper
> Priority: Trivial
> Attachments: checkoutoptions-css.patch
>
>
> Removed the tables that the screenlets were in. I also added Id's to the screenlets and made entries into the ecommain.css file to have the default style be the same as the table layout.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1858) Moved screenlets out of table and
into div's to make it CSS stylable in checkoutoptions.ftl for ecommerce
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12612972#action_12612972 ]
Jacques Le Roux commented on OFBIZ-1858:
----------------------------------------
Rob,
One problem : it breaks the convenient three columns screen we used to have...
> Moved screenlets out of table and into div's to make it CSS stylable in checkoutoptions.ftl for ecommerce
> ----------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1858
> URL: https://issues.apache.org/jira/browse/OFBIZ-1858
> Project: OFBiz
> Issue Type: Improvement
> Components: ecommerce
> Reporter: Rob Schapper
> Priority: Trivial
> Attachments: checkoutoptions-css.patch, checkoutoptions-css.patch
>
>
> Removed the tables that the screenlets were in. I also added Id's to the screenlets and made entries into the ecommain.css file to have the default style be the same as the table layout.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1858) Moved screenlets out of table and
into div's to make it CSS stylable in checkoutoptions.ftl for ecommerce
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613004#action_12613004 ]
Jacques Le Roux commented on OFBIZ-1858:
----------------------------------------
Sorry Rob,
But apart some trivial differences these patches are the same (I checked in Winmerge). So something seems still to miss...
> Moved screenlets out of table and into div's to make it CSS stylable in checkoutoptions.ftl for ecommerce
> ----------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1858
> URL: https://issues.apache.org/jira/browse/OFBIZ-1858
> Project: OFBiz
> Issue Type: Improvement
> Components: ecommerce
> Reporter: Rob Schapper
> Priority: Trivial
> Attachments: checkoutoptions-css.patch, checkoutoptions-css.patch, checkoutoptions-css.patch
>
>
> Removed the tables that the screenlets were in. I also added Id's to the screenlets and made entries into the ecommain.css file to have the default style be the same as the table layout.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1858) Moved screenlets out of table and
into div's to make it CSS stylable in checkoutoptions.ftl for ecommerce
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12612827#action_12612827 ]
Jacques Le Roux commented on OFBIZ-1858:
----------------------------------------
Rob,
Will you provide a new patch soon ?
> Moved screenlets out of table and into div's to make it CSS stylable in checkoutoptions.ftl for ecommerce
> ----------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1858
> URL: https://issues.apache.org/jira/browse/OFBIZ-1858
> Project: OFBiz
> Issue Type: Improvement
> Components: ecommerce
> Reporter: Rob Schapper
> Priority: Trivial
> Attachments: checkoutoptions-css.patch
>
>
> Removed the tables that the screenlets were in. I also added Id's to the screenlets and made entries into the ecommain.css file to have the default style be the same as the table layout.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1858) Moved screenlets out of table and
into div's to make it CSS stylable in checkoutoptions.ftl for ecommerce
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12609358#action_12609358 ]
Adrian Crum commented on OFBIZ-1858:
------------------------------------
Rob,
One trivial bit of advice on CSS classes...
If you assign an ID to an HTML element, and you follow the W3C guideline that IDs must be unique within a page, then you don't need to specify parent elements in your CSS selector:
/* ===== Quickcheckout Styles ===== */
#wheretoship{
float:left;
width:20%;
}
#howtoship{
float:left;
width:55%;
margin-left:20px;
}
> Moved screenlets out of table and into div's to make it CSS stylable in checkoutoptions.ftl for ecommerce
> ----------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1858
> URL: https://issues.apache.org/jira/browse/OFBIZ-1858
> Project: OFBiz
> Issue Type: Improvement
> Components: ecommerce
> Reporter: Rob Schapper
> Priority: Trivial
> Attachments: checkoutoptions-css.patch
>
>
> Removed the tables that the screenlets were in. I also added Id's to the screenlets and made entries into the ecommain.css file to have the default style be the same as the table layout.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1858) Moved screenlets out of table and into
div's to make it CSS stylable in checkoutoptions.ftl for ecommerce
Posted by "Rob Schapper (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rob Schapper updated OFBIZ-1858:
--------------------------------
Attachment: checkoutoptions-css.patch
Here is the new Patch. Sorry I thought I uploaded already. Must have slipped through the cracks. Thank you for the reminder :)
> Moved screenlets out of table and into div's to make it CSS stylable in checkoutoptions.ftl for ecommerce
> ----------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1858
> URL: https://issues.apache.org/jira/browse/OFBIZ-1858
> Project: OFBiz
> Issue Type: Improvement
> Components: ecommerce
> Reporter: Rob Schapper
> Priority: Trivial
> Attachments: checkoutoptions-css.patch, checkoutoptions-css.patch
>
>
> Removed the tables that the screenlets were in. I also added Id's to the screenlets and made entries into the ecommain.css file to have the default style be the same as the table layout.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1858) Moved screenlets out of table and into
div's to make it CSS stylable in checkoutoptions.ftl for ecommerce
Posted by "Rob Schapper (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rob Schapper updated OFBIZ-1858:
--------------------------------
Attachment: checkoutoptions-css.patch
I might have messed up the patch as I was in a hurry, but it does not break the 3 column layout for me. Maybe you could point out what I am doing wrong. Here is a new working (for me at least) copy of the patch.
> Moved screenlets out of table and into div's to make it CSS stylable in checkoutoptions.ftl for ecommerce
> ----------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1858
> URL: https://issues.apache.org/jira/browse/OFBIZ-1858
> Project: OFBiz
> Issue Type: Improvement
> Components: ecommerce
> Reporter: Rob Schapper
> Priority: Trivial
> Attachments: checkoutoptions-css.patch, checkoutoptions-css.patch, checkoutoptions-css.patch
>
>
> Removed the tables that the screenlets were in. I also added Id's to the screenlets and made entries into the ecommain.css file to have the default style be the same as the table layout.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1858) Moved screenlets out of table and into
div's to make it CSS stylable in checkoutoptions.ftl for ecommerce
Posted by "Rob Schapper (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rob Schapper closed OFBIZ-1858.
-------------------------------
Resolution: Invalid
Invalid with new changes on checkouts
> Moved screenlets out of table and into div's to make it CSS stylable in checkoutoptions.ftl for ecommerce
> ----------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1858
> URL: https://issues.apache.org/jira/browse/OFBIZ-1858
> Project: OFBiz
> Issue Type: Improvement
> Components: ecommerce
> Reporter: Rob Schapper
> Priority: Trivial
> Attachments: checkoutoptions-css.patch, checkoutoptions-css.patch, checkoutoptions-css.patch
>
>
> Removed the tables that the screenlets were in. I also added Id's to the screenlets and made entries into the ecommain.css file to have the default style be the same as the table layout.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1858) Moved screenlets out of table and into
div's to make it CSS stylable in checkoutoptions.ftl for ecommerce
Posted by "Rob Schapper (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rob Schapper updated OFBIZ-1858:
--------------------------------
Component/s: ecommerce
Summary: Moved screenlets out of table and into div's to make it CSS stylable in checkoutoptions.ftl for ecommerce (was: Moved screenlets out of table and into div's to make it CSS stylable)
> Moved screenlets out of table and into div's to make it CSS stylable in checkoutoptions.ftl for ecommerce
> ----------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1858
> URL: https://issues.apache.org/jira/browse/OFBIZ-1858
> Project: OFBiz
> Issue Type: Improvement
> Components: ecommerce
> Reporter: Rob Schapper
> Priority: Trivial
> Attachments: checkoutoptions-css.patch
>
>
> Removed the tables that the screenlets were in. I also added Id's to the screenlets and made entries into the ecommain.css file to have the default style be the same as the table layout.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1858) Moved screenlets out of table and
into div's to make it CSS stylable in checkoutoptions.ftl for ecommerce
Posted by "Rob Schapper (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12609369#action_12609369 ]
Rob Schapper commented on OFBIZ-1858:
-------------------------------------
Adrian,
Thanks for the advice, always looking for ways to be a more efficient coder.
> Moved screenlets out of table and into div's to make it CSS stylable in checkoutoptions.ftl for ecommerce
> ----------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1858
> URL: https://issues.apache.org/jira/browse/OFBIZ-1858
> Project: OFBiz
> Issue Type: Improvement
> Components: ecommerce
> Reporter: Rob Schapper
> Priority: Trivial
> Attachments: checkoutoptions-css.patch
>
>
> Removed the tables that the screenlets were in. I also added Id's to the screenlets and made entries into the ecommain.css file to have the default style be the same as the table layout.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1858) Moved screenlets out of table and into
div's to make it CSS stylable
Posted by "Rob Schapper (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rob Schapper updated OFBIZ-1858:
--------------------------------
Attachment: checkoutoptions-css.patch
Here is the patch thta makes the changes to the quick checkout page
> Moved screenlets out of table and into div's to make it CSS stylable
> --------------------------------------------------------------------
>
> Key: OFBIZ-1858
> URL: https://issues.apache.org/jira/browse/OFBIZ-1858
> Project: OFBiz
> Issue Type: Improvement
> Reporter: Rob Schapper
> Priority: Trivial
> Attachments: checkoutoptions-css.patch
>
>
> Removed the tables that the screenlets were in. I also added Id's to the screenlets and made entries into the ecommain.css file to have the default style be the same as the table layout.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1858) Moved screenlets out of table and
into div's to make it CSS stylable in checkoutoptions.ftl for ecommerce
Posted by "Rob Schapper (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613006#action_12613006 ]
Rob Schapper commented on OFBIZ-1858:
-------------------------------------
All right back to the drawing board I will try to figure it out. Thanks for checking on your end.
> Moved screenlets out of table and into div's to make it CSS stylable in checkoutoptions.ftl for ecommerce
> ----------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1858
> URL: https://issues.apache.org/jira/browse/OFBIZ-1858
> Project: OFBiz
> Issue Type: Improvement
> Components: ecommerce
> Reporter: Rob Schapper
> Priority: Trivial
> Attachments: checkoutoptions-css.patch, checkoutoptions-css.patch, checkoutoptions-css.patch
>
>
> Removed the tables that the screenlets were in. I also added Id's to the screenlets and made entries into the ecommain.css file to have the default style be the same as the table layout.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.