You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Jukka Zitting (JIRA)" <ji...@apache.org> on 2013/11/06 21:12:17 UTC

[jira] [Resolved] (OAK-630) SegmentMK: Implement compareAgainstBaseState

     [ https://issues.apache.org/jira/browse/OAK-630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting resolved OAK-630.
-------------------------------

       Resolution: Fixed
    Fix Version/s: 0.11

The implementation could still be optimized further, but the most important bits are already in, so resolving this as fixed and leaving further improvements to followup issues.

> SegmentMK: Implement compareAgainstBaseState
> --------------------------------------------
>
>                 Key: OAK-630
>                 URL: https://issues.apache.org/jira/browse/OAK-630
>             Project: Jackrabbit Oak
>          Issue Type: Sub-task
>          Components: segmentmk
>            Reporter: Jukka Zitting
>            Assignee: Jukka Zitting
>             Fix For: 0.11
>
>
> Currently the {{SegmentNodeState}} class simply inherits the generic {{compareAgainstBaseState()}} implementation from the {{AbstractNodeState}} base class. While functionally complete, this generic implementation is pretty slow as it can't leverage lower level information about how nodes are actually stored.
> I already improved the situation somewhat by implementing a basic optimization in {{SegmentNodeState.equals()}}, but to get the full benefits of the segment model we should implement the full {{compareAgainstBaseState()}} mechanism based directly on the in-segment data structures.



--
This message was sent by Atlassian JIRA
(v6.1#6144)