You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@clerezza.apache.org by Henry Story <he...@bblfish.net> on 2011/05/07 19:04:39 UTC
Private-Package in POM was: svn commit: r1099471
On 7 May 2011, at 18:58, Reto Bachmann-Gmuer wrote:
> did you see this mail to the list?
no Reto, thanks for sending it again. If you don't change the Subject of the thread to something readable it is very unlikely I'll notice. As you imagine I don't read all the commits to the list.
Your mail was titled "Fwd: svn commit: r1099471 - /incubator/clerezza/trunk/parent/platform.security.foafssl/test/pom.xml"
> I guess you're using the wrong directive, but probably none should be needed. I suggest you explain on the list what goes wrong without this directive.
Without the Private-Package directive it just did not compile the classes. Let me know if you have different behavior.
>
> cheers
> reto
>
> ---------- Forwarded message ----------
> From: Reto Bachmann-Gmuer <re...@trialox.org>
> Date: Thu, May 5, 2011 at 8:58 PM
> Subject: Re: svn commit: r1099471 - /incubator/clerezza/trunk/parent/platform.security.foafssl/test/pom.xml
> To: clerezza-dev@incubator.apache.org
>
>
> Hi Henry
>
> Never seen this kind of hack, why do you declare a package provided by another bundle as private?
>
> Cheers,
> Reto
>
>
> On Wed, May 4, 2011 at 4:51 PM, <bb...@apache.org> wrote:
> Author: bblfish
> Date: Wed May 4 14:51:54 2011
> New Revision: 1099471
>
> URL: http://svn.apache.org/viewvc?rev=1099471&view=rev
> Log:
> pom changes to get to compile correctly. The EasyGraph class had initially been in the main rdf.scala.utils package, but I had decided last minute to move it here, so that people could consider it more carefully first. But that move requires a pom change
>
> Modified:
> incubator/clerezza/trunk/parent/platform.security.foafssl/test/pom.xml
>
> Modified: incubator/clerezza/trunk/parent/platform.security.foafssl/test/pom.xml
> URL: http://svn.apache.org/viewvc/incubator/clerezza/trunk/parent/platform.security.foafssl/test/pom.xml?rev=1099471&r1=1099470&r2=1099471&view=diff
> ==============================================================================
> --- incubator/clerezza/trunk/parent/platform.security.foafssl/test/pom.xml (original)
> +++ incubator/clerezza/trunk/parent/platform.security.foafssl/test/pom.xml Wed May 4 14:51:54 2011
> @@ -117,7 +117,6 @@
> </execution>
> </executions>
> <configuration>
> - <scalaVersion>${scala.version}</scalaVersion>
> <charset>UTF-8</charset>
> <!-- <args>
> <arg>-target:jvm-1.5</arg>
> @@ -130,6 +129,7 @@
> <configuration>
> <instructions>
> <Service-Component>OSGI-INF/serviceComponents.xml</Service-Component>
> + <Private-Package>org.apache.clerezza.rdf.scala.utils.*</Private-Package>
> <Export-Package>org.apache.clerezza.foafssl.test.*</Export-Package>
> <Bundle-SymbolicName>${project.groupId}.${project.artifactId}</Bundle-SymbolicName>
> </instructions>
>
>
>
>
Social Web Architect
http://bblfish.net/
Re: Private-Package in POM was: svn commit: r1099471
Posted by Reto Bachmann-Gmuer <re...@trialox.org>.
Hi Henry
I now see that the bundle really contains such a package, but this package
(org.apache.clerezza.rdf.scala.utill) allready exists in another bundle
(rdf.scala.utils), I don't think this is a good idea to have a package in
muliple bundles, as long as EasyGraph is an experiment just leave in a
package or subpackage of where it is used. Most bundles contains only
packages starting with <group-id>.<artifact-id>, I think this is a good
convention.
Cheers,
reto
On Sat, May 7, 2011 at 7:04 PM, Henry Story <he...@bblfish.net> wrote:
>
> On 7 May 2011, at 18:58, Reto Bachmann-Gmuer wrote:
>
> did you see this mail to the list?
>
>
> no Reto, thanks for sending it again. If you don't change the Subject of
> the thread to something readable it is very unlikely I'll notice. As you
> imagine I don't read all the commits to the list.
>
> Your mail was titled "*Fwd: svn commit: r1099471 -
> /incubator/clerezza/trunk/parent/platform.security.foafssl/test/pom.xml"*
> *
> *
>
> I guess you're using the wrong directive, but probably none should be
> needed. I suggest you explain on the list what goes wrong without this
> directive.
>
>
> Without the Private-Package directive it just did not compile the classes.
> Let me know if you have different behavior.
>
>
>
> cheers
> reto
>
> ---------- Forwarded message ----------
> From: Reto Bachmann-Gmuer <re...@trialox.org>
> Date: Thu, May 5, 2011 at 8:58 PM
> Subject: Re: svn commit: r1099471 -
> /incubator/clerezza/trunk/parent/platform.security.foafssl/test/pom.xml
> To: clerezza-dev@incubator.apache.org
>
>
> Hi Henry
>
> Never seen this kind of hack, why do you declare a package provided by
> another bundle as private?
>
> Cheers,
> Reto
>
>
> On Wed, May 4, 2011 at 4:51 PM, <bb...@apache.org> wrote:
>
>> Author: bblfish
>> Date: Wed May 4 14:51:54 2011
>> New Revision: 1099471
>>
>> URL: http://svn.apache.org/viewvc?rev=1099471&view=rev
>> Log:
>> pom changes to get to compile correctly. The EasyGraph class had initially
>> been in the main rdf.scala.utils package, but I had decided last minute to
>> move it here, so that people could consider it more carefully first. But
>> that move requires a pom change
>>
>> Modified:
>> incubator/clerezza/trunk/parent/platform.security.foafssl/test/pom.xml
>>
>> Modified:
>> incubator/clerezza/trunk/parent/platform.security.foafssl/test/pom.xml
>> URL:
>> http://svn.apache.org/viewvc/incubator/clerezza/trunk/parent/platform.security.foafssl/test/pom.xml?rev=1099471&r1=1099470&r2=1099471&view=diff
>>
>> ==============================================================================
>> --- incubator/clerezza/trunk/parent/platform.security.foafssl/test/pom.xml
>> (original)
>> +++ incubator/clerezza/trunk/parent/platform.security.foafssl/test/pom.xml
>> Wed May 4 14:51:54 2011
>> @@ -117,7 +117,6 @@
>> </execution>
>> </executions>
>> <configuration>
>> -
>> <scalaVersion>${scala.version}</scalaVersion>
>> <charset>UTF-8</charset>
>> <!-- <args>
>> <arg>-target:jvm-1.5</arg>
>> @@ -130,6 +129,7 @@
>> <configuration>
>> <instructions>
>>
>> <Service-Component>OSGI-INF/serviceComponents.xml</Service-Component>
>> +
>> <Private-Package>org.apache.clerezza.rdf.scala.utils.*</Private-Package>
>>
>> <Export-Package>org.apache.clerezza.foafssl.test.*</Export-Package>
>>
>> <Bundle-SymbolicName>${project.groupId}.${project.artifactId}</Bundle-SymbolicName>
>> </instructions>
>>
>>
>>
>
>
> Social Web Architect
> http://bblfish.net/
>
>