You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "keith-turner (via GitHub)" <gi...@apache.org> on 2025/02/08 19:50:21 UTC
[PR] fixes spurious race condition in client close [accumulo]
keith-turner opened a new pull request, #5318:
URL: https://github.com/apache/accumulo/pull/5318
When the close the accumulo client the following could happen.
1. THREAD1 sets closed atomic boolean to true in client as part of close() call
2. THREAD2 a background thread in transport pool tries to read property from client and gets exception because closed is true
3. THREAD1 shuts down the transport pool object as part of closing client
This change avoids throwing an exception in step 2 above. This bug was causing MetaFateOpsCommandsIT to sometimes fail because it would have a random exception in the json the command was printing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fixes spurious race condition in client close [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner merged PR #5318:
URL: https://github.com/apache/accumulo/pull/5318
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fixes spurious race condition in client close [accumulo]
Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii commented on PR #5318:
URL: https://github.com/apache/accumulo/pull/5318#issuecomment-2752296557
> A similar fix was made in #5258 for the ClientContext. This PR fixes it for ServerContext. However, the problem persists in the 3.1 branch for ServerContext, and there may be a simpler way to address it. I will look into that.
The 3.1 branch was removed, and this impl is fine. It may be possible to simplify this a bit, but probably not worth any substantial amount of time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fixes spurious race condition in client close [accumulo]
Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii commented on PR #5318:
URL: https://github.com/apache/accumulo/pull/5318#issuecomment-2649621477
A similar fix was made in #5258 for the ClientContext. This PR fixes it for ServerContext. However, the problem persists in the 3.1 branch for ServerContext, and there may be a simpler way to address it. I will look into that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org