You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/09/08 03:41:25 UTC
[GitHub] [superset] MaxHuiYYDS opened a new pull request #16630: fix(explore): fix local development explore error
MaxHuiYYDS opened a new pull request #16630:
URL: https://github.com/apache/superset/pull/16630
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
In local development, when directory to explore, the colnames returns null, and can not been iterate, which will stop the rest local development steps.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<img width="1405" alt="Screen Shot 2021-09-08 at 11 36 36 AM" src="https://user-images.githubusercontent.com/51693396/132442608-8497574c-3e0e-482c-9246-5161d9faa4b9.png">
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] MaxHuiYYDS commented on pull request #16630: fix(explore): fix local development explore error
Posted by GitBox <gi...@apache.org>.
MaxHuiYYDS commented on pull request #16630:
URL: https://github.com/apache/superset/pull/16630#issuecomment-918214939
Seems like my local env problem, after setting on a new laptop, this error not occur any more. Sorry for any inconvenient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] MaxHuiYYDS removed a comment on pull request #16630: fix(explore): fix local development explore error
Posted by GitBox <gi...@apache.org>.
MaxHuiYYDS removed a comment on pull request #16630:
URL: https://github.com/apache/superset/pull/16630#issuecomment-918214672
Seems like my local env problem, after setting on a new laptop, this error not occur any more. Sorry for any inconvenient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #16630: fix(explore): fix local development explore error
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #16630:
URL: https://github.com/apache/superset/pull/16630#discussion_r704009444
##########
File path: superset-frontend/src/explore/components/DataTablesPane/index.tsx
##########
@@ -225,7 +225,7 @@ export const DataTablesPane = ({
useEffect(() => {
if (queriesResponse && chartStatus === 'success') {
- const { colnames } = queriesResponse[0];
+ const { colnames = [] } = queriesResponse[0];
Review comment:
codes LGTM, how to reproduce this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] MaxHuiYYDS commented on a change in pull request #16630: fix(explore): fix local development explore error
Posted by GitBox <gi...@apache.org>.
MaxHuiYYDS commented on a change in pull request #16630:
URL: https://github.com/apache/superset/pull/16630#discussion_r704020890
##########
File path: superset-frontend/src/explore/components/DataTablesPane/index.tsx
##########
@@ -225,7 +225,7 @@ export const DataTablesPane = ({
useEffect(() => {
if (queriesResponse && chartStatus === 'success') {
- const { colnames } = queriesResponse[0];
+ const { colnames = [] } = queriesResponse[0];
Review comment:
Reproduce: chart list / welcome -> select birth_names related chart(eg: Pivot Table, Top 10 Boy Name Share).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #16630: fix(explore): fix local development explore error
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #16630:
URL: https://github.com/apache/superset/pull/16630#issuecomment-914894983
# [Codecov](https://codecov.io/gh/apache/superset/pull/16630?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16630](https://codecov.io/gh/apache/superset/pull/16630?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (95f07f0) into [master](https://codecov.io/gh/apache/superset/commit/519baa6f005a67c13ab13ad4bc2776f73afabed0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (519baa6) will **increase** coverage by `0.00%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/superset/pull/16630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16630 +/- ##
=======================================
Coverage 76.77% 76.78%
=======================================
Files 1003 1003
Lines 53959 53959
Branches 7330 7331 +1
=======================================
+ Hits 41427 41431 +4
+ Misses 12293 12288 -5
- Partials 239 240 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `71.10% <0.00%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nd/src/explore/components/DataTablesPane/index.tsx](https://codecov.io/gh/apache/superset/pull/16630/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS9pbmRleC50c3g=) | `75.24% <0.00%> (ø)` | |
| [superset-frontend/src/components/Select/Select.tsx](https://codecov.io/gh/apache/superset/pull/16630/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1NlbGVjdC50c3g=) | `74.28% <0.00%> (+1.63%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16630?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16630?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [519baa6...95f07f0](https://codecov.io/gh/apache/superset/pull/16630?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] MaxHuiYYDS closed pull request #16630: fix(explore): fix local development explore error
Posted by GitBox <gi...@apache.org>.
MaxHuiYYDS closed pull request #16630:
URL: https://github.com/apache/superset/pull/16630
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] MaxHuiYYDS commented on pull request #16630: fix(explore): fix local development explore error
Posted by GitBox <gi...@apache.org>.
MaxHuiYYDS commented on pull request #16630:
URL: https://github.com/apache/superset/pull/16630#issuecomment-918214672
Seems like my local env problem, after setting on a new laptop, this error not occur any more. Sorry for any inconvenient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org