You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2017/04/22 02:47:38 UTC
Review Request 58642: Cancelled the disk usage collection if no longer
needed.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58642/
-----------------------------------------------------------
Review request for mesos, Gilbert Song and Artem Harutyunyan.
Bugs: MESOS-4263
https://issues.apache.org/jira/browse/MESOS-4263
Repository: mesos
Description
-------
We actively cancel the disk usage collection if its result is no
longer needed. This is a performance optimization.
Diffs
-----
src/slave/containerizer/mesos/isolators/posix/disk.cpp 127f490cc0622293b4ace34510f8459b340e1742
Diff: https://reviews.apache.org/r/58642/diff/1/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 58642: Cancelled the disk usage collection if no
longer needed.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58642/#review172836
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On April 21, 2017, 7:47 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58642/
> -----------------------------------------------------------
>
> (Updated April 21, 2017, 7:47 p.m.)
>
>
> Review request for mesos, Gilbert Song and Artem Harutyunyan.
>
>
> Bugs: MESOS-4263
> https://issues.apache.org/jira/browse/MESOS-4263
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We actively cancel the disk usage collection if its result is no
> longer needed. This is a performance optimization.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/posix/disk.cpp 127f490cc0622293b4ace34510f8459b340e1742
>
>
> Diff: https://reviews.apache.org/r/58642/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>