You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/06/28 06:43:37 UTC
[GitHub] [arrow] Ktakuya332C opened a new pull request #7565: ARROW-9256: [C++] Incorrect variable name ARROW_CXX_FLAGS
Ktakuya332C opened a new pull request #7565:
URL: https://github.com/apache/arrow/pull/7565
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] Ktakuya332C commented on a change in pull request #7565: ARROW-9256: [C++] Incorrect variable name ARROW_CXX_FLAGS
Posted by GitBox <gi...@apache.org>.
Ktakuya332C commented on a change in pull request #7565:
URL: https://github.com/apache/arrow/pull/7565#discussion_r446610914
##########
File path: cpp/CMakeLists.txt
##########
@@ -472,7 +472,7 @@ set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${ARROW_CXXFLAGS}")
# For any C code, use the same flags. These flags don't contain
# C++ specific flags.
-set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${ARROW_CXX_FLAGS} ${CXX_COMMON_FLAGS}")
+set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${ARROW_CXXFLAGS} ${CXX_COMMON_FLAGS}")
Review comment:
Thank you for your comment! Changed the order in 6e7aaa3.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #7565: ARROW-9256: [C++] Incorrect variable name ARROW_CXX_FLAGS
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #7565:
URL: https://github.com/apache/arrow/pull/7565#discussion_r446609892
##########
File path: cpp/CMakeLists.txt
##########
@@ -472,7 +472,7 @@ set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${ARROW_CXXFLAGS}")
# For any C code, use the same flags. These flags don't contain
# C++ specific flags.
-set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${ARROW_CXX_FLAGS} ${CXX_COMMON_FLAGS}")
+set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${ARROW_CXXFLAGS} ${CXX_COMMON_FLAGS}")
Review comment:
Good catch!
Could you use `${CXX_COMMON_FLAGS} ${ARROW_CXXFLAGS}` order to allow overriding `${CXX_COMMON_FLAGS}` by `${ARROW_CXXFLAGS}`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7565: ARROW-9256: [C++] Incorrect variable name ARROW_CXX_FLAGS
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7565:
URL: https://github.com/apache/arrow/pull/7565#issuecomment-650706362
https://issues.apache.org/jira/browse/ARROW-9256
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed pull request #7565: ARROW-9256: [C++] Incorrect variable name ARROW_CXX_FLAGS
Posted by GitBox <gi...@apache.org>.
kou closed pull request #7565:
URL: https://github.com/apache/arrow/pull/7565
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org