You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by David McLaughlin <da...@dmclaughlin.com> on 2017/09/21 23:17:34 UTC

Review Request 62451: Implement Role and Environment pages in Preact.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62451/
-----------------------------------------------------------

Review request for Aurora, Joshua Cohen, Kai Huang, and Santhosh Kumar Shanmugham.


Repository: aurora


Description
-------

Implement Role and Environment pages in Preact. The color scheme and other design elements aren't final yet - the plan is to wait until the structure is all in place and then go back and style things. 

Major difference from the current UI is the use of color to visualize the task states and the move away from the table format of the data.


Diffs
-----

  ui/src/main/js/components/JobList.js PRE-CREATION 
  ui/src/main/js/components/Layout.js PRE-CREATION 
  ui/src/main/js/components/RoleQuota.js PRE-CREATION 
  ui/src/main/js/components/__tests__/JobList-test.js PRE-CREATION 
  ui/src/main/js/components/__tests__/RoleQuota-test.js PRE-CREATION 
  ui/src/main/js/index.js 717aaa080d1365785a603ed7d1ece69efdaafec7 
  ui/src/main/js/pages/Jobs.js PRE-CREATION 
  ui/src/main/js/pages/__tests__/Jobs-test.js PRE-CREATION 
  ui/src/main/js/utils/Common.js PRE-CREATION 
  ui/src/main/sass/app.scss 0b3967d39ed443eaf5bfadb473816135e0a978e4 
  ui/src/main/sass/components/_job-list-page.scss PRE-CREATION 
  ui/src/main/sass/components/_layout.scss b8a83b585fcef11964dc8349703ad453d37b5d2d 
  ui/src/main/sass/components/_tables.scss 58f176cffcdae34de7c776e31b3f0342efa3024f 
  ui/src/main/sass/modules/_colors.scss 147cff691058972aebc5f79f22955cf2448ce48c 


Diff: https://reviews.apache.org/r/62451/diff/1/


Testing
-------

./gradlew ui:test
./gradlew ui:lint

See screenshot for local development with some Twitter data.


File Attachments
----------------

Screenshot 
  https://reviews.apache.org/media/uploaded/files/2017/09/21/684d8630-a9b4-4fbf-8955-a7fc118afcce__Screen_Shot_2017-09-21_at_4.11.05_PM.png


Thanks,

David McLaughlin

Re: Review Request 62451: Implement Role and Environment pages in Preact.

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62451/#review185937
-----------------------------------------------------------


Ship it!




Master (4137dd2) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Sept. 21, 2017, 11:17 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62451/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2017, 11:17 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Kai Huang, and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implement Role and Environment pages in Preact. The color scheme and other design elements aren't final yet - the plan is to wait until the structure is all in place and then go back and style things. 
> 
> Major difference from the current UI is the use of color to visualize the task states and the move away from the table format of the data.
> 
> 
> Diffs
> -----
> 
>   ui/src/main/js/components/JobList.js PRE-CREATION 
>   ui/src/main/js/components/Layout.js PRE-CREATION 
>   ui/src/main/js/components/RoleQuota.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/JobList-test.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/RoleQuota-test.js PRE-CREATION 
>   ui/src/main/js/index.js 717aaa080d1365785a603ed7d1ece69efdaafec7 
>   ui/src/main/js/pages/Jobs.js PRE-CREATION 
>   ui/src/main/js/pages/__tests__/Jobs-test.js PRE-CREATION 
>   ui/src/main/js/utils/Common.js PRE-CREATION 
>   ui/src/main/sass/app.scss 0b3967d39ed443eaf5bfadb473816135e0a978e4 
>   ui/src/main/sass/components/_job-list-page.scss PRE-CREATION 
>   ui/src/main/sass/components/_layout.scss b8a83b585fcef11964dc8349703ad453d37b5d2d 
>   ui/src/main/sass/components/_tables.scss 58f176cffcdae34de7c776e31b3f0342efa3024f 
>   ui/src/main/sass/modules/_colors.scss 147cff691058972aebc5f79f22955cf2448ce48c 
> 
> 
> Diff: https://reviews.apache.org/r/62451/diff/1/
> 
> 
> Testing
> -------
> 
> ./gradlew ui:test
> ./gradlew ui:lint
> 
> See screenshot for local development with some Twitter data.
> 
> 
> File Attachments
> ----------------
> 
> Screenshot 
>   https://reviews.apache.org/media/uploaded/files/2017/09/21/684d8630-a9b4-4fbf-8955-a7fc118afcce__Screen_Shot_2017-09-21_at_4.11.05_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 62451: Implement Role and Environment pages in Preact.

Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.

> On Sept. 25, 2017, 5:27 p.m., Santhosh Kumar Shanmugham wrote:
> > ui/src/main/js/components/JobList.js
> > Lines 97 (patched)
> > <https://reviews.apache.org/r/62451/diff/1/?file=1832476#file1832476line97>
> >
> >     It is possible for clusters to have customer tier configuration. Should we make this read that configuration?
> >     
> >     http://aurora.apache.org/documentation/latest/features/multitenancy/
> 
> David McLaughlin wrote:
>     Maybe in a future patch (although I'd question the value tbh). I'll just keep parity with the existing UI for now.

I'm just worried about the hardcoding of `preferred` here, since different clusters could have different tier names.

In the old UI the tier is never used while displaying the summary - https://github.com/apache/aurora/blob/c85bffdd6f68312261697eee868d57069adda434/src/main/resources/scheduler/assets/js/controllers.js#L134-L142


- Santhosh Kumar


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62451/#review186169
-----------------------------------------------------------


On Sept. 27, 2017, 5:18 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62451/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2017, 5:18 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Kai Huang, and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implement Role and Environment pages in Preact. The color scheme and other design elements aren't final yet - the plan is to wait until the structure is all in place and then go back and style things. 
> 
> Major difference from the current UI is the use of color to visualize the task states and the move away from the table format of the data.
> 
> 
> Diffs
> -----
> 
>   ui/src/main/js/components/JobList.js PRE-CREATION 
>   ui/src/main/js/components/JobListItem.js PRE-CREATION 
>   ui/src/main/js/components/Layout.js PRE-CREATION 
>   ui/src/main/js/components/Pagination.js dec89be93d531f755097ac8b3ee48d643d31262f 
>   ui/src/main/js/components/RoleQuota.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/JobList-test.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/RoleQuota-test.js PRE-CREATION 
>   ui/src/main/js/index.js 717aaa080d1365785a603ed7d1ece69efdaafec7 
>   ui/src/main/js/pages/Jobs.js PRE-CREATION 
>   ui/src/main/js/pages/__tests__/Jobs-test.js PRE-CREATION 
>   ui/src/main/js/utils/Common.js PRE-CREATION 
>   ui/src/main/js/utils/Job.js PRE-CREATION 
>   ui/src/main/sass/app.scss 0b3967d39ed443eaf5bfadb473816135e0a978e4 
>   ui/src/main/sass/components/_job-list-page.scss PRE-CREATION 
>   ui/src/main/sass/components/_layout.scss b8a83b585fcef11964dc8349703ad453d37b5d2d 
>   ui/src/main/sass/components/_tables.scss 2ea60bc64ccb2b556ef6edf25016f6a01cd075f6 
>   ui/src/main/sass/modules/_colors.scss 147cff691058972aebc5f79f22955cf2448ce48c 
> 
> 
> Diff: https://reviews.apache.org/r/62451/diff/3/
> 
> 
> Testing
> -------
> 
> ./gradlew ui:test
> ./gradlew ui:lint
> 
> See screenshot for local development with some Twitter data.
> 
> 
> File Attachments
> ----------------
> 
> Screenshot 
>   https://reviews.apache.org/media/uploaded/files/2017/09/21/684d8630-a9b4-4fbf-8955-a7fc118afcce__Screen_Shot_2017-09-21_at_4.11.05_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 62451: Implement Role and Environment pages in Preact.

Posted by David McLaughlin <da...@dmclaughlin.com>.

> On Sept. 26, 2017, 12:27 a.m., Santhosh Kumar Shanmugham wrote:
> > ui/src/main/js/components/JobList.js
> > Lines 15 (patched)
> > <https://reviews.apache.org/r/62451/diff/1/?file=1832476#file1832476line15>
> >
> >     nit - Can we use `k.replace('TaskCount', '')` here as well like below?

Done.


> On Sept. 26, 2017, 12:27 a.m., Santhosh Kumar Shanmugham wrote:
> > ui/src/main/js/components/JobList.js
> > Lines 97 (patched)
> > <https://reviews.apache.org/r/62451/diff/1/?file=1832476#file1832476line97>
> >
> >     It is possible for clusters to have customer tier configuration. Should we make this read that configuration?
> >     
> >     http://aurora.apache.org/documentation/latest/features/multitenancy/

Maybe in a future patch (although I'd question the value tbh). I'll just keep parity with the existing UI for now.


> On Sept. 26, 2017, 12:27 a.m., Santhosh Kumar Shanmugham wrote:
> > ui/src/main/js/components/RoleQuota.js
> > Lines 26 (patched)
> > <https://reviews.apache.org/r/62451/diff/1/?file=1832478#file1832478line26>
> >
> >     Wonder if we should show the usage as percentage and on the side indicate the absolute amount. Probably in a custom component. Not a blocker though.

Yeah, we can iterate on components. I think there's plenty of potential for quota display, but I just started with some basic improvements and we can add more later.


> On Sept. 26, 2017, 12:27 a.m., Santhosh Kumar Shanmugham wrote:
> > ui/src/main/js/components/RoleQuota.js
> > Lines 57 (patched)
> > <https://reviews.apache.org/r/62451/diff/1/?file=1832478#file1832478line57>
> >
> >     Curious - I do not get the intent of calling this `aurora-table`. Are you setting this up for something in the future?

No, it's just a name for a standard table style in the aurora UI.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62451/#review186169
-----------------------------------------------------------


On Sept. 21, 2017, 11:17 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62451/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2017, 11:17 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Kai Huang, and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implement Role and Environment pages in Preact. The color scheme and other design elements aren't final yet - the plan is to wait until the structure is all in place and then go back and style things. 
> 
> Major difference from the current UI is the use of color to visualize the task states and the move away from the table format of the data.
> 
> 
> Diffs
> -----
> 
>   ui/src/main/js/components/JobList.js PRE-CREATION 
>   ui/src/main/js/components/Layout.js PRE-CREATION 
>   ui/src/main/js/components/RoleQuota.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/JobList-test.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/RoleQuota-test.js PRE-CREATION 
>   ui/src/main/js/index.js 717aaa080d1365785a603ed7d1ece69efdaafec7 
>   ui/src/main/js/pages/Jobs.js PRE-CREATION 
>   ui/src/main/js/pages/__tests__/Jobs-test.js PRE-CREATION 
>   ui/src/main/js/utils/Common.js PRE-CREATION 
>   ui/src/main/sass/app.scss 0b3967d39ed443eaf5bfadb473816135e0a978e4 
>   ui/src/main/sass/components/_job-list-page.scss PRE-CREATION 
>   ui/src/main/sass/components/_layout.scss b8a83b585fcef11964dc8349703ad453d37b5d2d 
>   ui/src/main/sass/components/_tables.scss 58f176cffcdae34de7c776e31b3f0342efa3024f 
>   ui/src/main/sass/modules/_colors.scss 147cff691058972aebc5f79f22955cf2448ce48c 
> 
> 
> Diff: https://reviews.apache.org/r/62451/diff/1/
> 
> 
> Testing
> -------
> 
> ./gradlew ui:test
> ./gradlew ui:lint
> 
> See screenshot for local development with some Twitter data.
> 
> 
> File Attachments
> ----------------
> 
> Screenshot 
>   https://reviews.apache.org/media/uploaded/files/2017/09/21/684d8630-a9b4-4fbf-8955-a7fc118afcce__Screen_Shot_2017-09-21_at_4.11.05_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 62451: Implement Role and Environment pages in Preact.

Posted by David McLaughlin <da...@dmclaughlin.com>.

> On Sept. 26, 2017, 12:27 a.m., Santhosh Kumar Shanmugham wrote:
> > ui/src/main/js/components/JobList.js
> > Lines 97 (patched)
> > <https://reviews.apache.org/r/62451/diff/1/?file=1832476#file1832476line97>
> >
> >     It is possible for clusters to have customer tier configuration. Should we make this read that configuration?
> >     
> >     http://aurora.apache.org/documentation/latest/features/multitenancy/
> 
> David McLaughlin wrote:
>     Maybe in a future patch (although I'd question the value tbh). I'll just keep parity with the existing UI for now.
> 
> Santhosh Kumar Shanmugham wrote:
>     I'm just worried about the hardcoding of `preferred` here, since different clusters could have different tier names.
>     
>     In the old UI the tier is never used while displaying the summary - https://github.com/apache/aurora/blob/c85bffdd6f68312261697eee868d57069adda434/src/main/resources/scheduler/assets/js/controllers.js#L134-L142

You're right, I'll address.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62451/#review186169
-----------------------------------------------------------


On Sept. 28, 2017, 12:18 a.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62451/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2017, 12:18 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Kai Huang, and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implement Role and Environment pages in Preact. The color scheme and other design elements aren't final yet - the plan is to wait until the structure is all in place and then go back and style things. 
> 
> Major difference from the current UI is the use of color to visualize the task states and the move away from the table format of the data.
> 
> 
> Diffs
> -----
> 
>   ui/src/main/js/components/JobList.js PRE-CREATION 
>   ui/src/main/js/components/JobListItem.js PRE-CREATION 
>   ui/src/main/js/components/Layout.js PRE-CREATION 
>   ui/src/main/js/components/Pagination.js dec89be93d531f755097ac8b3ee48d643d31262f 
>   ui/src/main/js/components/RoleQuota.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/JobList-test.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/RoleQuota-test.js PRE-CREATION 
>   ui/src/main/js/index.js 717aaa080d1365785a603ed7d1ece69efdaafec7 
>   ui/src/main/js/pages/Jobs.js PRE-CREATION 
>   ui/src/main/js/pages/__tests__/Jobs-test.js PRE-CREATION 
>   ui/src/main/js/utils/Common.js PRE-CREATION 
>   ui/src/main/js/utils/Job.js PRE-CREATION 
>   ui/src/main/sass/app.scss 0b3967d39ed443eaf5bfadb473816135e0a978e4 
>   ui/src/main/sass/components/_job-list-page.scss PRE-CREATION 
>   ui/src/main/sass/components/_layout.scss b8a83b585fcef11964dc8349703ad453d37b5d2d 
>   ui/src/main/sass/components/_tables.scss 2ea60bc64ccb2b556ef6edf25016f6a01cd075f6 
>   ui/src/main/sass/modules/_colors.scss 147cff691058972aebc5f79f22955cf2448ce48c 
> 
> 
> Diff: https://reviews.apache.org/r/62451/diff/3/
> 
> 
> Testing
> -------
> 
> ./gradlew ui:test
> ./gradlew ui:lint
> 
> See screenshot for local development with some Twitter data.
> 
> 
> File Attachments
> ----------------
> 
> Screenshot 
>   https://reviews.apache.org/media/uploaded/files/2017/09/21/684d8630-a9b4-4fbf-8955-a7fc118afcce__Screen_Shot_2017-09-21_at_4.11.05_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 62451: Implement Role and Environment pages in Preact.

Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62451/#review186169
-----------------------------------------------------------



Mostly looks good to me. I have not reviewed the tests since they will be rewritten.


ui/src/main/js/components/JobList.js
Lines 15 (patched)
<https://reviews.apache.org/r/62451/#comment262618>

    nit - Can we use `k.replace('TaskCount', '')` here as well like below?



ui/src/main/js/components/JobList.js
Lines 97 (patched)
<https://reviews.apache.org/r/62451/#comment262626>

    It is possible for clusters to have customer tier configuration. Should we make this read that configuration?
    
    http://aurora.apache.org/documentation/latest/features/multitenancy/



ui/src/main/js/components/RoleQuota.js
Lines 26 (patched)
<https://reviews.apache.org/r/62451/#comment262628>

    Wonder if we should show the usage as percentage and on the side indicate the absolute amount. Probably in a custom component. Not a blocker though.



ui/src/main/js/components/RoleQuota.js
Lines 57 (patched)
<https://reviews.apache.org/r/62451/#comment262636>

    Curious - I do not get the intent of calling this `aurora-table`. Are you setting this up for something in the future?


- Santhosh Kumar Shanmugham


On Sept. 21, 2017, 4:17 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62451/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2017, 4:17 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Kai Huang, and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implement Role and Environment pages in Preact. The color scheme and other design elements aren't final yet - the plan is to wait until the structure is all in place and then go back and style things. 
> 
> Major difference from the current UI is the use of color to visualize the task states and the move away from the table format of the data.
> 
> 
> Diffs
> -----
> 
>   ui/src/main/js/components/JobList.js PRE-CREATION 
>   ui/src/main/js/components/Layout.js PRE-CREATION 
>   ui/src/main/js/components/RoleQuota.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/JobList-test.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/RoleQuota-test.js PRE-CREATION 
>   ui/src/main/js/index.js 717aaa080d1365785a603ed7d1ece69efdaafec7 
>   ui/src/main/js/pages/Jobs.js PRE-CREATION 
>   ui/src/main/js/pages/__tests__/Jobs-test.js PRE-CREATION 
>   ui/src/main/js/utils/Common.js PRE-CREATION 
>   ui/src/main/sass/app.scss 0b3967d39ed443eaf5bfadb473816135e0a978e4 
>   ui/src/main/sass/components/_job-list-page.scss PRE-CREATION 
>   ui/src/main/sass/components/_layout.scss b8a83b585fcef11964dc8349703ad453d37b5d2d 
>   ui/src/main/sass/components/_tables.scss 58f176cffcdae34de7c776e31b3f0342efa3024f 
>   ui/src/main/sass/modules/_colors.scss 147cff691058972aebc5f79f22955cf2448ce48c 
> 
> 
> Diff: https://reviews.apache.org/r/62451/diff/1/
> 
> 
> Testing
> -------
> 
> ./gradlew ui:test
> ./gradlew ui:lint
> 
> See screenshot for local development with some Twitter data.
> 
> 
> File Attachments
> ----------------
> 
> Screenshot 
>   https://reviews.apache.org/media/uploaded/files/2017/09/21/684d8630-a9b4-4fbf-8955-a7fc118afcce__Screen_Shot_2017-09-21_at_4.11.05_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 62451: Implement Role and Environment pages in Preact.

Posted by David McLaughlin <da...@dmclaughlin.com>.

> On Sept. 25, 2017, 5:40 p.m., Kai Huang wrote:
> > ui/src/main/js/components/RoleQuota.js
> > Lines 70 (patched)
> > <https://reviews.apache.org/r/62451/diff/1/?file=1832478#file1832478line70>
> >
> >     From the user perspective, a pie chart for the resource utilization would be much easier to consume.

As I mentioned below, this can be a follow-up. I tried various things with quota and didn't like the results. I'm keeping it simple for now in order to finish the migration and unblock others from contributing their ideas.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62451/#review186142
-----------------------------------------------------------


On Sept. 21, 2017, 11:17 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62451/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2017, 11:17 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Kai Huang, and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implement Role and Environment pages in Preact. The color scheme and other design elements aren't final yet - the plan is to wait until the structure is all in place and then go back and style things. 
> 
> Major difference from the current UI is the use of color to visualize the task states and the move away from the table format of the data.
> 
> 
> Diffs
> -----
> 
>   ui/src/main/js/components/JobList.js PRE-CREATION 
>   ui/src/main/js/components/Layout.js PRE-CREATION 
>   ui/src/main/js/components/RoleQuota.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/JobList-test.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/RoleQuota-test.js PRE-CREATION 
>   ui/src/main/js/index.js 717aaa080d1365785a603ed7d1ece69efdaafec7 
>   ui/src/main/js/pages/Jobs.js PRE-CREATION 
>   ui/src/main/js/pages/__tests__/Jobs-test.js PRE-CREATION 
>   ui/src/main/js/utils/Common.js PRE-CREATION 
>   ui/src/main/sass/app.scss 0b3967d39ed443eaf5bfadb473816135e0a978e4 
>   ui/src/main/sass/components/_job-list-page.scss PRE-CREATION 
>   ui/src/main/sass/components/_layout.scss b8a83b585fcef11964dc8349703ad453d37b5d2d 
>   ui/src/main/sass/components/_tables.scss 58f176cffcdae34de7c776e31b3f0342efa3024f 
>   ui/src/main/sass/modules/_colors.scss 147cff691058972aebc5f79f22955cf2448ce48c 
> 
> 
> Diff: https://reviews.apache.org/r/62451/diff/1/
> 
> 
> Testing
> -------
> 
> ./gradlew ui:test
> ./gradlew ui:lint
> 
> See screenshot for local development with some Twitter data.
> 
> 
> File Attachments
> ----------------
> 
> Screenshot 
>   https://reviews.apache.org/media/uploaded/files/2017/09/21/684d8630-a9b4-4fbf-8955-a7fc118afcce__Screen_Shot_2017-09-21_at_4.11.05_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 62451: Implement Role and Environment pages in Preact.

Posted by Kai Huang <te...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62451/#review186142
-----------------------------------------------------------




ui/src/main/js/components/RoleQuota.js
Lines 70 (patched)
<https://reviews.apache.org/r/62451/#comment262575>

    From the user perspective, a pie chart for the resource utilization would be much easier to consume.


- Kai Huang


On Sept. 21, 2017, 11:17 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62451/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2017, 11:17 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Kai Huang, and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implement Role and Environment pages in Preact. The color scheme and other design elements aren't final yet - the plan is to wait until the structure is all in place and then go back and style things. 
> 
> Major difference from the current UI is the use of color to visualize the task states and the move away from the table format of the data.
> 
> 
> Diffs
> -----
> 
>   ui/src/main/js/components/JobList.js PRE-CREATION 
>   ui/src/main/js/components/Layout.js PRE-CREATION 
>   ui/src/main/js/components/RoleQuota.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/JobList-test.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/RoleQuota-test.js PRE-CREATION 
>   ui/src/main/js/index.js 717aaa080d1365785a603ed7d1ece69efdaafec7 
>   ui/src/main/js/pages/Jobs.js PRE-CREATION 
>   ui/src/main/js/pages/__tests__/Jobs-test.js PRE-CREATION 
>   ui/src/main/js/utils/Common.js PRE-CREATION 
>   ui/src/main/sass/app.scss 0b3967d39ed443eaf5bfadb473816135e0a978e4 
>   ui/src/main/sass/components/_job-list-page.scss PRE-CREATION 
>   ui/src/main/sass/components/_layout.scss b8a83b585fcef11964dc8349703ad453d37b5d2d 
>   ui/src/main/sass/components/_tables.scss 58f176cffcdae34de7c776e31b3f0342efa3024f 
>   ui/src/main/sass/modules/_colors.scss 147cff691058972aebc5f79f22955cf2448ce48c 
> 
> 
> Diff: https://reviews.apache.org/r/62451/diff/1/
> 
> 
> Testing
> -------
> 
> ./gradlew ui:test
> ./gradlew ui:lint
> 
> See screenshot for local development with some Twitter data.
> 
> 
> File Attachments
> ----------------
> 
> Screenshot 
>   https://reviews.apache.org/media/uploaded/files/2017/09/21/684d8630-a9b4-4fbf-8955-a7fc118afcce__Screen_Shot_2017-09-21_at_4.11.05_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 62451: Implement Role and Environment pages in Preact.

Posted by Reza Motamedi <re...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62451/#review186188
-----------------------------------------------------------




ui/src/main/js/components/RoleQuota.js
Lines 70 (patched)
<https://reviews.apache.org/r/62451/#comment262648>

    That would be nice, but a pie with only two colors sounds overkill. I like it the way it is.


- Reza Motamedi


On Sept. 21, 2017, 11:17 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62451/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2017, 11:17 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Kai Huang, and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implement Role and Environment pages in Preact. The color scheme and other design elements aren't final yet - the plan is to wait until the structure is all in place and then go back and style things. 
> 
> Major difference from the current UI is the use of color to visualize the task states and the move away from the table format of the data.
> 
> 
> Diffs
> -----
> 
>   ui/src/main/js/components/JobList.js PRE-CREATION 
>   ui/src/main/js/components/Layout.js PRE-CREATION 
>   ui/src/main/js/components/RoleQuota.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/JobList-test.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/RoleQuota-test.js PRE-CREATION 
>   ui/src/main/js/index.js 717aaa080d1365785a603ed7d1ece69efdaafec7 
>   ui/src/main/js/pages/Jobs.js PRE-CREATION 
>   ui/src/main/js/pages/__tests__/Jobs-test.js PRE-CREATION 
>   ui/src/main/js/utils/Common.js PRE-CREATION 
>   ui/src/main/sass/app.scss 0b3967d39ed443eaf5bfadb473816135e0a978e4 
>   ui/src/main/sass/components/_job-list-page.scss PRE-CREATION 
>   ui/src/main/sass/components/_layout.scss b8a83b585fcef11964dc8349703ad453d37b5d2d 
>   ui/src/main/sass/components/_tables.scss 58f176cffcdae34de7c776e31b3f0342efa3024f 
>   ui/src/main/sass/modules/_colors.scss 147cff691058972aebc5f79f22955cf2448ce48c 
> 
> 
> Diff: https://reviews.apache.org/r/62451/diff/1/
> 
> 
> Testing
> -------
> 
> ./gradlew ui:test
> ./gradlew ui:lint
> 
> See screenshot for local development with some Twitter data.
> 
> 
> File Attachments
> ----------------
> 
> Screenshot 
>   https://reviews.apache.org/media/uploaded/files/2017/09/21/684d8630-a9b4-4fbf-8955-a7fc118afcce__Screen_Shot_2017-09-21_at_4.11.05_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 62451: Implement Role and Environment pages in Preact.

Posted by Kai Huang <te...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62451/#review186511
-----------------------------------------------------------


Ship it!




LGTM

- Kai Huang


On Sept. 28, 2017, 12:18 a.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62451/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2017, 12:18 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Kai Huang, and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implement Role and Environment pages in Preact. The color scheme and other design elements aren't final yet - the plan is to wait until the structure is all in place and then go back and style things. 
> 
> Major difference from the current UI is the use of color to visualize the task states and the move away from the table format of the data.
> 
> 
> Diffs
> -----
> 
>   ui/src/main/js/components/JobList.js PRE-CREATION 
>   ui/src/main/js/components/JobListItem.js PRE-CREATION 
>   ui/src/main/js/components/Layout.js PRE-CREATION 
>   ui/src/main/js/components/Pagination.js dec89be93d531f755097ac8b3ee48d643d31262f 
>   ui/src/main/js/components/RoleQuota.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/JobList-test.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/RoleQuota-test.js PRE-CREATION 
>   ui/src/main/js/index.js 717aaa080d1365785a603ed7d1ece69efdaafec7 
>   ui/src/main/js/pages/Jobs.js PRE-CREATION 
>   ui/src/main/js/pages/__tests__/Jobs-test.js PRE-CREATION 
>   ui/src/main/js/utils/Common.js PRE-CREATION 
>   ui/src/main/js/utils/Job.js PRE-CREATION 
>   ui/src/main/sass/app.scss 0b3967d39ed443eaf5bfadb473816135e0a978e4 
>   ui/src/main/sass/components/_job-list-page.scss PRE-CREATION 
>   ui/src/main/sass/components/_layout.scss b8a83b585fcef11964dc8349703ad453d37b5d2d 
>   ui/src/main/sass/components/_tables.scss 2ea60bc64ccb2b556ef6edf25016f6a01cd075f6 
>   ui/src/main/sass/modules/_colors.scss 147cff691058972aebc5f79f22955cf2448ce48c 
> 
> 
> Diff: https://reviews.apache.org/r/62451/diff/3/
> 
> 
> Testing
> -------
> 
> ./gradlew ui:test
> ./gradlew ui:lint
> 
> See screenshot for local development with some Twitter data.
> 
> 
> File Attachments
> ----------------
> 
> Screenshot 
>   https://reviews.apache.org/media/uploaded/files/2017/09/21/684d8630-a9b4-4fbf-8955-a7fc118afcce__Screen_Shot_2017-09-21_at_4.11.05_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 62451: Implement Role and Environment pages in Preact.

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62451/#review186514
-----------------------------------------------------------


Ship it!




Master (7c78519) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Sept. 28, 2017, 12:18 a.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62451/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2017, 12:18 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Kai Huang, and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implement Role and Environment pages in Preact. The color scheme and other design elements aren't final yet - the plan is to wait until the structure is all in place and then go back and style things. 
> 
> Major difference from the current UI is the use of color to visualize the task states and the move away from the table format of the data.
> 
> 
> Diffs
> -----
> 
>   ui/src/main/js/components/JobList.js PRE-CREATION 
>   ui/src/main/js/components/JobListItem.js PRE-CREATION 
>   ui/src/main/js/components/Layout.js PRE-CREATION 
>   ui/src/main/js/components/Pagination.js dec89be93d531f755097ac8b3ee48d643d31262f 
>   ui/src/main/js/components/RoleQuota.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/JobList-test.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/RoleQuota-test.js PRE-CREATION 
>   ui/src/main/js/index.js 717aaa080d1365785a603ed7d1ece69efdaafec7 
>   ui/src/main/js/pages/Jobs.js PRE-CREATION 
>   ui/src/main/js/pages/__tests__/Jobs-test.js PRE-CREATION 
>   ui/src/main/js/utils/Common.js PRE-CREATION 
>   ui/src/main/js/utils/Job.js PRE-CREATION 
>   ui/src/main/sass/app.scss 0b3967d39ed443eaf5bfadb473816135e0a978e4 
>   ui/src/main/sass/components/_job-list-page.scss PRE-CREATION 
>   ui/src/main/sass/components/_layout.scss b8a83b585fcef11964dc8349703ad453d37b5d2d 
>   ui/src/main/sass/components/_tables.scss 2ea60bc64ccb2b556ef6edf25016f6a01cd075f6 
>   ui/src/main/sass/modules/_colors.scss 147cff691058972aebc5f79f22955cf2448ce48c 
> 
> 
> Diff: https://reviews.apache.org/r/62451/diff/3/
> 
> 
> Testing
> -------
> 
> ./gradlew ui:test
> ./gradlew ui:lint
> 
> See screenshot for local development with some Twitter data.
> 
> 
> File Attachments
> ----------------
> 
> Screenshot 
>   https://reviews.apache.org/media/uploaded/files/2017/09/21/684d8630-a9b4-4fbf-8955-a7fc118afcce__Screen_Shot_2017-09-21_at_4.11.05_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 62451: Implement Role and Environment pages in Preact.

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62451/#review186810
-----------------------------------------------------------


Ship it!




Master (6fd6d50) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Oct. 1, 2017, 9:12 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62451/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2017, 9:12 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Kai Huang, and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implement Role and Environment pages in Preact. The color scheme and other design elements aren't final yet - the plan is to wait until the structure is all in place and then go back and style things. 
> 
> Major difference from the current UI is the use of color to visualize the task states and the move away from the table format of the data.
> 
> 
> Diffs
> -----
> 
>   ui/src/main/js/components/JobList.js PRE-CREATION 
>   ui/src/main/js/components/JobListItem.js PRE-CREATION 
>   ui/src/main/js/components/Layout.js PRE-CREATION 
>   ui/src/main/js/components/Pagination.js dec89be93d531f755097ac8b3ee48d643d31262f 
>   ui/src/main/js/components/RoleQuota.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/JobList-test.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/RoleQuota-test.js PRE-CREATION 
>   ui/src/main/js/index.js 717aaa080d1365785a603ed7d1ece69efdaafec7 
>   ui/src/main/js/pages/Jobs.js PRE-CREATION 
>   ui/src/main/js/pages/__tests__/Jobs-test.js PRE-CREATION 
>   ui/src/main/js/utils/Common.js PRE-CREATION 
>   ui/src/main/js/utils/Job.js PRE-CREATION 
>   ui/src/main/sass/app.scss 0b3967d39ed443eaf5bfadb473816135e0a978e4 
>   ui/src/main/sass/components/_job-list-page.scss PRE-CREATION 
>   ui/src/main/sass/components/_layout.scss b8a83b585fcef11964dc8349703ad453d37b5d2d 
>   ui/src/main/sass/components/_tables.scss 2ea60bc64ccb2b556ef6edf25016f6a01cd075f6 
>   ui/src/main/sass/modules/_colors.scss 147cff691058972aebc5f79f22955cf2448ce48c 
> 
> 
> Diff: https://reviews.apache.org/r/62451/diff/4/
> 
> 
> Testing
> -------
> 
> ./gradlew ui:test
> ./gradlew ui:lint
> 
> See screenshot for local development with some Twitter data.
> 
> 
> File Attachments
> ----------------
> 
> Screenshot 
>   https://reviews.apache.org/media/uploaded/files/2017/09/21/684d8630-a9b4-4fbf-8955-a7fc118afcce__Screen_Shot_2017-09-21_at_4.11.05_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 62451: Implement Role and Environment pages in Preact.

Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.

> On Oct. 2, 2017, 5:37 p.m., Santhosh Kumar Shanmugham wrote:
> > Ship It!

Please update the logic for checking tiers.


- Santhosh Kumar


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62451/#review186919
-----------------------------------------------------------


On Oct. 1, 2017, 2:12 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62451/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2017, 2:12 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Kai Huang, and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implement Role and Environment pages in Preact. The color scheme and other design elements aren't final yet - the plan is to wait until the structure is all in place and then go back and style things. 
> 
> Major difference from the current UI is the use of color to visualize the task states and the move away from the table format of the data.
> 
> 
> Diffs
> -----
> 
>   ui/src/main/js/components/JobList.js PRE-CREATION 
>   ui/src/main/js/components/JobListItem.js PRE-CREATION 
>   ui/src/main/js/components/Layout.js PRE-CREATION 
>   ui/src/main/js/components/Pagination.js dec89be93d531f755097ac8b3ee48d643d31262f 
>   ui/src/main/js/components/RoleQuota.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/JobList-test.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/RoleQuota-test.js PRE-CREATION 
>   ui/src/main/js/index.js 717aaa080d1365785a603ed7d1ece69efdaafec7 
>   ui/src/main/js/pages/Jobs.js PRE-CREATION 
>   ui/src/main/js/pages/__tests__/Jobs-test.js PRE-CREATION 
>   ui/src/main/js/utils/Common.js PRE-CREATION 
>   ui/src/main/js/utils/Job.js PRE-CREATION 
>   ui/src/main/sass/app.scss 0b3967d39ed443eaf5bfadb473816135e0a978e4 
>   ui/src/main/sass/components/_job-list-page.scss PRE-CREATION 
>   ui/src/main/sass/components/_layout.scss b8a83b585fcef11964dc8349703ad453d37b5d2d 
>   ui/src/main/sass/components/_tables.scss 2ea60bc64ccb2b556ef6edf25016f6a01cd075f6 
>   ui/src/main/sass/modules/_colors.scss 147cff691058972aebc5f79f22955cf2448ce48c 
> 
> 
> Diff: https://reviews.apache.org/r/62451/diff/4/
> 
> 
> Testing
> -------
> 
> ./gradlew ui:test
> ./gradlew ui:lint
> 
> See screenshot for local development with some Twitter data.
> 
> 
> File Attachments
> ----------------
> 
> Screenshot 
>   https://reviews.apache.org/media/uploaded/files/2017/09/21/684d8630-a9b4-4fbf-8955-a7fc118afcce__Screen_Shot_2017-09-21_at_4.11.05_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 62451: Implement Role and Environment pages in Preact.

Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62451/#review186919
-----------------------------------------------------------


Ship it!




Ship It!

- Santhosh Kumar Shanmugham


On Oct. 1, 2017, 2:12 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62451/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2017, 2:12 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Kai Huang, and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implement Role and Environment pages in Preact. The color scheme and other design elements aren't final yet - the plan is to wait until the structure is all in place and then go back and style things. 
> 
> Major difference from the current UI is the use of color to visualize the task states and the move away from the table format of the data.
> 
> 
> Diffs
> -----
> 
>   ui/src/main/js/components/JobList.js PRE-CREATION 
>   ui/src/main/js/components/JobListItem.js PRE-CREATION 
>   ui/src/main/js/components/Layout.js PRE-CREATION 
>   ui/src/main/js/components/Pagination.js dec89be93d531f755097ac8b3ee48d643d31262f 
>   ui/src/main/js/components/RoleQuota.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/JobList-test.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/RoleQuota-test.js PRE-CREATION 
>   ui/src/main/js/index.js 717aaa080d1365785a603ed7d1ece69efdaafec7 
>   ui/src/main/js/pages/Jobs.js PRE-CREATION 
>   ui/src/main/js/pages/__tests__/Jobs-test.js PRE-CREATION 
>   ui/src/main/js/utils/Common.js PRE-CREATION 
>   ui/src/main/js/utils/Job.js PRE-CREATION 
>   ui/src/main/sass/app.scss 0b3967d39ed443eaf5bfadb473816135e0a978e4 
>   ui/src/main/sass/components/_job-list-page.scss PRE-CREATION 
>   ui/src/main/sass/components/_layout.scss b8a83b585fcef11964dc8349703ad453d37b5d2d 
>   ui/src/main/sass/components/_tables.scss 2ea60bc64ccb2b556ef6edf25016f6a01cd075f6 
>   ui/src/main/sass/modules/_colors.scss 147cff691058972aebc5f79f22955cf2448ce48c 
> 
> 
> Diff: https://reviews.apache.org/r/62451/diff/4/
> 
> 
> Testing
> -------
> 
> ./gradlew ui:test
> ./gradlew ui:lint
> 
> See screenshot for local development with some Twitter data.
> 
> 
> File Attachments
> ----------------
> 
> Screenshot 
>   https://reviews.apache.org/media/uploaded/files/2017/09/21/684d8630-a9b4-4fbf-8955-a7fc118afcce__Screen_Shot_2017-09-21_at_4.11.05_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 62451: Implement Role and Environment pages in Preact.

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62451/#review186995
-----------------------------------------------------------


Ship it!




Master (6fd6d50) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Oct. 3, 2017, 7:42 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62451/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2017, 7:42 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Kai Huang, and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implement Role and Environment pages in Preact. The color scheme and other design elements aren't final yet - the plan is to wait until the structure is all in place and then go back and style things. 
> 
> Major difference from the current UI is the use of color to visualize the task states and the move away from the table format of the data.
> 
> 
> Diffs
> -----
> 
>   ui/src/main/js/components/JobList.js PRE-CREATION 
>   ui/src/main/js/components/JobListItem.js PRE-CREATION 
>   ui/src/main/js/components/Layout.js PRE-CREATION 
>   ui/src/main/js/components/Pagination.js dec89be93d531f755097ac8b3ee48d643d31262f 
>   ui/src/main/js/components/RoleQuota.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/JobList-test.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/RoleQuota-test.js PRE-CREATION 
>   ui/src/main/js/index.js 717aaa080d1365785a603ed7d1ece69efdaafec7 
>   ui/src/main/js/pages/Jobs.js PRE-CREATION 
>   ui/src/main/js/pages/__tests__/Jobs-test.js PRE-CREATION 
>   ui/src/main/js/utils/Common.js PRE-CREATION 
>   ui/src/main/js/utils/Job.js PRE-CREATION 
>   ui/src/main/sass/app.scss 0b3967d39ed443eaf5bfadb473816135e0a978e4 
>   ui/src/main/sass/components/_job-list-page.scss PRE-CREATION 
>   ui/src/main/sass/components/_layout.scss b8a83b585fcef11964dc8349703ad453d37b5d2d 
>   ui/src/main/sass/components/_tables.scss 2ea60bc64ccb2b556ef6edf25016f6a01cd075f6 
>   ui/src/main/sass/modules/_colors.scss 147cff691058972aebc5f79f22955cf2448ce48c 
> 
> 
> Diff: https://reviews.apache.org/r/62451/diff/5/
> 
> 
> Testing
> -------
> 
> ./gradlew ui:test
> ./gradlew ui:lint
> 
> See screenshot for local development with some Twitter data.
> 
> 
> File Attachments
> ----------------
> 
> Screenshot 
>   https://reviews.apache.org/media/uploaded/files/2017/09/21/684d8630-a9b4-4fbf-8955-a7fc118afcce__Screen_Shot_2017-09-21_at_4.11.05_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 62451: Implement Role and Environment pages in Preact.

Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62451/
-----------------------------------------------------------

(Updated Oct. 3, 2017, 7:42 p.m.)


Review request for Aurora, Joshua Cohen, Kai Huang, and Santhosh Kumar Shanmugham.


Changes
-------

Use production for stars, not tier.


Repository: aurora


Description
-------

Implement Role and Environment pages in Preact. The color scheme and other design elements aren't final yet - the plan is to wait until the structure is all in place and then go back and style things. 

Major difference from the current UI is the use of color to visualize the task states and the move away from the table format of the data.


Diffs (updated)
-----

  ui/src/main/js/components/JobList.js PRE-CREATION 
  ui/src/main/js/components/JobListItem.js PRE-CREATION 
  ui/src/main/js/components/Layout.js PRE-CREATION 
  ui/src/main/js/components/Pagination.js dec89be93d531f755097ac8b3ee48d643d31262f 
  ui/src/main/js/components/RoleQuota.js PRE-CREATION 
  ui/src/main/js/components/__tests__/JobList-test.js PRE-CREATION 
  ui/src/main/js/components/__tests__/RoleQuota-test.js PRE-CREATION 
  ui/src/main/js/index.js 717aaa080d1365785a603ed7d1ece69efdaafec7 
  ui/src/main/js/pages/Jobs.js PRE-CREATION 
  ui/src/main/js/pages/__tests__/Jobs-test.js PRE-CREATION 
  ui/src/main/js/utils/Common.js PRE-CREATION 
  ui/src/main/js/utils/Job.js PRE-CREATION 
  ui/src/main/sass/app.scss 0b3967d39ed443eaf5bfadb473816135e0a978e4 
  ui/src/main/sass/components/_job-list-page.scss PRE-CREATION 
  ui/src/main/sass/components/_layout.scss b8a83b585fcef11964dc8349703ad453d37b5d2d 
  ui/src/main/sass/components/_tables.scss 2ea60bc64ccb2b556ef6edf25016f6a01cd075f6 
  ui/src/main/sass/modules/_colors.scss 147cff691058972aebc5f79f22955cf2448ce48c 


Diff: https://reviews.apache.org/r/62451/diff/5/

Changes: https://reviews.apache.org/r/62451/diff/4-5/


Testing
-------

./gradlew ui:test
./gradlew ui:lint

See screenshot for local development with some Twitter data.


File Attachments
----------------

Screenshot 
  https://reviews.apache.org/media/uploaded/files/2017/09/21/684d8630-a9b4-4fbf-8955-a7fc118afcce__Screen_Shot_2017-09-21_at_4.11.05_PM.png


Thanks,

David McLaughlin

Re: Review Request 62451: Implement Role and Environment pages in Preact.

Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62451/
-----------------------------------------------------------

(Updated Oct. 1, 2017, 9:12 p.m.)


Review request for Aurora, Joshua Cohen, Kai Huang, and Santhosh Kumar Shanmugham.


Changes
-------

Updated a comment in Pagination to reflect new React features.


Repository: aurora


Description
-------

Implement Role and Environment pages in Preact. The color scheme and other design elements aren't final yet - the plan is to wait until the structure is all in place and then go back and style things. 

Major difference from the current UI is the use of color to visualize the task states and the move away from the table format of the data.


Diffs (updated)
-----

  ui/src/main/js/components/JobList.js PRE-CREATION 
  ui/src/main/js/components/JobListItem.js PRE-CREATION 
  ui/src/main/js/components/Layout.js PRE-CREATION 
  ui/src/main/js/components/Pagination.js dec89be93d531f755097ac8b3ee48d643d31262f 
  ui/src/main/js/components/RoleQuota.js PRE-CREATION 
  ui/src/main/js/components/__tests__/JobList-test.js PRE-CREATION 
  ui/src/main/js/components/__tests__/RoleQuota-test.js PRE-CREATION 
  ui/src/main/js/index.js 717aaa080d1365785a603ed7d1ece69efdaafec7 
  ui/src/main/js/pages/Jobs.js PRE-CREATION 
  ui/src/main/js/pages/__tests__/Jobs-test.js PRE-CREATION 
  ui/src/main/js/utils/Common.js PRE-CREATION 
  ui/src/main/js/utils/Job.js PRE-CREATION 
  ui/src/main/sass/app.scss 0b3967d39ed443eaf5bfadb473816135e0a978e4 
  ui/src/main/sass/components/_job-list-page.scss PRE-CREATION 
  ui/src/main/sass/components/_layout.scss b8a83b585fcef11964dc8349703ad453d37b5d2d 
  ui/src/main/sass/components/_tables.scss 2ea60bc64ccb2b556ef6edf25016f6a01cd075f6 
  ui/src/main/sass/modules/_colors.scss 147cff691058972aebc5f79f22955cf2448ce48c 


Diff: https://reviews.apache.org/r/62451/diff/4/

Changes: https://reviews.apache.org/r/62451/diff/3-4/


Testing
-------

./gradlew ui:test
./gradlew ui:lint

See screenshot for local development with some Twitter data.


File Attachments
----------------

Screenshot 
  https://reviews.apache.org/media/uploaded/files/2017/09/21/684d8630-a9b4-4fbf-8955-a7fc118afcce__Screen_Shot_2017-09-21_at_4.11.05_PM.png


Thanks,

David McLaughlin

Re: Review Request 62451: Implement Role and Environment pages in Preact.

Posted by Reza Motamedi <re...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62451/#review186513
-----------------------------------------------------------


Ship it!




I just picked up a little bit of js. LGTM.

- Reza Motamedi


On Sept. 28, 2017, 12:18 a.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62451/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2017, 12:18 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Kai Huang, and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implement Role and Environment pages in Preact. The color scheme and other design elements aren't final yet - the plan is to wait until the structure is all in place and then go back and style things. 
> 
> Major difference from the current UI is the use of color to visualize the task states and the move away from the table format of the data.
> 
> 
> Diffs
> -----
> 
>   ui/src/main/js/components/JobList.js PRE-CREATION 
>   ui/src/main/js/components/JobListItem.js PRE-CREATION 
>   ui/src/main/js/components/Layout.js PRE-CREATION 
>   ui/src/main/js/components/Pagination.js dec89be93d531f755097ac8b3ee48d643d31262f 
>   ui/src/main/js/components/RoleQuota.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/JobList-test.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/RoleQuota-test.js PRE-CREATION 
>   ui/src/main/js/index.js 717aaa080d1365785a603ed7d1ece69efdaafec7 
>   ui/src/main/js/pages/Jobs.js PRE-CREATION 
>   ui/src/main/js/pages/__tests__/Jobs-test.js PRE-CREATION 
>   ui/src/main/js/utils/Common.js PRE-CREATION 
>   ui/src/main/js/utils/Job.js PRE-CREATION 
>   ui/src/main/sass/app.scss 0b3967d39ed443eaf5bfadb473816135e0a978e4 
>   ui/src/main/sass/components/_job-list-page.scss PRE-CREATION 
>   ui/src/main/sass/components/_layout.scss b8a83b585fcef11964dc8349703ad453d37b5d2d 
>   ui/src/main/sass/components/_tables.scss 2ea60bc64ccb2b556ef6edf25016f6a01cd075f6 
>   ui/src/main/sass/modules/_colors.scss 147cff691058972aebc5f79f22955cf2448ce48c 
> 
> 
> Diff: https://reviews.apache.org/r/62451/diff/3/
> 
> 
> Testing
> -------
> 
> ./gradlew ui:test
> ./gradlew ui:lint
> 
> See screenshot for local development with some Twitter data.
> 
> 
> File Attachments
> ----------------
> 
> Screenshot 
>   https://reviews.apache.org/media/uploaded/files/2017/09/21/684d8630-a9b4-4fbf-8955-a7fc118afcce__Screen_Shot_2017-09-21_at_4.11.05_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 62451: Implement Role and Environment pages in Preact.

Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62451/
-----------------------------------------------------------

(Updated Sept. 28, 2017, 12:18 a.m.)


Review request for Aurora, Joshua Cohen, Kai Huang, and Santhosh Kumar Shanmugham.


Changes
-------

Remove my local development API endpoint.


Repository: aurora


Description
-------

Implement Role and Environment pages in Preact. The color scheme and other design elements aren't final yet - the plan is to wait until the structure is all in place and then go back and style things. 

Major difference from the current UI is the use of color to visualize the task states and the move away from the table format of the data.


Diffs (updated)
-----

  ui/src/main/js/components/JobList.js PRE-CREATION 
  ui/src/main/js/components/JobListItem.js PRE-CREATION 
  ui/src/main/js/components/Layout.js PRE-CREATION 
  ui/src/main/js/components/Pagination.js dec89be93d531f755097ac8b3ee48d643d31262f 
  ui/src/main/js/components/RoleQuota.js PRE-CREATION 
  ui/src/main/js/components/__tests__/JobList-test.js PRE-CREATION 
  ui/src/main/js/components/__tests__/RoleQuota-test.js PRE-CREATION 
  ui/src/main/js/index.js 717aaa080d1365785a603ed7d1ece69efdaafec7 
  ui/src/main/js/pages/Jobs.js PRE-CREATION 
  ui/src/main/js/pages/__tests__/Jobs-test.js PRE-CREATION 
  ui/src/main/js/utils/Common.js PRE-CREATION 
  ui/src/main/js/utils/Job.js PRE-CREATION 
  ui/src/main/sass/app.scss 0b3967d39ed443eaf5bfadb473816135e0a978e4 
  ui/src/main/sass/components/_job-list-page.scss PRE-CREATION 
  ui/src/main/sass/components/_layout.scss b8a83b585fcef11964dc8349703ad453d37b5d2d 
  ui/src/main/sass/components/_tables.scss 2ea60bc64ccb2b556ef6edf25016f6a01cd075f6 
  ui/src/main/sass/modules/_colors.scss 147cff691058972aebc5f79f22955cf2448ce48c 


Diff: https://reviews.apache.org/r/62451/diff/3/

Changes: https://reviews.apache.org/r/62451/diff/2-3/


Testing
-------

./gradlew ui:test
./gradlew ui:lint

See screenshot for local development with some Twitter data.


File Attachments
----------------

Screenshot 
  https://reviews.apache.org/media/uploaded/files/2017/09/21/684d8630-a9b4-4fbf-8955-a7fc118afcce__Screen_Shot_2017-09-21_at_4.11.05_PM.png


Thanks,

David McLaughlin

Re: Review Request 62451: Implement Role and Environment pages in Preact.

Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62451/
-----------------------------------------------------------

(Updated Sept. 28, 2017, 12:17 a.m.)


Review request for Aurora, Joshua Cohen, Kai Huang, and Santhosh Kumar Shanmugham.


Changes
-------

There's a regression in enzyme compared to my shallow renderer (maybe my attempt wasn't so bad after all) that broke some of the mock API tests when there are multiple calls. When I tried to use mount instead of shallow rendering to test the network behavior, there was an issue rendering react-router links outside of a <Router>. So no longer possible to shallow render pages with multiple api points until I figure out workarounds. I don't feel like this should block this though.


Repository: aurora


Description
-------

Implement Role and Environment pages in Preact. The color scheme and other design elements aren't final yet - the plan is to wait until the structure is all in place and then go back and style things. 

Major difference from the current UI is the use of color to visualize the task states and the move away from the table format of the data.


Diffs (updated)
-----

  ui/src/main/js/client/scheduler-client.js 1c381086934dafa22a62d18e035f599fb2260e15 
  ui/src/main/js/components/JobList.js PRE-CREATION 
  ui/src/main/js/components/JobListItem.js PRE-CREATION 
  ui/src/main/js/components/Layout.js PRE-CREATION 
  ui/src/main/js/components/Pagination.js dec89be93d531f755097ac8b3ee48d643d31262f 
  ui/src/main/js/components/RoleQuota.js PRE-CREATION 
  ui/src/main/js/components/__tests__/JobList-test.js PRE-CREATION 
  ui/src/main/js/components/__tests__/RoleQuota-test.js PRE-CREATION 
  ui/src/main/js/index.js 717aaa080d1365785a603ed7d1ece69efdaafec7 
  ui/src/main/js/pages/Jobs.js PRE-CREATION 
  ui/src/main/js/pages/__tests__/Jobs-test.js PRE-CREATION 
  ui/src/main/js/utils/Common.js PRE-CREATION 
  ui/src/main/js/utils/Job.js PRE-CREATION 
  ui/src/main/sass/app.scss 0b3967d39ed443eaf5bfadb473816135e0a978e4 
  ui/src/main/sass/components/_job-list-page.scss PRE-CREATION 
  ui/src/main/sass/components/_layout.scss b8a83b585fcef11964dc8349703ad453d37b5d2d 
  ui/src/main/sass/components/_tables.scss 2ea60bc64ccb2b556ef6edf25016f6a01cd075f6 
  ui/src/main/sass/modules/_colors.scss 147cff691058972aebc5f79f22955cf2448ce48c 


Diff: https://reviews.apache.org/r/62451/diff/2/

Changes: https://reviews.apache.org/r/62451/diff/1-2/


Testing
-------

./gradlew ui:test
./gradlew ui:lint

See screenshot for local development with some Twitter data.


File Attachments
----------------

Screenshot 
  https://reviews.apache.org/media/uploaded/files/2017/09/21/684d8630-a9b4-4fbf-8955-a7fc118afcce__Screen_Shot_2017-09-21_at_4.11.05_PM.png


Thanks,

David McLaughlin

Re: Review Request 62451: Implement Role and Environment pages in Preact.

Posted by Kai Huang <te...@hotmail.com>.

> On Sept. 27, 2017, 12:15 a.m., Kai Huang wrote:
> > ui/src/main/js/index.js
> > Line 17 (original), 18 (patched)
> > <https://reviews.apache.org/r/62451/diff/1/?file=1832481#file1832481line18>
> >
> >     In the homepage, it seems the role link still points to the old role/environment page?
> >     ```
> >     <Link to={`/scheduler/${r.role}`}>{r.role}</Link>
> >     ```
> 
> David McLaughlin wrote:
>     If you're talking about code not in this review (i.e. RoleList) then that was fixed in another review.

Yes, saw that in the other review.


- Kai


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62451/#review186347
-----------------------------------------------------------


On Sept. 28, 2017, 12:18 a.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62451/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2017, 12:18 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Kai Huang, and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implement Role and Environment pages in Preact. The color scheme and other design elements aren't final yet - the plan is to wait until the structure is all in place and then go back and style things. 
> 
> Major difference from the current UI is the use of color to visualize the task states and the move away from the table format of the data.
> 
> 
> Diffs
> -----
> 
>   ui/src/main/js/components/JobList.js PRE-CREATION 
>   ui/src/main/js/components/JobListItem.js PRE-CREATION 
>   ui/src/main/js/components/Layout.js PRE-CREATION 
>   ui/src/main/js/components/Pagination.js dec89be93d531f755097ac8b3ee48d643d31262f 
>   ui/src/main/js/components/RoleQuota.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/JobList-test.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/RoleQuota-test.js PRE-CREATION 
>   ui/src/main/js/index.js 717aaa080d1365785a603ed7d1ece69efdaafec7 
>   ui/src/main/js/pages/Jobs.js PRE-CREATION 
>   ui/src/main/js/pages/__tests__/Jobs-test.js PRE-CREATION 
>   ui/src/main/js/utils/Common.js PRE-CREATION 
>   ui/src/main/js/utils/Job.js PRE-CREATION 
>   ui/src/main/sass/app.scss 0b3967d39ed443eaf5bfadb473816135e0a978e4 
>   ui/src/main/sass/components/_job-list-page.scss PRE-CREATION 
>   ui/src/main/sass/components/_layout.scss b8a83b585fcef11964dc8349703ad453d37b5d2d 
>   ui/src/main/sass/components/_tables.scss 2ea60bc64ccb2b556ef6edf25016f6a01cd075f6 
>   ui/src/main/sass/modules/_colors.scss 147cff691058972aebc5f79f22955cf2448ce48c 
> 
> 
> Diff: https://reviews.apache.org/r/62451/diff/3/
> 
> 
> Testing
> -------
> 
> ./gradlew ui:test
> ./gradlew ui:lint
> 
> See screenshot for local development with some Twitter data.
> 
> 
> File Attachments
> ----------------
> 
> Screenshot 
>   https://reviews.apache.org/media/uploaded/files/2017/09/21/684d8630-a9b4-4fbf-8955-a7fc118afcce__Screen_Shot_2017-09-21_at_4.11.05_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 62451: Implement Role and Environment pages in Preact.

Posted by David McLaughlin <da...@dmclaughlin.com>.

> On Sept. 27, 2017, 12:15 a.m., Kai Huang wrote:
> > ui/src/main/js/index.js
> > Line 17 (original), 18 (patched)
> > <https://reviews.apache.org/r/62451/diff/1/?file=1832481#file1832481line18>
> >
> >     In the homepage, it seems the role link still points to the old role/environment page?
> >     ```
> >     <Link to={`/scheduler/${r.role}`}>{r.role}</Link>
> >     ```

If you're talking about code not in this review (i.e. RoleList) then that was fixed in another review.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62451/#review186347
-----------------------------------------------------------


On Sept. 21, 2017, 11:17 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62451/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2017, 11:17 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Kai Huang, and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implement Role and Environment pages in Preact. The color scheme and other design elements aren't final yet - the plan is to wait until the structure is all in place and then go back and style things. 
> 
> Major difference from the current UI is the use of color to visualize the task states and the move away from the table format of the data.
> 
> 
> Diffs
> -----
> 
>   ui/src/main/js/components/JobList.js PRE-CREATION 
>   ui/src/main/js/components/Layout.js PRE-CREATION 
>   ui/src/main/js/components/RoleQuota.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/JobList-test.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/RoleQuota-test.js PRE-CREATION 
>   ui/src/main/js/index.js 717aaa080d1365785a603ed7d1ece69efdaafec7 
>   ui/src/main/js/pages/Jobs.js PRE-CREATION 
>   ui/src/main/js/pages/__tests__/Jobs-test.js PRE-CREATION 
>   ui/src/main/js/utils/Common.js PRE-CREATION 
>   ui/src/main/sass/app.scss 0b3967d39ed443eaf5bfadb473816135e0a978e4 
>   ui/src/main/sass/components/_job-list-page.scss PRE-CREATION 
>   ui/src/main/sass/components/_layout.scss b8a83b585fcef11964dc8349703ad453d37b5d2d 
>   ui/src/main/sass/components/_tables.scss 58f176cffcdae34de7c776e31b3f0342efa3024f 
>   ui/src/main/sass/modules/_colors.scss 147cff691058972aebc5f79f22955cf2448ce48c 
> 
> 
> Diff: https://reviews.apache.org/r/62451/diff/1/
> 
> 
> Testing
> -------
> 
> ./gradlew ui:test
> ./gradlew ui:lint
> 
> See screenshot for local development with some Twitter data.
> 
> 
> File Attachments
> ----------------
> 
> Screenshot 
>   https://reviews.apache.org/media/uploaded/files/2017/09/21/684d8630-a9b4-4fbf-8955-a7fc118afcce__Screen_Shot_2017-09-21_at_4.11.05_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 62451: Implement Role and Environment pages in Preact.

Posted by Kai Huang <te...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62451/#review186347
-----------------------------------------------------------




ui/src/main/js/index.js
Line 17 (original), 18 (patched)
<https://reviews.apache.org/r/62451/#comment262891>

    In the homepage, it seems the role link still points to the old role/environment page?
    ```
    <Link to={`/scheduler/${r.role}`}>{r.role}</Link>
    ```


- Kai Huang


On Sept. 21, 2017, 11:17 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62451/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2017, 11:17 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Kai Huang, and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implement Role and Environment pages in Preact. The color scheme and other design elements aren't final yet - the plan is to wait until the structure is all in place and then go back and style things. 
> 
> Major difference from the current UI is the use of color to visualize the task states and the move away from the table format of the data.
> 
> 
> Diffs
> -----
> 
>   ui/src/main/js/components/JobList.js PRE-CREATION 
>   ui/src/main/js/components/Layout.js PRE-CREATION 
>   ui/src/main/js/components/RoleQuota.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/JobList-test.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/RoleQuota-test.js PRE-CREATION 
>   ui/src/main/js/index.js 717aaa080d1365785a603ed7d1ece69efdaafec7 
>   ui/src/main/js/pages/Jobs.js PRE-CREATION 
>   ui/src/main/js/pages/__tests__/Jobs-test.js PRE-CREATION 
>   ui/src/main/js/utils/Common.js PRE-CREATION 
>   ui/src/main/sass/app.scss 0b3967d39ed443eaf5bfadb473816135e0a978e4 
>   ui/src/main/sass/components/_job-list-page.scss PRE-CREATION 
>   ui/src/main/sass/components/_layout.scss b8a83b585fcef11964dc8349703ad453d37b5d2d 
>   ui/src/main/sass/components/_tables.scss 58f176cffcdae34de7c776e31b3f0342efa3024f 
>   ui/src/main/sass/modules/_colors.scss 147cff691058972aebc5f79f22955cf2448ce48c 
> 
> 
> Diff: https://reviews.apache.org/r/62451/diff/1/
> 
> 
> Testing
> -------
> 
> ./gradlew ui:test
> ./gradlew ui:lint
> 
> See screenshot for local development with some Twitter data.
> 
> 
> File Attachments
> ----------------
> 
> Screenshot 
>   https://reviews.apache.org/media/uploaded/files/2017/09/21/684d8630-a9b4-4fbf-8955-a7fc118afcce__Screen_Shot_2017-09-21_at_4.11.05_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>