You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/21 13:39:33 UTC
[GitHub] [spark] cloud-fan commented on a change in pull request #35915: [SPARK-38456][SQL] Improve error messages of no viable alternative, extraneous input and missing token in ParseException
cloud-fan commented on a change in pull request #35915:
URL: https://github.com/apache/spark/pull/35915#discussion_r831117075
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/SparkParserErrorStrategy.scala
##########
@@ -49,6 +48,10 @@ class SparkRecognitionException(
},
Some(errorClass),
messageParameters)
+
+ /** Construct with pure errorClass and messageParameter information. */
+ def this(errorClass: String, messageParameters: Array[String]) =
Review comment:
Does `SparkRecognitionException` still need to take error class name as a parameter if it's always `PARSE_SYNTAX_ERROR`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org