[GitHub] [flink] leonardBang commented on a change in pull request #10289: [FLINK-14924][table sql / api] CsvTableSource can not config empty column as null

[GitBox <gi...@apache.org>]

leonardBang commented on a change in pull request #10289: [FLINK-14924][table sql / api] CsvTableSource can not config empty column as null
URL: https://github.com/apache/flink/pull/10289#discussion_r349507260
 
 

 ##########
 File path: flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/sources/CsvTableSource.java
 ##########
 @@ -101,6 +101,40 @@ public CsvTableSource(
 			quoteCharacter, ignoreFirstLine, ignoreComments, lenient);
 	}
 
+	/**
+	 * A {@link InputFormatTableSource} and {@link LookupableTableSource} for simple CSV files with
+	 * a (logically) unlimited number of fields.
+	 *
+	 * @param path            	The path to the CSV file.
+	 * @param fieldNames      	The names of the table fields.
+	 * @param fieldTypes      	The types of the table fields.
+	 * @param fieldDelim      	The field delimiter, "," by default.
+	 * @param lineDelim       	The row delimiter, "\n" by default.
+	 * @param quoteCharacter  	An optional quote character for String values, null by default.
+	 * @param ignoreFirstLine 	Flag to ignore the first line, false by default.
+	 * @param ignoreComments  	An optional prefix to indicate comments, null by default.
+	 * @param lenient         	Flag to skip records with parse error instead to fail, false by
+	 *                        	default.
+	 * @param emptyColumnAsNull	Flag to treat empty column as null.
+	 */
+	public CsvTableSource(
 
 Review comment:
   Sounds good, importing the new two constructors just for  compatibility.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services