You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by Pierre-Arnaud Marcelot <pa...@marcelot.net> on 2009/02/18 11:17:12 UTC
Re: svn commit: r745400 - /directory/studio/trunk/ldapbrowser-common/pom.xml
Hi Felix,
I came across the same problem and was wondering if we should do this or
simply move the properties files to 'src/main/resources' (in the right
packages of course).
WDYT?
Regards,
Pierre-Arnaud
On Wed, Feb 18, 2009 at 8:44 AM, <fe...@apache.org> wrote:
> Author: felixk
> Date: Wed Feb 18 07:44:30 2009
> New Revision: 745400
>
> URL: http://svn.apache.org/viewvc?rev=745400&view=rev
> Log:
> Fix missing messages*.properties files in generated jar
>
> Modified:
> directory/studio/trunk/ldapbrowser-common/pom.xml
>
> Modified: directory/studio/trunk/ldapbrowser-common/pom.xml
> URL:
> http://svn.apache.org/viewvc/directory/studio/trunk/ldapbrowser-common/pom.xml?rev=745400&r1=745399&r2=745400&view=diff
>
> ==============================================================================
> --- directory/studio/trunk/ldapbrowser-common/pom.xml (original)
> +++ directory/studio/trunk/ldapbrowser-common/pom.xml Wed Feb 18 07:44:30
> 2009
> @@ -49,6 +49,12 @@
> <resource>
> <directory>src/main/resources</directory>
> </resource>
> + <resource>
> + <directory>src/main/java</directory>
> + <includes>
> + <include>**/*.properties</include>
> + </includes>
> + </resource>
> </resources>
> <plugins>
> <plugin>
> @@ -56,7 +62,7 @@
> <artifactId>maven-eclipse-plugin</artifactId>
> <configuration>
> <skip>false</skip>
> - <pde>true</pde>
> + <pde>true</pde>
> <additionalProjectnatures>
> <projectnature>org.eclipse.pde.PluginNature</projectnature>
> <projectnature>org.eclipse.jdt.core.javanature</projectnature>
>
>
>
Re: svn commit: r745400 - /directory/studio/trunk/ldapbrowser-common/pom.xml
Posted by Pierre-Arnaud Marcelot <pa...@marcelot.net>.
Hi Felix,
On Wed, Feb 18, 2009 at 11:33 AM, Felix Knecht <fe...@apache.org> wrote:
> Hi Pierre-Arnaud
>
> > Hi Felix,
> >
> > I came across the same problem and was wondering if we should do this or
> > simply move the properties files to 'src/main/resources' (in the right
> > packages of course).
>
> Regarding to Eclipses RPC structure I think this would be the right place,
> whereas regarding from then Maven POV you're
> totally right to move them to the src/main/resources.
>
> I don't now what happens debugging in Eclipse when having them in the
> resources directory. Does it still works?
> I think to remember that the time I started with the i18n stuff I thought
> it easier to have it in the src/main/java tree
> because there I had (and probably still and only have) support for Eclipse
> tooling like 'Externalize strings...' and
> other gadgets.
>
> IMO it's easier to handle them using Eclipse tools when they are in the
> scr/main/java tree.
Yeah, you're totally right. I didn't have this in mind...
I don't want Eclipse to get mad because it's doesn't find the properties
files in 'src/main/java'.
Let's make an exception on our Maven principles for this particular thing.
As you said, this can save us precious time, especially if we can keep using
the Eclipse tooling for internationalization.
Thanks,
Pierre-Arnaud
Re: svn commit: r745400 - /directory/studio/trunk/ldapbrowser-common/pom.xml
Posted by Felix Knecht <fe...@apache.org>.
Hi Pierre-Arnaud
> Hi Felix,
>
> I came across the same problem and was wondering if we should do this or
> simply move the properties files to 'src/main/resources' (in the right
> packages of course).
Regarding to Eclipses RPC structure I think this would be the right place, whereas regarding from then Maven POV you're
totally right to move them to the src/main/resources.
I don't now what happens debugging in Eclipse when having them in the resources directory. Does it still works?
I think to remember that the time I started with the i18n stuff I thought it easier to have it in the src/main/java tree
because there I had (and probably still and only have) support for Eclipse tooling like 'Externalize strings...' and
other gadgets.
IMO it's easier to handle them using Eclipse tools when they are in the scr/main/java tree.
Regards
Felix