You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/12/30 10:15:15 UTC
[GitHub] [airflow] michalslowikowski00 opened a new pull request #6965:
[AIRFLOW-6107] [AIP-21] Rename container service
michalslowikowski00 opened a new pull request #6965: [AIRFLOW-6107] [AIP-21] Rename container service
URL: https://github.com/apache/airflow/pull/6965
Below classes have been changed:
- GKEClusterCreateOperator
- GKEClusterDeleteOperator
- GKEPodOperator
- GKEClusterHook
-
### Jira
- [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-6107
- In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [ ] Here are some details about my PR, including screenshots of any UI changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain docstrings that explain what it does
- If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] nuclearpinguin commented on issue #6965: [AIRFLOW-6107]
[AIP-21] Rename GKE operators and hook
Posted by GitBox <gi...@apache.org>.
nuclearpinguin commented on issue #6965: [AIRFLOW-6107] [AIP-21] Rename GKE operators and hook
URL: https://github.com/apache/airflow/pull/6965#issuecomment-570777055
> Some new operator names are invalid.
Can you hint wich ones?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6965:
[AIRFLOW-6107] [AIP-21] Rename GKE operators and hook
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6965: [AIRFLOW-6107] [AIP-21] Rename GKE operators and hook
URL: https://github.com/apache/airflow/pull/6965#issuecomment-569946590
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=h1) Report
> Merging [#6965](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/991b34d66bc61cf70084b9553b6869d9c4b68884?src=pr&el=desc) will **decrease** coverage by `0.45%`.
> The diff coverage is `97.29%`.
[](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6965 +/- ##
==========================================
- Coverage 84.81% 84.36% -0.46%
==========================================
Files 679 679
Lines 38495 38511 +16
==========================================
- Hits 32649 32488 -161
- Misses 5846 6023 +177
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...irflow/contrib/operators/gcp\_container\_operator.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfY29udGFpbmVyX29wZXJhdG9yLnB5) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/gcp/hooks/kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3Mva3ViZXJuZXRlc19lbmdpbmUucHk=) | `95.89% <100%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_container\_hook.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9jb250YWluZXJfaG9vay5weQ==) | `100% <100%> (ø)` | :arrow_up: |
| [...flow/gcp/example\_dags/example\_kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfa3ViZXJuZXRlc19lbmdpbmUucHk=) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/gcp/operators/kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2t1YmVybmV0ZXNfZW5naW5lLnB5) | `97.26% <92.85%> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `56% <0%> (-32%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| ... and [6 more](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=footer). Last update [991b34d...0480a85](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6965:
[AIRFLOW-6107] [AIP-21] Rename GKE operators and hook
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6965: [AIRFLOW-6107] [AIP-21] Rename GKE operators and hook
URL: https://github.com/apache/airflow/pull/6965#issuecomment-569946590
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=h1) Report
> Merging [#6965](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/991b34d66bc61cf70084b9553b6869d9c4b68884?src=pr&el=desc) will **decrease** coverage by `0.45%`.
> The diff coverage is `97.29%`.
[](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6965 +/- ##
==========================================
- Coverage 84.81% 84.36% -0.46%
==========================================
Files 679 679
Lines 38495 38511 +16
==========================================
- Hits 32649 32488 -161
- Misses 5846 6023 +177
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...irflow/contrib/operators/gcp\_container\_operator.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfY29udGFpbmVyX29wZXJhdG9yLnB5) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/gcp/hooks/kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3Mva3ViZXJuZXRlc19lbmdpbmUucHk=) | `95.89% <100%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_container\_hook.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9jb250YWluZXJfaG9vay5weQ==) | `100% <100%> (ø)` | :arrow_up: |
| [...flow/gcp/example\_dags/example\_kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfa3ViZXJuZXRlc19lbmdpbmUucHk=) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/gcp/operators/kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2t1YmVybmV0ZXNfZW5naW5lLnB5) | `97.26% <92.85%> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `56% <0%> (-32%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| ... and [6 more](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=footer). Last update [991b34d...0480a85](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] michalslowikowski00 closed pull request #6965:
[AIRFLOW-6107] [AIP-21] Rename GKE operators and hook
Posted by GitBox <gi...@apache.org>.
michalslowikowski00 closed pull request #6965: [AIRFLOW-6107] [AIP-21] Rename GKE operators and hook
URL: https://github.com/apache/airflow/pull/6965
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6965:
[AIRFLOW-6107] [AIP-21] Rename GKE operators and hook
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6965: [AIRFLOW-6107] [AIP-21] Rename GKE operators and hook
URL: https://github.com/apache/airflow/pull/6965#issuecomment-569946590
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=h1) Report
> Merging [#6965](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/991b34d66bc61cf70084b9553b6869d9c4b68884?src=pr&el=desc) will **decrease** coverage by `0.45%`.
> The diff coverage is `97.29%`.
[](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6965 +/- ##
==========================================
- Coverage 84.81% 84.36% -0.46%
==========================================
Files 679 679
Lines 38495 38511 +16
==========================================
- Hits 32649 32488 -161
- Misses 5846 6023 +177
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...irflow/contrib/operators/gcp\_container\_operator.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfY29udGFpbmVyX29wZXJhdG9yLnB5) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/gcp/hooks/kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3Mva3ViZXJuZXRlc19lbmdpbmUucHk=) | `95.89% <100%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_container\_hook.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9jb250YWluZXJfaG9vay5weQ==) | `100% <100%> (ø)` | :arrow_up: |
| [...flow/gcp/example\_dags/example\_kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfa3ViZXJuZXRlc19lbmdpbmUucHk=) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/gcp/operators/kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2t1YmVybmV0ZXNfZW5naW5lLnB5) | `97.26% <92.85%> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `56% <0%> (-32%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| ... and [6 more](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=footer). Last update [991b34d...0480a85](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6965:
[AIRFLOW-6107] [AIP-21] Rename GKE operators and hook
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6965: [AIRFLOW-6107] [AIP-21] Rename GKE operators and hook
URL: https://github.com/apache/airflow/pull/6965#issuecomment-569946590
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=h1) Report
> Merging [#6965](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/991b34d66bc61cf70084b9553b6869d9c4b68884?src=pr&el=desc) will **decrease** coverage by `0.45%`.
> The diff coverage is `97.29%`.
[](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6965 +/- ##
==========================================
- Coverage 84.81% 84.36% -0.46%
==========================================
Files 679 679
Lines 38495 38511 +16
==========================================
- Hits 32649 32488 -161
- Misses 5846 6023 +177
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...irflow/contrib/operators/gcp\_container\_operator.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfY29udGFpbmVyX29wZXJhdG9yLnB5) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/gcp/hooks/kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3Mva3ViZXJuZXRlc19lbmdpbmUucHk=) | `95.89% <100%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_container\_hook.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9jb250YWluZXJfaG9vay5weQ==) | `100% <100%> (ø)` | :arrow_up: |
| [...flow/gcp/example\_dags/example\_kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfa3ViZXJuZXRlc19lbmdpbmUucHk=) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/gcp/operators/kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2t1YmVybmV0ZXNfZW5naW5lLnB5) | `97.26% <92.85%> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `56% <0%> (-32%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| ... and [6 more](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=footer). Last update [991b34d...0480a85](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] michalslowikowski00 commented on a change in pull request
#6965: [AIRFLOW-6107] [AIP-21] Rename GKE operators and hook
Posted by GitBox <gi...@apache.org>.
michalslowikowski00 commented on a change in pull request #6965: [AIRFLOW-6107] [AIP-21] Rename GKE operators and hook
URL: https://github.com/apache/airflow/pull/6965#discussion_r362480964
##########
File path: UPDATING.md
##########
@@ -445,9 +445,9 @@ The following table shows changes in import paths.
|airflow.contrib.operators.gcp_compute_operator.GceInstanceStopOperator |airflow.gcp.operators.compute.GceInstanceStopOperator |
|airflow.contrib.operators.gcp_compute_operator.GceInstanceTemplateCopyOperator |airflow.gcp.operators.compute.GceInstanceTemplateCopyOperator |
|airflow.contrib.operators.gcp_compute_operator.GceSetMachineTypeOperator |airflow.gcp.operators.compute.GceSetMachineTypeOperator |
-|airflow.contrib.operators.gcp_container_operator.GKEClusterCreateOperator |airflow.gcp.operators.kubernetes_engine.GKEClusterCreateOperator |
-|airflow.contrib.operators.gcp_container_operator.GKEClusterDeleteOperator |airflow.gcp.operators.kubernetes_engine.GKEClusterDeleteOperator |
-|airflow.contrib.operators.gcp_container_operator.GKEPodOperator |airflow.gcp.operators.kubernetes_engine.GKEPodOperator |
+|airflow.contrib.operators.gcp_container_operator.ComputeEngineCreateClusterOperator |airflow.gcp.operators.kubernetes_engine.ComputeEngineCreateClusterOperator |
Review comment:
Aw... you are right. Whole PR is wrong.
Damn... Ok, I will close this one and make the new one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6965:
[AIRFLOW-6107] [AIP-21] Rename GKE operators and hook
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6965: [AIRFLOW-6107] [AIP-21] Rename GKE operators and hook
URL: https://github.com/apache/airflow/pull/6965#issuecomment-569946590
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=h1) Report
> Merging [#6965](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/991b34d66bc61cf70084b9553b6869d9c4b68884?src=pr&el=desc) will **decrease** coverage by `0.45%`.
> The diff coverage is `97.29%`.
[](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6965 +/- ##
==========================================
- Coverage 84.81% 84.36% -0.46%
==========================================
Files 679 679
Lines 38495 38511 +16
==========================================
- Hits 32649 32488 -161
- Misses 5846 6023 +177
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...irflow/contrib/operators/gcp\_container\_operator.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfY29udGFpbmVyX29wZXJhdG9yLnB5) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/gcp/hooks/kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3Mva3ViZXJuZXRlc19lbmdpbmUucHk=) | `95.89% <100%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_container\_hook.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9jb250YWluZXJfaG9vay5weQ==) | `100% <100%> (ø)` | :arrow_up: |
| [...flow/gcp/example\_dags/example\_kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfa3ViZXJuZXRlc19lbmdpbmUucHk=) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/gcp/operators/kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2t1YmVybmV0ZXNfZW5naW5lLnB5) | `97.26% <92.85%> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `56% <0%> (-32%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| ... and [6 more](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=footer). Last update [991b34d...0480a85](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6965:
[AIRFLOW-6107] [AIP-21] Rename GKE operators and hook
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6965: [AIRFLOW-6107] [AIP-21] Rename GKE operators and hook
URL: https://github.com/apache/airflow/pull/6965#issuecomment-569946590
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=h1) Report
> Merging [#6965](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/991b34d66bc61cf70084b9553b6869d9c4b68884?src=pr&el=desc) will **decrease** coverage by `0.45%`.
> The diff coverage is `97.29%`.
[](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6965 +/- ##
==========================================
- Coverage 84.81% 84.36% -0.46%
==========================================
Files 679 679
Lines 38495 38511 +16
==========================================
- Hits 32649 32488 -161
- Misses 5846 6023 +177
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...irflow/contrib/operators/gcp\_container\_operator.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfY29udGFpbmVyX29wZXJhdG9yLnB5) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/gcp/hooks/kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3Mva3ViZXJuZXRlc19lbmdpbmUucHk=) | `95.89% <100%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_container\_hook.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9jb250YWluZXJfaG9vay5weQ==) | `100% <100%> (ø)` | :arrow_up: |
| [...flow/gcp/example\_dags/example\_kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfa3ViZXJuZXRlc19lbmdpbmUucHk=) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/gcp/operators/kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2t1YmVybmV0ZXNfZW5naW5lLnB5) | `97.26% <92.85%> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `56% <0%> (-32%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| ... and [6 more](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=footer). Last update [991b34d...0480a85](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #6965:
[AIRFLOW-6107] [AIP-21] Rename GKE operators and hook
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #6965: [AIRFLOW-6107] [AIP-21] Rename GKE operators and hook
URL: https://github.com/apache/airflow/pull/6965#discussion_r362194752
##########
File path: UPDATING.md
##########
@@ -445,9 +445,9 @@ The following table shows changes in import paths.
|airflow.contrib.operators.gcp_compute_operator.GceInstanceStopOperator |airflow.gcp.operators.compute.GceInstanceStopOperator |
|airflow.contrib.operators.gcp_compute_operator.GceInstanceTemplateCopyOperator |airflow.gcp.operators.compute.GceInstanceTemplateCopyOperator |
|airflow.contrib.operators.gcp_compute_operator.GceSetMachineTypeOperator |airflow.gcp.operators.compute.GceSetMachineTypeOperator |
-|airflow.contrib.operators.gcp_container_operator.GKEClusterCreateOperator |airflow.gcp.operators.kubernetes_engine.GKEClusterCreateOperator |
-|airflow.contrib.operators.gcp_container_operator.GKEClusterDeleteOperator |airflow.gcp.operators.kubernetes_engine.GKEClusterDeleteOperator |
-|airflow.contrib.operators.gcp_container_operator.GKEPodOperator |airflow.gcp.operators.kubernetes_engine.GKEPodOperator |
+|airflow.contrib.operators.gcp_container_operator.ComputeEngineCreateClusterOperator |airflow.gcp.operators.kubernetes_engine.ComputeEngineCreateClusterOperator |
Review comment:
This looks like a typo. I have already updated the spreadsheet because these operators should still have the prefix "GKE"
https://docs.google.com/spreadsheets/d/1nRI31B6t3PR7Ljsw6BSPqHkoPGzN11BeYEQRXsjEAWU/edit#gid=1271422594
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #6965:
[AIRFLOW-6107] [AIP-21] Rename GKE operators and hook
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #6965: [AIRFLOW-6107] [AIP-21] Rename GKE operators and hook
URL: https://github.com/apache/airflow/pull/6965#discussion_r362194752
##########
File path: UPDATING.md
##########
@@ -445,9 +445,9 @@ The following table shows changes in import paths.
|airflow.contrib.operators.gcp_compute_operator.GceInstanceStopOperator |airflow.gcp.operators.compute.GceInstanceStopOperator |
|airflow.contrib.operators.gcp_compute_operator.GceInstanceTemplateCopyOperator |airflow.gcp.operators.compute.GceInstanceTemplateCopyOperator |
|airflow.contrib.operators.gcp_compute_operator.GceSetMachineTypeOperator |airflow.gcp.operators.compute.GceSetMachineTypeOperator |
-|airflow.contrib.operators.gcp_container_operator.GKEClusterCreateOperator |airflow.gcp.operators.kubernetes_engine.GKEClusterCreateOperator |
-|airflow.contrib.operators.gcp_container_operator.GKEClusterDeleteOperator |airflow.gcp.operators.kubernetes_engine.GKEClusterDeleteOperator |
-|airflow.contrib.operators.gcp_container_operator.GKEPodOperator |airflow.gcp.operators.kubernetes_engine.GKEPodOperator |
+|airflow.contrib.operators.gcp_container_operator.ComputeEngineCreateClusterOperator |airflow.gcp.operators.kubernetes_engine.ComputeEngineCreateClusterOperator |
Review comment:
This looks like a misunderstanding. I have already updated the spreadsheet because these operators should still have the prefix "GKE"
https://docs.google.com/spreadsheets/d/1nRI31B6t3PR7Ljsw6BSPqHkoPGzN11BeYEQRXsjEAWU/edit#gid=1271422594
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6965:
[AIRFLOW-6107] [AIP-21] Rename GKE operators and hook
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6965: [AIRFLOW-6107] [AIP-21] Rename GKE operators and hook
URL: https://github.com/apache/airflow/pull/6965#issuecomment-569946590
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=h1) Report
> Merging [#6965](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/991b34d66bc61cf70084b9553b6869d9c4b68884?src=pr&el=desc) will **decrease** coverage by `0.45%`.
> The diff coverage is `97.29%`.
[](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6965 +/- ##
==========================================
- Coverage 84.81% 84.36% -0.46%
==========================================
Files 679 679
Lines 38495 38511 +16
==========================================
- Hits 32649 32488 -161
- Misses 5846 6023 +177
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...irflow/contrib/operators/gcp\_container\_operator.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfY29udGFpbmVyX29wZXJhdG9yLnB5) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/gcp/hooks/kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3Mva3ViZXJuZXRlc19lbmdpbmUucHk=) | `95.89% <100%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_container\_hook.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9jb250YWluZXJfaG9vay5weQ==) | `100% <100%> (ø)` | :arrow_up: |
| [...flow/gcp/example\_dags/example\_kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfa3ViZXJuZXRlc19lbmdpbmUucHk=) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/gcp/operators/kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2t1YmVybmV0ZXNfZW5naW5lLnB5) | `97.26% <92.85%> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `56% <0%> (-32%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| ... and [6 more](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=footer). Last update [991b34d...0480a85](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6965:
[AIRFLOW-6107] [AIP-21] Rename GKE operators and hook
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6965: [AIRFLOW-6107] [AIP-21] Rename GKE operators and hook
URL: https://github.com/apache/airflow/pull/6965#issuecomment-569946590
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=h1) Report
> Merging [#6965](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/991b34d66bc61cf70084b9553b6869d9c4b68884?src=pr&el=desc) will **decrease** coverage by `0.45%`.
> The diff coverage is `97.29%`.
[](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6965 +/- ##
==========================================
- Coverage 84.81% 84.36% -0.46%
==========================================
Files 679 679
Lines 38495 38511 +16
==========================================
- Hits 32649 32488 -161
- Misses 5846 6023 +177
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...irflow/contrib/operators/gcp\_container\_operator.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfY29udGFpbmVyX29wZXJhdG9yLnB5) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/gcp/hooks/kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3Mva3ViZXJuZXRlc19lbmdpbmUucHk=) | `95.89% <100%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_container\_hook.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9jb250YWluZXJfaG9vay5weQ==) | `100% <100%> (ø)` | :arrow_up: |
| [...flow/gcp/example\_dags/example\_kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfa3ViZXJuZXRlc19lbmdpbmUucHk=) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/gcp/operators/kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2t1YmVybmV0ZXNfZW5naW5lLnB5) | `97.26% <92.85%> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `56% <0%> (-32%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| ... and [6 more](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=footer). Last update [991b34d...0480a85](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6965:
[AIRFLOW-6107] [AIP-21] Rename GKE operators and hook
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6965: [AIRFLOW-6107] [AIP-21] Rename GKE operators and hook
URL: https://github.com/apache/airflow/pull/6965#issuecomment-569946590
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=h1) Report
> Merging [#6965](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/be812bd660fac4621a25f3269fded8d4e03b0023?src=pr&el=desc) will **decrease** coverage by `0.27%`.
> The diff coverage is `97.29%`.
[](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6965 +/- ##
==========================================
- Coverage 84.85% 84.57% -0.28%
==========================================
Files 679 679
Lines 38536 38552 +16
==========================================
- Hits 32698 32604 -94
- Misses 5838 5948 +110
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...irflow/contrib/operators/gcp\_container\_operator.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfY29udGFpbmVyX29wZXJhdG9yLnB5) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/gcp/hooks/kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3Mva3ViZXJuZXRlc19lbmdpbmUucHk=) | `95.89% <100%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_container\_hook.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9jb250YWluZXJfaG9vay5weQ==) | `100% <100%> (ø)` | :arrow_up: |
| [...flow/gcp/example\_dags/example\_kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfa3ViZXJuZXRlc19lbmdpbmUucHk=) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/gcp/operators/kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2t1YmVybmV0ZXNfZW5naW5lLnB5) | `97.26% <92.85%> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=footer). Last update [be812bd...687a16c](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6965:
[AIRFLOW-6107] [AIP-21] Rename GKE operators and hook
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6965: [AIRFLOW-6107] [AIP-21] Rename GKE operators and hook
URL: https://github.com/apache/airflow/pull/6965#issuecomment-569946590
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=h1) Report
> Merging [#6965](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/0f7c4563d2f8885e12312aae72bc70a22f734894?src=pr&el=desc) will **decrease** coverage by `0.34%`.
> The diff coverage is `97.29%`.
[](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6965 +/- ##
==========================================
- Coverage 84.7% 84.36% -0.35%
==========================================
Files 679 679
Lines 38489 38511 +22
==========================================
- Hits 32601 32488 -113
- Misses 5888 6023 +135
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...irflow/contrib/operators/gcp\_container\_operator.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfY29udGFpbmVyX29wZXJhdG9yLnB5) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/gcp/hooks/kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3Mva3ViZXJuZXRlc19lbmdpbmUucHk=) | `95.89% <100%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_container\_hook.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9jb250YWluZXJfaG9vay5weQ==) | `100% <100%> (ø)` | :arrow_up: |
| [...flow/gcp/example\_dags/example\_kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfa3ViZXJuZXRlc19lbmdpbmUucHk=) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/gcp/operators/kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2t1YmVybmV0ZXNfZW5naW5lLnB5) | `97.26% <92.85%> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `56% <0%> (-32%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| ... and [23 more](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=footer). Last update [0f7c456...0480a85](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] michalslowikowski00 commented on a change in pull request
#6965: [AIRFLOW-6107] [AIP-21] Rename GKE operators and hook
Posted by GitBox <gi...@apache.org>.
michalslowikowski00 commented on a change in pull request #6965: [AIRFLOW-6107] [AIP-21] Rename GKE operators and hook
URL: https://github.com/apache/airflow/pull/6965#discussion_r362227885
##########
File path: UPDATING.md
##########
@@ -445,9 +445,9 @@ The following table shows changes in import paths.
|airflow.contrib.operators.gcp_compute_operator.GceInstanceStopOperator |airflow.gcp.operators.compute.GceInstanceStopOperator |
|airflow.contrib.operators.gcp_compute_operator.GceInstanceTemplateCopyOperator |airflow.gcp.operators.compute.GceInstanceTemplateCopyOperator |
|airflow.contrib.operators.gcp_compute_operator.GceSetMachineTypeOperator |airflow.gcp.operators.compute.GceSetMachineTypeOperator |
-|airflow.contrib.operators.gcp_container_operator.GKEClusterCreateOperator |airflow.gcp.operators.kubernetes_engine.GKEClusterCreateOperator |
-|airflow.contrib.operators.gcp_container_operator.GKEClusterDeleteOperator |airflow.gcp.operators.kubernetes_engine.GKEClusterDeleteOperator |
-|airflow.contrib.operators.gcp_container_operator.GKEPodOperator |airflow.gcp.operators.kubernetes_engine.GKEPodOperator |
+|airflow.contrib.operators.gcp_container_operator.ComputeEngineCreateClusterOperator |airflow.gcp.operators.kubernetes_engine.ComputeEngineCreateClusterOperator |
Review comment:
Yes, my mistake. Commit is on the way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6965:
[AIRFLOW-6107] [AIP-21] Rename GKE operators and hook
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6965: [AIRFLOW-6107] [AIP-21] Rename GKE operators and hook
URL: https://github.com/apache/airflow/pull/6965#issuecomment-569946590
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=h1) Report
> Merging [#6965](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/991b34d66bc61cf70084b9553b6869d9c4b68884?src=pr&el=desc) will **decrease** coverage by `0.45%`.
> The diff coverage is `97.29%`.
[](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6965 +/- ##
==========================================
- Coverage 84.81% 84.36% -0.46%
==========================================
Files 679 679
Lines 38495 38511 +16
==========================================
- Hits 32649 32488 -161
- Misses 5846 6023 +177
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...irflow/contrib/operators/gcp\_container\_operator.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfY29udGFpbmVyX29wZXJhdG9yLnB5) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/gcp/hooks/kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3Mva3ViZXJuZXRlc19lbmdpbmUucHk=) | `95.89% <100%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_container\_hook.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9jb250YWluZXJfaG9vay5weQ==) | `100% <100%> (ø)` | :arrow_up: |
| [...flow/gcp/example\_dags/example\_kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfa3ViZXJuZXRlc19lbmdpbmUucHk=) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/gcp/operators/kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2t1YmVybmV0ZXNfZW5naW5lLnB5) | `97.26% <92.85%> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `56% <0%> (-32%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| ... and [6 more](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=footer). Last update [991b34d...0480a85](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] nuclearpinguin commented on a change in pull request
#6965: [AIRFLOW-6107] [AIP-21] Rename GKE operators and hook
Posted by GitBox <gi...@apache.org>.
nuclearpinguin commented on a change in pull request #6965: [AIRFLOW-6107] [AIP-21] Rename GKE operators and hook
URL: https://github.com/apache/airflow/pull/6965#discussion_r362475833
##########
File path: UPDATING.md
##########
@@ -445,9 +445,9 @@ The following table shows changes in import paths.
|airflow.contrib.operators.gcp_compute_operator.GceInstanceStopOperator |airflow.gcp.operators.compute.GceInstanceStopOperator |
|airflow.contrib.operators.gcp_compute_operator.GceInstanceTemplateCopyOperator |airflow.gcp.operators.compute.GceInstanceTemplateCopyOperator |
|airflow.contrib.operators.gcp_compute_operator.GceSetMachineTypeOperator |airflow.gcp.operators.compute.GceSetMachineTypeOperator |
-|airflow.contrib.operators.gcp_container_operator.GKEClusterCreateOperator |airflow.gcp.operators.kubernetes_engine.GKEClusterCreateOperator |
-|airflow.contrib.operators.gcp_container_operator.GKEClusterDeleteOperator |airflow.gcp.operators.kubernetes_engine.GKEClusterDeleteOperator |
-|airflow.contrib.operators.gcp_container_operator.GKEPodOperator |airflow.gcp.operators.kubernetes_engine.GKEPodOperator |
+|airflow.contrib.operators.gcp_container_operator.ComputeEngineCreateClusterOperator |airflow.gcp.operators.kubernetes_engine.ComputeEngineCreateClusterOperator |
Review comment:
@michalslowikowski00 I think we want to have
```
airflow.gcp.operators.container.GKECreateClusterOperator
airflow.gcp.operators.container.GKEDeleteClusterOperator
```
instead of
```
airflow.gcp.operators.container.ComputeEngineCreateClusterOperator
airflow.gcp.operators.container.ComputeEngineDeleteClusterOperator
```
@mik-laj
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6965:
[AIRFLOW-6107] [AIP-21] Rename GKE operators and hook
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6965: [AIRFLOW-6107] [AIP-21] Rename GKE operators and hook
URL: https://github.com/apache/airflow/pull/6965#issuecomment-569946590
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=h1) Report
> Merging [#6965](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/991b34d66bc61cf70084b9553b6869d9c4b68884?src=pr&el=desc) will **decrease** coverage by `0.45%`.
> The diff coverage is `97.29%`.
[](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6965 +/- ##
==========================================
- Coverage 84.81% 84.36% -0.46%
==========================================
Files 679 679
Lines 38495 38511 +16
==========================================
- Hits 32649 32488 -161
- Misses 5846 6023 +177
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...irflow/contrib/operators/gcp\_container\_operator.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfY29udGFpbmVyX29wZXJhdG9yLnB5) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/gcp/hooks/kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3Mva3ViZXJuZXRlc19lbmdpbmUucHk=) | `95.89% <100%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_container\_hook.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9jb250YWluZXJfaG9vay5weQ==) | `100% <100%> (ø)` | :arrow_up: |
| [...flow/gcp/example\_dags/example\_kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfa3ViZXJuZXRlc19lbmdpbmUucHk=) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/gcp/operators/kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2t1YmVybmV0ZXNfZW5naW5lLnB5) | `97.26% <92.85%> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `56% <0%> (-32%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| ... and [6 more](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=footer). Last update [991b34d...0480a85](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6965:
[AIRFLOW-6107] [AIP-21] Rename GKE operators and hook
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6965: [AIRFLOW-6107] [AIP-21] Rename GKE operators and hook
URL: https://github.com/apache/airflow/pull/6965#issuecomment-569946590
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=h1) Report
> Merging [#6965](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/0f7c4563d2f8885e12312aae72bc70a22f734894?src=pr&el=desc) will **decrease** coverage by `0.19%`.
> The diff coverage is `97.29%`.
[](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6965 +/- ##
========================================
- Coverage 84.7% 84.5% -0.2%
========================================
Files 679 679
Lines 38489 38552 +63
========================================
- Hits 32601 32578 -23
- Misses 5888 5974 +86
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...irflow/contrib/operators/gcp\_container\_operator.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfY29udGFpbmVyX29wZXJhdG9yLnB5) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/gcp/hooks/kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3Mva3ViZXJuZXRlc19lbmdpbmUucHk=) | `95.89% <100%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_container\_hook.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9jb250YWluZXJfaG9vay5weQ==) | `100% <100%> (ø)` | :arrow_up: |
| [...flow/gcp/example\_dags/example\_kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfa3ViZXJuZXRlc19lbmdpbmUucHk=) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/gcp/operators/kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2t1YmVybmV0ZXNfZW5naW5lLnB5) | `97.26% <92.85%> (ø)` | :arrow_up: |
| [airflow/operators/postgres\_operator.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcG9zdGdyZXNfb3BlcmF0b3IucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| ... and [32 more](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=footer). Last update [0f7c456...687a16c](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6965:
[AIRFLOW-6107] [AIP-21] Rename GKE operators and hook
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6965: [AIRFLOW-6107] [AIP-21] Rename GKE operators and hook
URL: https://github.com/apache/airflow/pull/6965#issuecomment-569946590
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=h1) Report
> Merging [#6965](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/991b34d66bc61cf70084b9553b6869d9c4b68884?src=pr&el=desc) will **decrease** coverage by `0.45%`.
> The diff coverage is `97.29%`.
[](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6965 +/- ##
==========================================
- Coverage 84.81% 84.36% -0.46%
==========================================
Files 679 679
Lines 38495 38511 +16
==========================================
- Hits 32649 32488 -161
- Misses 5846 6023 +177
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...irflow/contrib/operators/gcp\_container\_operator.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfY29udGFpbmVyX29wZXJhdG9yLnB5) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/gcp/hooks/kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3Mva3ViZXJuZXRlc19lbmdpbmUucHk=) | `95.89% <100%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_container\_hook.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9jb250YWluZXJfaG9vay5weQ==) | `100% <100%> (ø)` | :arrow_up: |
| [...flow/gcp/example\_dags/example\_kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfa3ViZXJuZXRlc19lbmdpbmUucHk=) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/gcp/operators/kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2t1YmVybmV0ZXNfZW5naW5lLnB5) | `97.26% <92.85%> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `56% <0%> (-32%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| ... and [6 more](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=footer). Last update [991b34d...0480a85](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] michalslowikowski00 commented on a change in pull request
#6965: [AIRFLOW-6107] [AIP-21] Rename GKE operators and hook
Posted by GitBox <gi...@apache.org>.
michalslowikowski00 commented on a change in pull request #6965: [AIRFLOW-6107] [AIP-21] Rename GKE operators and hook
URL: https://github.com/apache/airflow/pull/6965#discussion_r362227885
##########
File path: UPDATING.md
##########
@@ -445,9 +445,9 @@ The following table shows changes in import paths.
|airflow.contrib.operators.gcp_compute_operator.GceInstanceStopOperator |airflow.gcp.operators.compute.GceInstanceStopOperator |
|airflow.contrib.operators.gcp_compute_operator.GceInstanceTemplateCopyOperator |airflow.gcp.operators.compute.GceInstanceTemplateCopyOperator |
|airflow.contrib.operators.gcp_compute_operator.GceSetMachineTypeOperator |airflow.gcp.operators.compute.GceSetMachineTypeOperator |
-|airflow.contrib.operators.gcp_container_operator.GKEClusterCreateOperator |airflow.gcp.operators.kubernetes_engine.GKEClusterCreateOperator |
-|airflow.contrib.operators.gcp_container_operator.GKEClusterDeleteOperator |airflow.gcp.operators.kubernetes_engine.GKEClusterDeleteOperator |
-|airflow.contrib.operators.gcp_container_operator.GKEPodOperator |airflow.gcp.operators.kubernetes_engine.GKEPodOperator |
+|airflow.contrib.operators.gcp_container_operator.ComputeEngineCreateClusterOperator |airflow.gcp.operators.kubernetes_engine.ComputeEngineCreateClusterOperator |
Review comment:
Yes, my mistake. Commit is on his way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #6965: [AIRFLOW-6107]
[AIP-21] Rename GKE operators and hook
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #6965: [AIRFLOW-6107] [AIP-21] Rename GKE operators and hook
URL: https://github.com/apache/airflow/pull/6965#issuecomment-569946590
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=h1) Report
> Merging [#6965](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/991b34d66bc61cf70084b9553b6869d9c4b68884?src=pr&el=desc) will **decrease** coverage by `0.45%`.
> The diff coverage is `97.29%`.
[](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6965 +/- ##
==========================================
- Coverage 84.81% 84.36% -0.46%
==========================================
Files 679 679
Lines 38495 38511 +16
==========================================
- Hits 32649 32488 -161
- Misses 5846 6023 +177
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...irflow/contrib/operators/gcp\_container\_operator.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfY29udGFpbmVyX29wZXJhdG9yLnB5) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/gcp/hooks/kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3Mva3ViZXJuZXRlc19lbmdpbmUucHk=) | `95.89% <100%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_container\_hook.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9jb250YWluZXJfaG9vay5weQ==) | `100% <100%> (ø)` | :arrow_up: |
| [...flow/gcp/example\_dags/example\_kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfa3ViZXJuZXRlc19lbmdpbmUucHk=) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/gcp/operators/kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2t1YmVybmV0ZXNfZW5naW5lLnB5) | `97.26% <92.85%> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `56% <0%> (-32%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| ... and [6 more](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=footer). Last update [991b34d...0480a85](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6965:
[AIRFLOW-6107] [AIP-21] Rename GKE operators and hook
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6965: [AIRFLOW-6107] [AIP-21] Rename GKE operators and hook
URL: https://github.com/apache/airflow/pull/6965#issuecomment-569946590
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=h1) Report
> Merging [#6965](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/0f7c4563d2f8885e12312aae72bc70a22f734894?src=pr&el=desc) will **decrease** coverage by `0.34%`.
> The diff coverage is `97.29%`.
[](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6965 +/- ##
==========================================
- Coverage 84.7% 84.36% -0.35%
==========================================
Files 679 679
Lines 38489 38511 +22
==========================================
- Hits 32601 32488 -113
- Misses 5888 6023 +135
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...irflow/contrib/operators/gcp\_container\_operator.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfY29udGFpbmVyX29wZXJhdG9yLnB5) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/gcp/hooks/kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3Mva3ViZXJuZXRlc19lbmdpbmUucHk=) | `95.89% <100%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_container\_hook.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9jb250YWluZXJfaG9vay5weQ==) | `100% <100%> (ø)` | :arrow_up: |
| [...flow/gcp/example\_dags/example\_kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfa3ViZXJuZXRlc19lbmdpbmUucHk=) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/gcp/operators/kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2t1YmVybmV0ZXNfZW5naW5lLnB5) | `97.26% <92.85%> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `56% <0%> (-32%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| ... and [23 more](https://codecov.io/gh/apache/airflow/pull/6965/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=footer). Last update [0f7c456...0480a85](https://codecov.io/gh/apache/airflow/pull/6965?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services