[GitHub] [flink] KurtYoung commented on a change in pull request #10514: [FLINK-15167][sql-client] Catalogs should be created and registered with user class loader as context loader

[GitBox <gi...@apache.org>]

KurtYoung commented on a change in pull request #10514: [FLINK-15167][sql-client] Catalogs should be created and registered with user class loader as context loader
URL: https://github.com/apache/flink/pull/10514#discussion_r357499331
 
 

 ##########
 File path: flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/ExecutionContext.java
 ##########
 @@ -232,6 +232,15 @@ public SessionState getSessionState() {
 		}
 	}
 
+	/**
+	 * Executes the given Runnable using the execution context's classloader as thread classloader.
+	 */
+	private void wrapClassLoader(Runnable runnable) {
 
 Review comment:
   Since we have this method now, could you also correct the usage of old `wrapClassLoader(Supplier<R> supplier)` and `return null` inside? I think they should be changed to use this one. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services