You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "rajucomp (via GitHub)" <gi...@apache.org> on 2025/12/26 15:03:35 UTC
[PR] Add failing tests to reproduce POOL-413 [commons-pool]
rajucomp opened a new pull request, #453:
URL: https://github.com/apache/commons-pool/pull/453
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
https://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for your contribution to [Apache Commons](https://commons.apache.org/)! Your help is appreciated!
Before you push a pull request, review this list:
- [ ] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
- [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI).
- [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute?
- [ ] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself.
- [ ] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.
In a `GenericObjectPool` it is possible to configure a maximum number of idle objects to be kept by the pool while they are not in use.
In unfortunate circumstances, if several threads return an object to the pool at the same time, the check on the maximum number of idle objects may be dismissed. This results in the pool keeping more idle objects than configured.
Looking into the source code of the `returnObject` method of the `GenericObjectPool`, it seems that there is no synchronization between the moment the check is made for the `maxIdle` configuration and the moment the object is destroyed:
```java
final int maxIdleSave = getMaxIdle();
if (isClosed() || maxIdleSave > -1 && maxIdleSave <= idleObjects.size()) {
try {
destroy(p, DestroyMode.NORMAL);
} catch (final Exception e) {
swallowException(e);
}
try {
ensureIdle(1, false);
} catch (final Exception e) {
swallowException(e);
}
}
```
The PR contains the test to demonstrate the failure. A fix is ready for the same. Once the maintainer confirm the bug, a seperate PR for the fix will be raised.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add failing tests to reproduce POOL-413 [commons-pool]
Posted by "psteitz (via GitHub)" <gi...@apache.org>.
psteitz commented on PR #453:
URL: https://github.com/apache/commons-pool/pull/453#issuecomment-3694146402
I can't follow the discussion here. Can we please move this discussion to the mailing list?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add failing tests to reproduce POOL-413 [commons-pool]
Posted by "rajucomp (via GitHub)" <gi...@apache.org>.
rajucomp closed pull request #453: Add failing tests to reproduce POOL-413
URL: https://github.com/apache/commons-pool/pull/453
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add failing tests to reproduce POOL-413 [commons-pool]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #453:
URL: https://github.com/apache/commons-pool/pull/453#issuecomment-3693959860
@rajucomp
If you don't rebase on git master, this will never work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add failing tests to reproduce POOL-413 [commons-pool]
Posted by "psteitz (via GitHub)" <gi...@apache.org>.
psteitz commented on PR #453:
URL: https://github.com/apache/commons-pool/pull/453#issuecomment-3694146263
I can't follow the discussion here. Can we please move this discussion to the mailing list?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add failing tests to reproduce POOL-413 [commons-pool]
Posted by "rajucomp (via GitHub)" <gi...@apache.org>.
rajucomp commented on PR #453:
URL: https://github.com/apache/commons-pool/pull/453#issuecomment-3692998194
@garydgregory Could you run the pipelines please ? I have added some comments on the JIRA about the fix. Would appreciate your feedback. Thanks@
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add failing tests to reproduce POOL-413 [commons-pool]
Posted by "rajucomp (via GitHub)" <gi...@apache.org>.
rajucomp commented on PR #453:
URL: https://github.com/apache/commons-pool/pull/453#issuecomment-3695158247
@garydgregory Do you recommend subscribing to all of them or specific ones ? Sorry for the stupid question.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add failing tests to reproduce POOL-413 [commons-pool]
Posted by "rajucomp (via GitHub)" <gi...@apache.org>.
rajucomp commented on PR #453:
URL: https://github.com/apache/commons-pool/pull/453#issuecomment-3693414970
@garydgregory Done. Please run the pipelines. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add failing tests to reproduce POOL-413 [commons-pool]
Posted by "rajucomp (via GitHub)" <gi...@apache.org>.
rajucomp commented on PR #453:
URL: https://github.com/apache/commons-pool/pull/453#issuecomment-3693441589
This is weird. The test fails when run in isolation but passes when the whole test suite is run. Let me see how to reproduce the failure reliably.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add failing tests to reproduce POOL-413 [commons-pool]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #453:
URL: https://github.com/apache/commons-pool/pull/453#issuecomment-3693971797
@rajucomp
You are correct! I must have been looking at the wrong branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add failing tests to reproduce POOL-413 [commons-pool]
Posted by "rajucomp (via GitHub)" <gi...@apache.org>.
rajucomp commented on PR #453:
URL: https://github.com/apache/commons-pool/pull/453#issuecomment-3693966303
@garydgregory Not sure If I understand this correctly. The upstream branch is `POOL_2_X` and I rebased my branch on the top of that. As you can see, the pipelines failed because of the tests I put in. Curious to know why you think a rebase from master is necessary,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add failing tests to reproduce POOL-413 [commons-pool]
Posted by "rajucomp (via GitHub)" <gi...@apache.org>.
rajucomp commented on PR #453:
URL: https://github.com/apache/commons-pool/pull/453#issuecomment-3693976417
I have a potential fix ready but I would like @psteitz 's thoughts on that before I push the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add failing tests to reproduce POOL-413 [commons-pool]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #453:
URL: https://github.com/apache/commons-pool/pull/453#issuecomment-3694727432
@rajucomp
The mailing list subscription information is here: https://commons.apache.org/mail-lists.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add failing tests to reproduce POOL-413 [commons-pool]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #453:
URL: https://github.com/apache/commons-pool/pull/453#issuecomment-3696446909
Hello @rajucomp
The user and dev lists.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add failing tests to reproduce POOL-413 [commons-pool]
Posted by "rajucomp (via GitHub)" <gi...@apache.org>.
rajucomp commented on PR #453:
URL: https://github.com/apache/commons-pool/pull/453#issuecomment-3696978109
Subscribed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add failing tests to reproduce POOL-413 [commons-pool]
Posted by "rajucomp (via GitHub)" <gi...@apache.org>.
rajucomp commented on PR #453:
URL: https://github.com/apache/commons-pool/pull/453#issuecomment-3693462561
@garydgregory Could you trigger the pipelines again ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add failing tests to reproduce POOL-413 [commons-pool]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #453:
URL: https://github.com/apache/commons-pool/pull/453#issuecomment-3693972750
@rajucomp
>The PR contains the test to demonstrate the failure. A fix is ready for the same. Once the maintainer confirm the bug, a seperate PR for the fix will be raised.
We want the fix and the matching test demonstrating that the fix works in the same PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add failing tests to reproduce POOL-413 [commons-pool]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #453:
URL: https://github.com/apache/commons-pool/pull/453#issuecomment-3693357398
@rajucomp Please rebase on git master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org