[jira] [Reopened] (WICKET-4247) HeaderResponseContainerFilteringHeaderResponse does not override enough methods

["Martin Grigorov (Reopened) (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WICKET-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov reopened WICKET-4247:
-------------------------------------


It is fragile :-)
But this is just because not that many people use these classes...

I'd like to rework IHeaderResponse to have just: renderText(), renderCss(CssAttributes) and renderJavaScript(JavaScriptAttributes). These XyzAttributes will have all specifics for <link/> and <script/>.
Not sure whether this will be part of Wicket 6.0 but it should be soon because more people like you will start using this fragile classes :-)
                
> HeaderResponseContainerFilteringHeaderResponse does not override enough methods
> -------------------------------------------------------------------------------
>
>                 Key: WICKET-4247
>                 URL: https://issues.apache.org/jira/browse/WICKET-4247
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5.3
>            Reporter: Andreas Köhler
>            Assignee: Martin Grigorov
>             Fix For: 1.5.4, 6.0.0
>
>         Attachments: wicket-4247.tar.bz2
>
>
> Seen on Wicket 1.5.3 and I think it is still there in SVN.
> Major because users might be trapped thinking that their Javascript is at the bottom but it is not, having weird consequences.
> Attached is a quickstart. It sets up a header response decorator with a header response sending javascript to the bottom which is optionally wrapped by a simple implementation of an aggregating header response. The wrapper though uses a full-arguments method to render javascript which is not fetched by the other response header. So the javascript ends up in the html head.
> It should suffice to override the remaining four (js/css, resource ref/url) render methods to fix this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira