You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cloudstack.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2013/07/29 09:03:48 UTC
[jira] [Commented] (CLOUDSTACK-2715) MigrateSystemVm:
SystemVmInstanceResponse vs SystemVmResponse
[ https://issues.apache.org/jira/browse/CLOUDSTACK-2715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13722215#comment-13722215 ]
ASF subversion and git services commented on CLOUDSTACK-2715:
-------------------------------------------------------------
Commit bcf239db0816e6688cbfba9dbf8390bc5f09430f in branch refs/heads/master from [~tsp]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=bcf239d ]
CLOUDSTACK-2715: Making MigrateSysteVm response uniform
with responses on other systemVm apis. All systemVM apis return
SystemVmResponse - rebootSystemVm, stopSystemVm etc. MigrateSystemVm is
now made uniform.
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
> MigrateSystemVm: SystemVmInstanceResponse vs SystemVmResponse
> -------------------------------------------------------------
>
> Key: CLOUDSTACK-2715
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-2715
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the default.)
> Components: API
> Affects Versions: 4.2.0
> Reporter: Prasanna Santhanam
> Assignee: Prasanna Santhanam
> Fix For: 4.2.0
>
>
> Following diff makes the response for MigrateSystemVm uniform with rebootSystemVm, stopSystemVm and other SystemVm operations to SystemVmResponse instead of the SystemVmInstanceResponse.
> -@APICommand(name = "migrateSystemVm", description="Attempts Migration of a system virtual machine to the host specified.", responseObject=SystemVmInstanceResponse.class)
> +@APICommand(name = "migrateSystemVm", description="Attempts Migration of a system virtual machine to the host specified.", responseObject=SystemVmResponse.class)
> public class MigrateSystemVMCmd extends BaseAsyncCmd {
> public static final Logger s_logger = Logger.getLogger(MigrateSystemVMCmd.class.getName());
>
> @@ -112,7 +110,7 @@ public class MigrateSystemVMCmd extends BaseAsyncCmd {
> VirtualMachine migratedVm = _userVmService.migrateVirtualMachine(getVirtualMachineId(), destinationHost);
> if (migratedVm != null) {
> // return the generic system VM instance response
> - SystemVmInstanceResponse response = _responseGenerator.createSystemVmInstanceResponse(migratedVm);
> + SystemVmResponse response = _responseGenerator.createSystemVmResponse(migratedVm);
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira