You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hivemall.apache.org by maropu <gi...@git.apache.org> on 2017/01/26 15:19:03 UTC

[GitHub] incubator-hivemall pull request #29: [HIVEMALL-39] Put the use of HiveUDFs i...

GitHub user maropu opened a pull request:

    https://github.com/apache/incubator-hivemall/pull/29

    [HIVEMALL-39] Put the use of HiveUDFs in one place

    ## What changes were proposed in this pull request?
    This is a refactoring issue; in the master, we directly use the logical plan nodes of Hive UDFs in `HivemallOps`. However, these nodes are the internal classes of Spark and the interfaces may evolve. So, this pr created a new file `HivemallOpsImpl` and put these classes there.
    
    ## What type of PR is it?
    Refactoring
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/HIVEMALL-39


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/maropu/incubator-hivemall HIVEMALL-39

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-hivemall/pull/29.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #29
    
----
commit 09c2233138f0976e0de8c871d319bd39f5819464
Author: Takeshi YAMAMURO <li...@gmail.com>
Date:   2017-01-26T15:12:54Z

    Put the use of HiveUDFs in one place

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #29: [HIVEMALL-39][SPARK] Put the use of HiveUDFs i...

Posted by myui <gi...@git.apache.org>.
Github user myui commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/29
  
    @maropu LGTM. Please merge and close this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #29: [HIVEMALL-39][SPARK] Put the use of HiveUDFs i...

Posted by maropu <gi...@git.apache.org>.
Github user maropu commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/29
  
    Merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #29: [HIVEMALL-39] Put the use of HiveUDFs in one p...

Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/29
  
    
    [![Coverage Status](https://coveralls.io/builds/9858422/badge)](https://coveralls.io/builds/9858422)
    
    Coverage increased (+0.3%) to 36.14% when pulling **d133ccc6698a4f53c5400f8bff4f069906da56fa on maropu:HIVEMALL-39** into **1801a62c15f4466c331456f6e2d7102b715d4a63 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall pull request #29: [HIVEMALL-39][SPARK] Put the use of Hiv...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-hivemall/pull/29


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #29: [HIVEMALL-39][SPARK] Put the use of HiveUDFs i...

Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/29
  
    
    [![Coverage Status](https://coveralls.io/builds/9868309/badge)](https://coveralls.io/builds/9868309)
    
    Coverage remained the same at 35.842% when pulling **c506a9b422a34bf6190760a724975f86315328d6 on maropu:HIVEMALL-39** into **70f42038a7b7f4c1d358d46ef30300a29dfbcef6 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #29: [HIVEMALL-39] Put the use of HiveUDFs in one p...

Posted by maropu <gi...@git.apache.org>.
Github user maropu commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/29
  
    @myui could you check this before merging it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---