You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Ivan Kelly (Created) (JIRA)" <ji...@apache.org> on 2012/02/07 17:49:00 UTC
[jira] [Created] (BOOKKEEPER-165) Add versioning support for
journal files
Add versioning support for journal files
----------------------------------------
Key: BOOKKEEPER-165
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-165
Project: Bookkeeper
Issue Type: New Feature
Reporter: Ivan Kelly
Assignee: Ivan Kelly
Fix For: 4.1.0
Add versioning in the journal so that we can add new features to the journal without breaking backward compatibility.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-165) Add versioning support for
journal files
Posted by "Ivan Kelly (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203649#comment-13203649 ]
Ivan Kelly commented on BOOKKEEPER-165:
---------------------------------------
Committed as r1241922
> Add versioning support for journal files
> ----------------------------------------
>
> Key: BOOKKEEPER-165
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-165
> Project: Bookkeeper
> Issue Type: New Feature
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-165.diff, BOOKKEEPER-165.diff
>
>
> Add versioning in the journal so that we can add new features to the journal without breaking backward compatibility.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-165) Add versioning support for
journal files
Posted by "Ivan Kelly (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated BOOKKEEPER-165:
----------------------------------
Attachment: BOOKKEEPER-165.diff
> Add versioning support for journal files
> ----------------------------------------
>
> Key: BOOKKEEPER-165
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-165
> Project: Bookkeeper
> Issue Type: New Feature
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-165.diff
>
>
> Add versioning in the journal so that we can add new features to the journal without breaking backward compatibility.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-165) Add versioning support for
journal files
Posted by "Ivan Kelly (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated BOOKKEEPER-165:
----------------------------------
Attachment: BOOKKEEPER-165.diff
Added accessor for version.
> Add versioning support for journal files
> ----------------------------------------
>
> Key: BOOKKEEPER-165
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-165
> Project: Bookkeeper
> Issue Type: New Feature
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-165.diff, BOOKKEEPER-165.diff
>
>
> Add versioning in the journal so that we can add new features to the journal without breaking backward compatibility.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-165) Add versioning support for
journal files
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203627#comment-13203627 ]
jiraposter@reviews.apache.org commented on BOOKKEEPER-165:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3776/#review4901
-----------------------------------------------------------
Ship it!
It looks good to me. +1
- Sijie
On 2012-02-07 17:41:21, Ivan Kelly wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3776/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-07 17:41:21)
bq.
bq.
bq. Review request for bookkeeper.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Add versioning in the journal so that we can add new features to the journal without breaking backward compatibility.
bq.
bq.
bq. This addresses bug BOOKKEEPER-165.
bq. https://issues.apache.org/jira/browse/BOOKKEEPER-165
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java 99b797f
bq. bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalChannel.java PRE-CREATION
bq. bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCache.java 0fc5206
bq. bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/BookieJournalTest.java PRE-CREATION
bq. bookkeeper-server/src/test/java/org/apache/bookkeeper/client/ClientUtil.java PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/3776/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Ivan
bq.
bq.
> Add versioning support for journal files
> ----------------------------------------
>
> Key: BOOKKEEPER-165
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-165
> Project: Bookkeeper
> Issue Type: New Feature
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-165.diff, BOOKKEEPER-165.diff
>
>
> Add versioning in the journal so that we can add new features to the journal without breaking backward compatibility.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-165) Add versioning support for
journal files
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202566#comment-13202566 ]
jiraposter@reviews.apache.org commented on BOOKKEEPER-165:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3776/
-----------------------------------------------------------
Review request for bookkeeper.
Summary
-------
Add versioning in the journal so that we can add new features to the journal without breaking backward compatibility.
This addresses bug BOOKKEEPER-165.
https://issues.apache.org/jira/browse/BOOKKEEPER-165
Diffs
-----
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java 99b797f
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalChannel.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCache.java 0fc5206
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/BookieJournalTest.java PRE-CREATION
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/ClientUtil.java PRE-CREATION
Diff: https://reviews.apache.org/r/3776/diff
Testing
-------
Thanks,
Ivan
> Add versioning support for journal files
> ----------------------------------------
>
> Key: BOOKKEEPER-165
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-165
> Project: Bookkeeper
> Issue Type: New Feature
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-165.diff, BOOKKEEPER-165.diff
>
>
> Add versioning in the journal so that we can add new features to the journal without breaking backward compatibility.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-165) Add versioning support for
journal files
Posted by "Ivan Kelly (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203637#comment-13203637 ]
Ivan Kelly commented on BOOKKEEPER-165:
---------------------------------------
Great, committing
> Add versioning support for journal files
> ----------------------------------------
>
> Key: BOOKKEEPER-165
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-165
> Project: Bookkeeper
> Issue Type: New Feature
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-165.diff, BOOKKEEPER-165.diff
>
>
> Add versioning in the journal so that we can add new features to the journal without breaking backward compatibility.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-165) Add versioning support for
journal files
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203670#comment-13203670 ]
Hudson commented on BOOKKEEPER-165:
-----------------------------------
Integrated in bookkeeper-trunk #351 (See [https://builds.apache.org/job/bookkeeper-trunk/351/])
BOOKKEEPER-165: Add versioning support for journal files (ivank)
ivank :
Files :
* /zookeeper/bookkeeper/trunk/CHANGES.txt
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalChannel.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCache.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/BookieJournalTest.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/client/ClientUtil.java
> Add versioning support for journal files
> ----------------------------------------
>
> Key: BOOKKEEPER-165
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-165
> Project: Bookkeeper
> Issue Type: New Feature
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-165.diff, BOOKKEEPER-165.diff
>
>
> Add versioning in the journal so that we can add new features to the journal without breaking backward compatibility.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira