You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2020/05/04 19:40:54 UTC
[GitHub] [storm] Ethanlm commented on a change in pull request #3263: STORM-3627 allow using short metric names for V2 metrics tick
Ethanlm commented on a change in pull request #3263:
URL: https://github.com/apache/storm/pull/3263#discussion_r419681532
##########
File path: storm-client/src/jvm/org/apache/storm/Config.java
##########
@@ -277,6 +277,12 @@
@IsBoolean
public static final String TOPOLOGY_ENABLE_V2_METRICS_TICK = "topology.enable.v2.metrics.tick";
+ /**
+ * This config allows V2 metrics reporting through the metrics tick to use short names.
+ */
+ @IsBoolean
+ public static final String TOPOLOGY_METRICS_USE_SHORTNAME = "topology.metrics.use.shortname";
Review comment:
We don't really need this config.
The taskIdMapping is only used for v2.metrics.tick. We save short name in the taskIdMapping to conform with V1 method of sending metrics.
Metrics register at codehale metricRegistry should just use the long time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org