You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/10/02 15:33:43 UTC
[GitHub] [beam] runningcode opened a new pull request #13000: [BEAM-10985] Fix flakiness with precommit flakes when publishing test report
runningcode opened a new pull request #13000:
URL: https://github.com/apache/beam/pull/13000
The previously declared output directory was completely empty. The test reports are stored in the newly declared output directory.
This will ensure that the task outputs are properly restored and that the tests are re-run when the test reports are missing.
Revert "Revert "Fix up-to-date checking mechanism on Tox Task.""
This reverts commit 36f9c1243e96f9d7f114275be427901dc7a7903b.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
--- | --- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
XLang | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website | Whitespace | Typescript
--- | --- | --- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) <br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | --- | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] udim commented on a change in pull request #13000: [BEAM-10985] Fix flakiness with precommit flakes when publishing test report
Posted by GitBox <gi...@apache.org>.
udim commented on a change in pull request #13000:
URL: https://github.com/apache/beam/pull/13000#discussion_r504140814
##########
File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -2063,8 +2066,13 @@ class BeamModulePlugin implements Plugin<Project> {
args '-c', ". ${project.ext.envdir}/bin/activate && cd ${copiedPyRoot} && scripts/run_tox.sh $tox_env $distTarBall '$posargs'"
}
}
- inputs.files project.pythonSdkDeps
- outputs.files project.fileTree(dir: "${pythonRootDir}/target/.tox/${tox_env}/log/")
+ outputs.cacheIf { true }
+ inputs.files(project.pythonSdkDeps)
+ .withPropertyName('pythonSdkDeps')
+ .withPathSensitivity(PathSensitivity.RELATIVE)
+
+ outputs.dir("${project.buildDir}/srcs/sdks/python/")
Review comment:
You're right, according to the docs:
projectDir | File | The directory containing the build script.
-- | -- | --
buildDir | File | projectDir/build
https://docs.gradle.org/current/userguide/writing_build_scripts.html
(aside: copy-pasting a table just generates the markdown? what)
So forget my comment above. However, by my understanding the new definition of `outputs` is still going to be empty after the task is run, but the screenshot above shows it has a copy of the repo (`pythonSdkDeps`?). What's causing this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #13000: [BEAM-10985] Fix flakiness with precommit flakes when publishing test report
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13000:
URL: https://github.com/apache/beam/pull/13000#issuecomment-702811777
# [Codecov](https://codecov.io/gh/apache/beam/pull/13000?src=pr&el=h1) Report
> Merging [#13000](https://codecov.io/gh/apache/beam/pull/13000?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/52698a42084100b70cebeb867925859b1c583ec0?el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `91.56%`.
[](https://codecov.io/gh/apache/beam/pull/13000?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13000 +/- ##
==========================================
- Coverage 82.51% 82.49% -0.02%
==========================================
Files 453 454 +1
Lines 54610 54732 +122
==========================================
+ Hits 45061 45151 +90
- Misses 9549 9581 +32
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/13000?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/profiler.py](https://codecov.io/gh/apache/beam/pull/13000/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvcHJvZmlsZXIucHk=) | `86.45% <80.00%> (ø)` | |
| [sdks/python/apache\_beam/dataframe/doctests.py](https://codecov.io/gh/apache/beam/pull/13000/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2RvY3Rlc3RzLnB5) | `96.75% <96.22%> (-0.45%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/filebasedsource.py](https://codecov.io/gh/apache/beam/pull/13000/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmlsZWJhc2Vkc291cmNlLnB5) | `98.77% <100.00%> (+0.02%)` | :arrow_up: |
| [sdks/python/apache\_beam/io/filesystemio.py](https://codecov.io/gh/apache/beam/pull/13000/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmlsZXN5c3RlbWlvLnB5) | `96.82% <100.00%> (+0.02%)` | :arrow_up: |
| [sdks/python/apache\_beam/pipeline.py](https://codecov.io/gh/apache/beam/pull/13000/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcGlwZWxpbmUucHk=) | `88.87% <100.00%> (+0.03%)` | :arrow_up: |
| [...ks/python/apache\_beam/runners/worker/data\_plane.py](https://codecov.io/gh/apache/beam/pull/13000/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvZGF0YV9wbGFuZS5weQ==) | `88.68% <0.00%> (-1.23%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/util.py](https://codecov.io/gh/apache/beam/pull/13000/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy91dGlsLnB5) | `95.44% <0.00%> (-0.19%)` | :arrow_down: |
| [...nners/portability/fn\_api\_runner/worker\_handlers.py](https://codecov.io/gh/apache/beam/pull/13000/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3dvcmtlcl9oYW5kbGVycy5weQ==) | `80.57% <0.00%> (-0.18%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/13000/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `89.98% <0.00%> (-0.17%)` | :arrow_down: |
| ... and [4 more](https://codecov.io/gh/apache/beam/pull/13000/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13000?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13000?src=pr&el=footer). Last update [969b0c6...d8d8c38](https://codecov.io/gh/apache/beam/pull/13000?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #13000: [BEAM-10985] Fix flakiness with precommit flakes when publishing test report
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13000:
URL: https://github.com/apache/beam/pull/13000#issuecomment-1032573340
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] udim commented on a change in pull request #13000: [BEAM-10985] Fix flakiness with precommit flakes when publishing test report
Posted by GitBox <gi...@apache.org>.
udim commented on a change in pull request #13000:
URL: https://github.com/apache/beam/pull/13000#discussion_r503442452
##########
File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -2063,8 +2066,13 @@ class BeamModulePlugin implements Plugin<Project> {
args '-c', ". ${project.ext.envdir}/bin/activate && cd ${copiedPyRoot} && scripts/run_tox.sh $tox_env $distTarBall '$posargs'"
}
}
- inputs.files project.pythonSdkDeps
- outputs.files project.fileTree(dir: "${pythonRootDir}/target/.tox/${tox_env}/log/")
+ outputs.cacheIf { true }
+ inputs.files(project.pythonSdkDeps)
+ .withPropertyName('pythonSdkDeps')
+ .withPathSensitivity(PathSensitivity.RELATIVE)
+
+ outputs.dir("${project.buildDir}/srcs/sdks/python/")
Review comment:
I don't have an alternative solution, but it seems that marking everything under `sdks/python` as output will include the output from all `tox_envs`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] runningcode commented on pull request #13000: [BEAM-10985] Fix flakiness with precommit flakes when publishing test report
Posted by GitBox <gi...@apache.org>.
runningcode commented on pull request #13000:
URL: https://github.com/apache/beam/pull/13000#issuecomment-704925913
If all the files are in place then the up-to-date checks will work. However, gradle will recognize the overlapping outputs and not pull things from the build cache in that case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on a change in pull request #13000: [BEAM-10985] Fix flakiness with precommit flakes when publishing test report
Posted by GitBox <gi...@apache.org>.
kennknowles commented on a change in pull request #13000:
URL: https://github.com/apache/beam/pull/13000#discussion_r508678719
##########
File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -2063,8 +2066,13 @@ class BeamModulePlugin implements Plugin<Project> {
args '-c', ". ${project.ext.envdir}/bin/activate && cd ${copiedPyRoot} && scripts/run_tox.sh $tox_env $distTarBall '$posargs'"
}
}
- inputs.files project.pythonSdkDeps
- outputs.files project.fileTree(dir: "${pythonRootDir}/target/.tox/${tox_env}/log/")
+ outputs.cacheIf { true }
+ inputs.files(project.pythonSdkDeps)
+ .withPropertyName('pythonSdkDeps')
+ .withPathSensitivity(PathSensitivity.RELATIVE)
+
+ outputs.dir("${project.buildDir}/srcs/sdks/python/")
Review comment:
I'm not sure I understand.
I think by this line `outputs` should contain a dir-type output for `build/srcs/sdks/python`:
```python
outputs.dir("${project.buildDir}/srcs/sdks/python/")
```
The screenshot shows the state of `build/`, which isn't limited to the things in `outputs`. At least part of it is explained by:
```python
def copiedSrcRoot = "${project.buildDir}/srcs"
...
project.copy { from project.pythonSdkDeps; into copiedSrcRoot }
```
If I were debugging this, I would start by making tasks have more disjoint directories named roughly after the task itself so I was very certain that each directory had sole ownership and I could easily map the directory back to the task that created it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] udim commented on pull request #13000: [BEAM-10985] Fix flakiness with precommit flakes when publishing test report
Posted by GitBox <gi...@apache.org>.
udim commented on pull request #13000:
URL: https://github.com/apache/beam/pull/13000#issuecomment-707255039
> The coverage reports are places in the directory declared as an output
What does that mean? Usually when I think coverage reports, I think of unit test coverage. Is that what you mean here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13000: [BEAM-10985] Fix flakiness with precommit flakes when publishing test report
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13000:
URL: https://github.com/apache/beam/pull/13000#issuecomment-702811777
# [Codecov](https://codecov.io/gh/apache/beam/pull/13000?src=pr&el=h1) Report
> Merging [#13000](https://codecov.io/gh/apache/beam/pull/13000?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/52698a42084100b70cebeb867925859b1c583ec0?el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `91.56%`.
[](https://codecov.io/gh/apache/beam/pull/13000?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13000 +/- ##
==========================================
- Coverage 82.51% 82.49% -0.02%
==========================================
Files 453 454 +1
Lines 54610 54732 +122
==========================================
+ Hits 45061 45151 +90
- Misses 9549 9581 +32
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/13000?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/profiler.py](https://codecov.io/gh/apache/beam/pull/13000/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvcHJvZmlsZXIucHk=) | `86.45% <80.00%> (ø)` | |
| [sdks/python/apache\_beam/dataframe/doctests.py](https://codecov.io/gh/apache/beam/pull/13000/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2RvY3Rlc3RzLnB5) | `96.75% <96.22%> (-0.45%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/filebasedsource.py](https://codecov.io/gh/apache/beam/pull/13000/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmlsZWJhc2Vkc291cmNlLnB5) | `98.77% <100.00%> (+0.02%)` | :arrow_up: |
| [sdks/python/apache\_beam/io/filesystemio.py](https://codecov.io/gh/apache/beam/pull/13000/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmlsZXN5c3RlbWlvLnB5) | `96.82% <100.00%> (+0.02%)` | :arrow_up: |
| [sdks/python/apache\_beam/pipeline.py](https://codecov.io/gh/apache/beam/pull/13000/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcGlwZWxpbmUucHk=) | `88.87% <100.00%> (+0.03%)` | :arrow_up: |
| [...ks/python/apache\_beam/runners/worker/data\_plane.py](https://codecov.io/gh/apache/beam/pull/13000/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvZGF0YV9wbGFuZS5weQ==) | `88.68% <0.00%> (-1.23%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/util.py](https://codecov.io/gh/apache/beam/pull/13000/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy91dGlsLnB5) | `95.44% <0.00%> (-0.19%)` | :arrow_down: |
| [...nners/portability/fn\_api\_runner/worker\_handlers.py](https://codecov.io/gh/apache/beam/pull/13000/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3dvcmtlcl9oYW5kbGVycy5weQ==) | `80.57% <0.00%> (-0.18%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/13000/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `89.98% <0.00%> (-0.17%)` | :arrow_down: |
| ... and [4 more](https://codecov.io/gh/apache/beam/pull/13000/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13000?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13000?src=pr&el=footer). Last update [969b0c6...d8d8c38](https://codecov.io/gh/apache/beam/pull/13000?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #13000: [BEAM-10985] Fix flakiness with precommit flakes when publishing test report
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #13000:
URL: https://github.com/apache/beam/pull/13000#issuecomment-702834952
Isn't this "potential downside" a major problem? How do up to date checks work then?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] runningcode commented on pull request #13000: [BEAM-10985] Fix flakiness with precommit flakes when publishing test report
Posted by GitBox <gi...@apache.org>.
runningcode commented on pull request #13000:
URL: https://github.com/apache/beam/pull/13000#issuecomment-702806518
R: @kennknowles R: @udim R: @ibzib
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13000: [BEAM-10985] Fix flakiness with precommit flakes when publishing test report
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13000:
URL: https://github.com/apache/beam/pull/13000#issuecomment-702811777
# [Codecov](https://codecov.io/gh/apache/beam/pull/13000?src=pr&el=h1) Report
> Merging [#13000](https://codecov.io/gh/apache/beam/pull/13000?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/52698a42084100b70cebeb867925859b1c583ec0?el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `91.56%`.
[](https://codecov.io/gh/apache/beam/pull/13000?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13000 +/- ##
==========================================
- Coverage 82.51% 82.49% -0.02%
==========================================
Files 453 454 +1
Lines 54610 54732 +122
==========================================
+ Hits 45061 45151 +90
- Misses 9549 9581 +32
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/13000?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/profiler.py](https://codecov.io/gh/apache/beam/pull/13000/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvcHJvZmlsZXIucHk=) | `86.45% <80.00%> (ø)` | |
| [sdks/python/apache\_beam/dataframe/doctests.py](https://codecov.io/gh/apache/beam/pull/13000/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2RvY3Rlc3RzLnB5) | `96.75% <96.22%> (-0.45%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/filebasedsource.py](https://codecov.io/gh/apache/beam/pull/13000/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmlsZWJhc2Vkc291cmNlLnB5) | `98.77% <100.00%> (+0.02%)` | :arrow_up: |
| [sdks/python/apache\_beam/io/filesystemio.py](https://codecov.io/gh/apache/beam/pull/13000/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmlsZXN5c3RlbWlvLnB5) | `96.82% <100.00%> (+0.02%)` | :arrow_up: |
| [sdks/python/apache\_beam/pipeline.py](https://codecov.io/gh/apache/beam/pull/13000/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcGlwZWxpbmUucHk=) | `88.87% <100.00%> (+0.03%)` | :arrow_up: |
| [...ks/python/apache\_beam/runners/worker/data\_plane.py](https://codecov.io/gh/apache/beam/pull/13000/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvZGF0YV9wbGFuZS5weQ==) | `88.68% <0.00%> (-1.23%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/util.py](https://codecov.io/gh/apache/beam/pull/13000/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy91dGlsLnB5) | `95.44% <0.00%> (-0.19%)` | :arrow_down: |
| [...nners/portability/fn\_api\_runner/worker\_handlers.py](https://codecov.io/gh/apache/beam/pull/13000/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3dvcmtlcl9oYW5kbGVycy5weQ==) | `80.57% <0.00%> (-0.18%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/13000/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `89.98% <0.00%> (-0.17%)` | :arrow_down: |
| ... and [4 more](https://codecov.io/gh/apache/beam/pull/13000/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13000?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13000?src=pr&el=footer). Last update [969b0c6...d8d8c38](https://codecov.io/gh/apache/beam/pull/13000?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] stale[bot] commented on pull request #13000: [BEAM-10985] Fix flakiness with precommit flakes when publishing test report
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #13000:
URL: https://github.com/apache/beam/pull/13000#issuecomment-751236017
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13000: [BEAM-10985] Fix flakiness with precommit flakes when publishing test report
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13000:
URL: https://github.com/apache/beam/pull/13000#issuecomment-702811777
# [Codecov](https://codecov.io/gh/apache/beam/pull/13000?src=pr&el=h1) Report
> Merging [#13000](https://codecov.io/gh/apache/beam/pull/13000?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/52698a42084100b70cebeb867925859b1c583ec0?el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `91.56%`.
[](https://codecov.io/gh/apache/beam/pull/13000?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13000 +/- ##
==========================================
- Coverage 82.51% 82.49% -0.02%
==========================================
Files 453 454 +1
Lines 54610 54732 +122
==========================================
+ Hits 45061 45151 +90
- Misses 9549 9581 +32
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/13000?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/profiler.py](https://codecov.io/gh/apache/beam/pull/13000/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvcHJvZmlsZXIucHk=) | `86.45% <80.00%> (ø)` | |
| [sdks/python/apache\_beam/dataframe/doctests.py](https://codecov.io/gh/apache/beam/pull/13000/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2RvY3Rlc3RzLnB5) | `96.75% <96.22%> (-0.45%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/filebasedsource.py](https://codecov.io/gh/apache/beam/pull/13000/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmlsZWJhc2Vkc291cmNlLnB5) | `98.77% <100.00%> (+0.02%)` | :arrow_up: |
| [sdks/python/apache\_beam/io/filesystemio.py](https://codecov.io/gh/apache/beam/pull/13000/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmlsZXN5c3RlbWlvLnB5) | `96.82% <100.00%> (+0.02%)` | :arrow_up: |
| [sdks/python/apache\_beam/pipeline.py](https://codecov.io/gh/apache/beam/pull/13000/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcGlwZWxpbmUucHk=) | `88.87% <100.00%> (+0.03%)` | :arrow_up: |
| [...ks/python/apache\_beam/runners/worker/data\_plane.py](https://codecov.io/gh/apache/beam/pull/13000/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvZGF0YV9wbGFuZS5weQ==) | `88.68% <0.00%> (-1.23%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/util.py](https://codecov.io/gh/apache/beam/pull/13000/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy91dGlsLnB5) | `95.44% <0.00%> (-0.19%)` | :arrow_down: |
| [...nners/portability/fn\_api\_runner/worker\_handlers.py](https://codecov.io/gh/apache/beam/pull/13000/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3dvcmtlcl9oYW5kbGVycy5weQ==) | `80.57% <0.00%> (-0.18%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/13000/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `89.98% <0.00%> (-0.17%)` | :arrow_down: |
| ... and [4 more](https://codecov.io/gh/apache/beam/pull/13000/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13000?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13000?src=pr&el=footer). Last update [969b0c6...d8d8c38](https://codecov.io/gh/apache/beam/pull/13000?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] closed pull request #13000: [BEAM-10985] Fix flakiness with precommit flakes when publishing test report
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #13000:
URL: https://github.com/apache/beam/pull/13000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on a change in pull request #13000: [BEAM-10985] Fix flakiness with precommit flakes when publishing test report
Posted by GitBox <gi...@apache.org>.
kennknowles commented on a change in pull request #13000:
URL: https://github.com/apache/beam/pull/13000#discussion_r503407662
##########
File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -2063,8 +2066,13 @@ class BeamModulePlugin implements Plugin<Project> {
args '-c', ". ${project.ext.envdir}/bin/activate && cd ${copiedPyRoot} && scripts/run_tox.sh $tox_env $distTarBall '$posargs'"
}
}
- inputs.files project.pythonSdkDeps
- outputs.files project.fileTree(dir: "${pythonRootDir}/target/.tox/${tox_env}/log/")
+ outputs.cacheIf { true }
+ inputs.files(project.pythonSdkDeps)
+ .withPropertyName('pythonSdkDeps')
+ .withPathSensitivity(PathSensitivity.RELATIVE)
+
+ outputs.dir("${project.buildDir}/srcs/sdks/python/")
Review comment:
Switching to `$project.buildDir` is definitely a major improvement. Is there a reason that tox outputs are dumped alongside the source? Is that something we can easily control and put them in, say, `build/reports/tox` or some such?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on a change in pull request #13000: [BEAM-10985] Fix flakiness with precommit flakes when publishing test report
Posted by GitBox <gi...@apache.org>.
kennknowles commented on a change in pull request #13000:
URL: https://github.com/apache/beam/pull/13000#discussion_r503538426
##########
File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -2063,8 +2066,13 @@ class BeamModulePlugin implements Plugin<Project> {
args '-c', ". ${project.ext.envdir}/bin/activate && cd ${copiedPyRoot} && scripts/run_tox.sh $tox_env $distTarBall '$posargs'"
}
}
- inputs.files project.pythonSdkDeps
- outputs.files project.fileTree(dir: "${pythonRootDir}/target/.tox/${tox_env}/log/")
+ outputs.cacheIf { true }
+ inputs.files(project.pythonSdkDeps)
+ .withPropertyName('pythonSdkDeps')
+ .withPathSensitivity(PathSensitivity.RELATIVE)
+
+ outputs.dir("${project.buildDir}/srcs/sdks/python/")
Review comment:
Just to clarify the full path, it is marking everything under `build/src/sdks/python` as output here. Am I wrong that `${project.buildDir}` is the `build/` directory relative to the `build.gradle` file of the module? Certainly everything under there is fine to be an output. But keeping outputs from different tasks in totally different places is nice. Just a nice to have. So `build/src/sdks/python` is the copy/pasted source while `build/reports/tox/` would be the output from tox. But TBH I am just dropping in with generic opinions. My very quick read of the build logic and comments was that `build/src/sdks/python` existed primarily so that tox (and/or other tools) would not dump files all over the original source tree. So if that is its purpose it makes sense to let the tools put their stuff in their and call it good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org