[jira] [Updated] (OOZIE-1202) ActionKillXCommand precondition is wrong

["Robert Kanter (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OOZIE-1202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Kanter updated OOZIE-1202:
---------------------------------

    Attachment: OOZIE-1202.patch

The patch simply switches {{!=}} to {{==}} and adds some tests for the precondition checking
                
> ActionKillXCommand precondition is wrong
> ----------------------------------------
>
>                 Key: OOZIE-1202
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1202
>             Project: Oozie
>          Issue Type: Bug
>          Components: action
>    Affects Versions: trunk
>            Reporter: Robert Kanter
>            Assignee: Robert Kanter
>             Fix For: trunk
>
>         Attachments: OOZIE-1202.patch
>
>
> The {{ActionKillXCommand}}, which kills actions, has the following precondition:
> {code}
> protected void verifyPrecondition() throws CommandException, PreconditionException {
>     if (wfAction.getStatus() != WorkflowActionBean.Status.KILLED) {
>         throw new PreconditionException(ErrorCode.E0726, wfAction.getId());
>     }
> }
> {code}
> This means that if the only way to pass the precondition is for the action to already have been KILLED, which is backwards.  We want the precondition to pass only when the action has not already been KILLED.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira