You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/08/28 13:45:02 UTC
[GitHub] [spark] yaooqinn opened a new pull request #29571: [MINOR][SQL][DOCS] Add missing since version for math functions
yaooqinn opened a new pull request #29571:
URL: https://github.com/apache/spark/pull/29571
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
Add missing since version for math functions, including
SPARK-8223 shiftright/shiftleft
SPARK-8215 pi
SPARK-8212 e
SPARK-6829 sin/asin/sinh/cos/acos/cosh/tan/atan/tanh/ceil/floor/rint/cbrt/signum/isignum/Fsignum/Lsignum/degrees/radians/log/log10/log1p/exp/expm1/pow/hypot/atan2
SPARK-8209 conv
SPARK-8213 factorial
SPARK-20751 cot
SPARK-2813 sqrt
SPARK-8227 unhex
SPARK-8218 log(a,b)
SPARK-8207 bin
SPARK-8214 hex
SPARK-8206 round
SPARK-14614 bround
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
fix SQL docs
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
yes, doc updated
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
passing doc generation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29571: [SPARK-32729][SQL][DOCS] Add missing since version for math functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29571:
URL: https://github.com/apache/spark/pull/29571#issuecomment-683026689
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29571: [SPARK-32729][SQL][DOCS] Add missing since version for math functions
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29571:
URL: https://github.com/apache/spark/pull/29571#issuecomment-682585156
**[Test build #127994 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127994/testReport)** for PR 29571 at commit [`4700ae9`](https://github.com/apache/spark/commit/4700ae9ea7845325455caee3ff3363d8b47e1f3f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #29571: [SPARK-32729][SQL][DOCS] Add missing since version for math functions
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #29571:
URL: https://github.com/apache/spark/pull/29571
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29571: [MINOR][SQL][DOCS] Add missing since version for math functions
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29571:
URL: https://github.com/apache/spark/pull/29571#issuecomment-682646200
Nice, thanks @yaooqinn for working on this. +1 for a JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29571: [MINOR][SQL][DOCS] Add missing since version for math functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29571:
URL: https://github.com/apache/spark/pull/29571#issuecomment-682585630
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29571: [MINOR][SQL][DOCS] Add missing since version for math functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29571:
URL: https://github.com/apache/spark/pull/29571#issuecomment-682585630
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29571: [MINOR][SQL][DOCS] Add missing since version for math functions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29571:
URL: https://github.com/apache/spark/pull/29571#issuecomment-682585156
**[Test build #127994 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127994/testReport)** for PR 29571 at commit [`4700ae9`](https://github.com/apache/spark/commit/4700ae9ea7845325455caee3ff3363d8b47e1f3f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29571: [SPARK-32729][SQL][DOCS] Add missing since version for math functions
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29571:
URL: https://github.com/apache/spark/pull/29571#issuecomment-682717338
Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29571: [SPARK-32729][SQL][DOCS] Add missing since version for math functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29571:
URL: https://github.com/apache/spark/pull/29571#issuecomment-683026689
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #29571: [MINOR][SQL][DOCS] Add missing since version for math functions
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #29571:
URL: https://github.com/apache/spark/pull/29571#issuecomment-682595148
Thanks for the work, @yaooqinn ! I think its better to file a jira for the update.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #29571: [SPARK-32729][SQL][DOCS] Add missing since version for math functions
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #29571:
URL: https://github.com/apache/spark/pull/29571#issuecomment-682663888
thanks, @maropu @HyukjinKwon, I have filed a Jira ticket SPARK-32729
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29571: [SPARK-32729][SQL][DOCS] Add missing since version for math functions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29571:
URL: https://github.com/apache/spark/pull/29571#issuecomment-683023416
**[Test build #127994 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127994/testReport)** for PR 29571 at commit [`4700ae9`](https://github.com/apache/spark/commit/4700ae9ea7845325455caee3ff3363d8b47e1f3f).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #29571: [MINOR][SQL][DOCS] Add missing since version for math functions
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #29571:
URL: https://github.com/apache/spark/pull/29571#issuecomment-682583897
cc @cloud-fan @maropu @HyukjinKwon @dongjoon-hyun, thanks a bunch~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org