You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2012/10/09 17:59:24 UTC
Review Request: SQOOP-625: Enforce checking advertised maximal size for
MStringInput
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7499/
-----------------------------------------------------------
Review request for Sqoop.
Description
-------
I've put code that is enforcing maximal size for MStringInput as was configured by connector/framework.
This addresses bug SQOOP-625.
https://issues.apache.org/jira/browse/SQOOP-625
Diffs
-----
client/src/main/java/org/apache/sqoop/client/utils/FormFiller.java df3929163f30927806a0d6882a7aaeef42e6b6e8
Diff: https://reviews.apache.org/r/7499/diff/
Testing
-------
No new unit tests were added. I've manually tested behavior.
Thanks,
Jarek Cecho
Re: Review Request: SQOOP-625: Enforce checking advertised maximal size for
MStringInput
Posted by Bilung Lee <bl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7499/#review12414
-----------------------------------------------------------
Ship it!
Ship It!
- Bilung Lee
On Oct. 9, 2012, 3:59 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7499/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2012, 3:59 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've put code that is enforcing maximal size for MStringInput as was configured by connector/framework.
>
>
> This addresses bug SQOOP-625.
> https://issues.apache.org/jira/browse/SQOOP-625
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/utils/FormFiller.java df3929163f30927806a0d6882a7aaeef42e6b6e8
>
> Diff: https://reviews.apache.org/r/7499/diff/
>
>
> Testing
> -------
>
> No new unit tests were added. I've manually tested behavior.
>
>
> Thanks,
>
> Jarek Cecho
>
>