You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/08/17 08:26:09 UTC
[GitHub] [kafka] janikdotzel opened a new pull request, #12523: Docs(Quickstart Guide): Fix invalid link to plugin.path
janikdotzel opened a new pull request, #12523:
URL: https://github.com/apache/kafka/pull/12523
The link to the plugin.path is not pointing to the correct site.
I simply added `/documentation/` to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] janikdotzel commented on pull request #12523: Docs(Quickstart Guide): Fix invalid link to plugin.path
Posted by GitBox <gi...@apache.org>.
janikdotzel commented on PR #12523:
URL: https://github.com/apache/kafka/pull/12523#issuecomment-1218275352
@C0urante What do you think?
If you agree with my second solution the current change in the docs is already correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] C0urante merged pull request #12523: Docs(Quickstart Guide): Fix invalid link to plugin.path
Posted by GitBox <gi...@apache.org>.
C0urante merged PR #12523:
URL: https://github.com/apache/kafka/pull/12523
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] C0urante commented on pull request #12523: Docs(Quickstart Guide): Fix invalid link to plugin.path
Posted by GitBox <gi...@apache.org>.
C0urante commented on PR #12523:
URL: https://github.com/apache/kafka/pull/12523#issuecomment-1218254751
@janikdotzel this link is working for me, with both the current docs site (https://kafka.apache.org/documentation.html) and the docs for a prior version (https://kafka.apache.org/32/documentation.html). The former leads me to https://kafka.apache.org/documentation.html#connectconfigs_plugin.path, and the latter to https://kafka.apache.org/32/documentation.html#connectconfigs_plugin.path.
Can you describe what you're seeing that appears to be broken here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] janikdotzel commented on pull request #12523: Docs(Quickstart Guide): Fix invalid link to plugin.path
Posted by GitBox <gi...@apache.org>.
janikdotzel commented on PR #12523:
URL: https://github.com/apache/kafka/pull/12523#issuecomment-1218273288
My behavior was visiting the quickstart guide [https://kafka.apache.org/quickstart](https://kafka.apache.org/quickstart).
Clicking on the link leads me to [https://kafka.apache.org/quickstart#connectconfigs_plugin.path](https://kafka.apache.org/quickstart#connectconfigs_plugin.path), which is not available.
Your comment has shown me, that the whole quickstart guide is embedded in two (or even more places).
First place `/documentation/#quickstart`
Second place `/quickstart`
I have two solutions in mind to solve this issue:
1. Route each link in the quickstart guide to their corresponding page. E.g. If someone is on page /quickstart route him to /quickstart and so on. However this would be a lot of work.
2. Always route the request to /documentation/#quickstart. This is already done for the other links. E.g. `<a href="/documentation/#connect">Kafka Connect</a>` from line 163 of the same file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org