[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2994: ARTEMIS-2637 Making UDP client discovery resilient

[GitBox <gi...@apache.org>]

clebertsuconic commented on a change in pull request #2994: ARTEMIS-2637 Making UDP client discovery resilient
URL: https://github.com/apache/activemq-artemis/pull/2994#discussion_r385754151
 
 

 ##########
 File path: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/topology/NettyHAClientTopologyWithDiscoveryTest.java
 ##########
 @@ -16,11 +16,146 @@
  */
 package org.apache.activemq.artemis.tests.integration.cluster.topology;
 
+import org.apache.activemq.artemis.api.core.DiscoveryGroupConfiguration;
+import org.apache.activemq.artemis.api.core.UDPBroadcastEndpointFactory;
+import org.apache.activemq.artemis.api.core.client.ActiveMQClient;
+import org.apache.activemq.artemis.api.core.client.ClientSession;
+import org.apache.activemq.artemis.api.core.client.ClientSessionFactory;
+import org.apache.activemq.artemis.core.client.impl.ServerLocatorImpl;
+import org.junit.Assert;
+import org.junit.Test;
+
+import java.util.concurrent.CyclicBarrier;
+import java.util.concurrent.atomic.AtomicInteger;
+
 public class NettyHAClientTopologyWithDiscoveryTest extends HAClientTopologyWithDiscoveryTest {
 
    @Override
    protected boolean isNetty() {
       return true;
    }
 
+
+
+   @Test
+   public void testRecoveryBadUDPWithRetry() throws Exception {
 
 Review comment:
   no. the retry should fix it and it should succeed.
   
   The assertion is no failures.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services