You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by ChugR <gi...@git.apache.org> on 2018/07/09 22:19:14 UTC
[GitHub] qpid-dispatch pull request #340: Dispatch-1055: Router fails to propagage cr...
GitHub user ChugR opened a pull request:
https://github.com/apache/qpid-dispatch/pull/340
Dispatch-1055: Router fails to propagage credit on link router after drain cycle
In this PR the "fix" is all in transfer.c.
* The router was not accounting for transfers that never arrive when drain consumes the credit without sending messages. The fix is to reset the internal credit counts when a drain cycle ends.
* The router calculates if drain changed more correctly.
The commit also adds a test that works when not in link route and fails in a link route.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ChugR/qpid-dispatch DISPATCH-1055-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-dispatch/pull/340.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #340
----
commit baa4d92a9cf6e3ce92199df60a009119b834fd96
Author: Chuck Rolke <cr...@...>
Date: 2018-06-29T21:43:24Z
DISPATCH-1055: Add a test that demonstrates the credit error
The test is run first without a link route to observe that it works.
Then it is run with the link route and hangs.
commit a9b37f030785d1bdd4d9900b5f0be41ded1b2aa9
Author: Chuck Rolke <cr...@...>
Date: 2018-07-09T20:23:08Z
DISPATCH-1055: Fix drain propagated over link route
Reset incremental credit given to core at end of drain cycle.
Fix logic computing drain_changed flag.
commit 52df18eff7f6429ab6fd99ec777136153423afe1
Author: Chuck Rolke <cr...@...>
Date: 2018-07-09T21:05:51Z
fix drain_changed logic
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #340: Dispatch-1055: Router fails to propagage cr...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/qpid-dispatch/pull/340
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org