You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/08/23 09:59:10 UTC
[GitHub] [shardingsphere] tuichenchuxin opened a new pull request #11956: Oracle load test
tuichenchuxin opened a new pull request #11956:
URL: https://github.com/apache/shardingsphere/pull/11956
Fixes #11927.
Changes proposed in this pull request:
- Oracle dialect load `collation` fix
- modify test case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Liangda-w commented on pull request #11956: Oracle load test
Posted by GitBox <gi...@apache.org>.
Liangda-w commented on pull request #11956:
URL: https://github.com/apache/shardingsphere/pull/11956#issuecomment-904085776
> @Liangda-w Hi, I saw you first commit about oracle load support. I tested on version 12.1. But `connection.getCatalog()` return null, I use `connection.getSchema()` to replace, then it works. I want to know why is `connection.getCatalog()` , `connection.getSchema()` can be ok?
Hi, thanks for the correction! you can refer to [this](https://stackoverflow.com/questions/43109125/connection-getcatalog-returns-null-for-oracle)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #11956: Oracle load test
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #11956:
URL: https://github.com/apache/shardingsphere/pull/11956#issuecomment-903973614
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11956?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#11956](https://codecov.io/gh/apache/shardingsphere/pull/11956?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (79fc3c7) into [master](https://codecov.io/gh/apache/shardingsphere/commit/67930a28833779b0f5eb41192303b432a24113ea?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (67930a2) will **increase** coverage by `0.07%`.
> The diff coverage is `90.00%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/11956?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #11956 +/- ##
============================================
+ Coverage 63.04% 63.11% +0.07%
- Complexity 1229 1235 +6
============================================
Files 2293 2293
Lines 34868 34867 -1
Branches 6062 6064 +2
============================================
+ Hits 21982 22008 +26
+ Misses 11106 11080 -26
+ Partials 1780 1779 -1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/11956?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...lder/loader/dialect/OracleTableMetaDataLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/11956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9zY2hlbWEvYnVpbGRlci9sb2FkZXIvZGlhbGVjdC9PcmFjbGVUYWJsZU1ldGFEYXRhTG9hZGVyLmphdmE=) | `87.14% <90.00%> (+1.22%)` | :arrow_up: |
| [...d/text/distsql/ral/common/hint/HintSourceType.java](https://codecov.io/gh/apache/shardingsphere/pull/11956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL2NvbW1vbi9oaW50L0hpbnRTb3VyY2VUeXBlLmphdmE=) | `0.00% <0.00%> (-42.86%)` | :arrow_down: |
| [...here/infra/binder/segment/table/TablesContext.java](https://codecov.io/gh/apache/shardingsphere/pull/11956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtYmluZGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9iaW5kZXIvc2VnbWVudC90YWJsZS9UYWJsZXNDb250ZXh0LmphdmE=) | `70.27% <0.00%> (-1.53%)` | :arrow_down: |
| [...a/binder/statement/dml/SelectStatementContext.java](https://codecov.io/gh/apache/shardingsphere/pull/11956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtYmluZGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9iaW5kZXIvc3RhdGVtZW50L2RtbC9TZWxlY3RTdGF0ZW1lbnRDb250ZXh0LmphdmE=) | `73.56% <0.00%> (ø)` | |
| [...classbased/ClassBasedShardingAlgorithmFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/11956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvYWxnb3JpdGhtL3NoYXJkaW5nL2NsYXNzYmFzZWQvQ2xhc3NCYXNlZFNoYXJkaW5nQWxnb3JpdGhtRmFjdG9yeS5qYXZh) | `100.00% <0.00%> (ø)` | |
| [...or/impl/keygen/BaseGeneratedKeyTokenGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/11956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcmV3cml0ZS90b2tlbi9nZW5lcmF0b3IvaW1wbC9rZXlnZW4vQmFzZUdlbmVyYXRlZEtleVRva2VuR2VuZXJhdG9yLmphdmE=) | `33.33% <0.00%> (+33.33%)` | :arrow_up: |
| [...jo/ParameterMarkerGeneratedKeyAssignmentToken.java](https://codecov.io/gh/apache/shardingsphere/pull/11956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcmV3cml0ZS90b2tlbi9wb2pvL1BhcmFtZXRlck1hcmtlckdlbmVyYXRlZEtleUFzc2lnbm1lbnRUb2tlbi5qYXZh) | `66.66% <0.00%> (+66.66%)` | :arrow_up: |
| [...ewrite/token/pojo/GeneratedKeyAssignmentToken.java](https://codecov.io/gh/apache/shardingsphere/pull/11956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcmV3cml0ZS90b2tlbi9wb2pvL0dlbmVyYXRlZEtleUFzc2lnbm1lbnRUb2tlbi5qYXZh) | `75.00% <0.00%> (+75.00%)` | :arrow_up: |
| [...token/pojo/LiteralGeneratedKeyAssignmentToken.java](https://codecov.io/gh/apache/shardingsphere/pull/11956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcmV3cml0ZS90b2tlbi9wb2pvL0xpdGVyYWxHZW5lcmF0ZWRLZXlBc3NpZ25tZW50VG9rZW4uamF2YQ==) | `75.00% <0.00%> (+75.00%)` | :arrow_up: |
| [...l/keygen/GeneratedKeyAssignmentTokenGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/11956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcmV3cml0ZS90b2tlbi9nZW5lcmF0b3IvaW1wbC9rZXlnZW4vR2VuZXJhdGVkS2V5QXNzaWdubWVudFRva2VuR2VuZXJhdG9yLmphdmE=) | `80.00% <0.00%> (+80.00%)` | :arrow_up: |
| ... and [1 more](https://codecov.io/gh/apache/shardingsphere/pull/11956/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11956?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11956?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [67930a2...79fc3c7](https://codecov.io/gh/apache/shardingsphere/pull/11956?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #11956: Oracle load test
Posted by GitBox <gi...@apache.org>.
strongduanmu merged pull request #11956:
URL: https://github.com/apache/shardingsphere/pull/11956
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tuichenchuxin commented on pull request #11956: Oracle load test
Posted by GitBox <gi...@apache.org>.
tuichenchuxin commented on pull request #11956:
URL: https://github.com/apache/shardingsphere/pull/11956#issuecomment-903627894
@Liangda-w Hi, I saw you first commit about oracle load support. I tested on version 12.1. But `connection.getCatalog()` return null, I use `connection.getSchema()` to replace, then it works. I want to know why is `connection.getCatalog()` , `connection.getSchema()` can be ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org